Stefan Hajnoczi c685293aa3 net/atm: sk_err_soft must be positive ... The sk_err and sk_err_soft fields are positive errno values and userspace applications rely on this when using getsockopt(SO_ERROR). ATM code places an -errno into sk_err_soft in sigd_send() and returns it from svc_addparty()/svc_dropparty(). Although I am not familiar with ATM code I came to this conclusion because: 1. sigd_send() msg->type cases as_okay and as_error both have: sk->sk_err = -msg->reply; while the as_addparty and as_dropparty cases have: sk->sk_err_soft = msg->reply; This is the source of the inconsistency. 2. svc_addparty() returns an -errno and assumes sk_err_soft is also an -errno: if (flags & O_NONBLOCK) { error = -EINPROGRESS; goto out; } ... error = xchg(&sk->sk_err_soft, 0); out: release_sock(sk); return error; This shows that sk_err_soft is indeed being treated as an -errno. This patch ensures that sk_err_soft is always a positive errno. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2016-05-23 13:51:10 -07:00
..
addr.c
addr.h
atm_misc.c
atm_sysfs.c
br2684.c
clip.c
common.c
common.h
ioctl.c
Kconfig
lec_arpc.h
lec.c
lec.h
Makefile
mpc.c
mpc.h
mpoa_caches.c
mpoa_caches.h
mpoa_proc.c
pppoatm.c
proc.c
protocols.h
pvc.c
raw.c
resources.c
resources.h
signaling.c	net/atm: sk_err_soft must be positive	2016-05-23 13:51:10 -07:00
signaling.h
svc.c	net/atm: sk_err_soft must be positive	2016-05-23 13:51:10 -07:00