linux/drivers/staging/ks7010
Eric Biggers 877b5691f2 crypto: shash - remove shash_desc::flags
The flags field in 'struct shash_desc' never actually does anything.
The only ostensibly supported flag is CRYPTO_TFM_REQ_MAY_SLEEP.
However, no shash algorithm ever sleeps, making this flag a no-op.

With this being the case, inevitably some users who can't sleep wrongly
pass MAY_SLEEP.  These would all need to be fixed if any shash algorithm
actually started sleeping.  For example, the shash_ahash_*() functions,
which wrap a shash algorithm with the ahash API, pass through MAY_SLEEP
from the ahash API to the shash API.  However, the shash functions are
called under kmap_atomic(), so actually they're assumed to never sleep.

Even if it turns out that some users do need preemption points while
hashing large buffers, we could easily provide a helper function
crypto_shash_update_large() which divides the data into smaller chunks
and calls crypto_shash_update() and cond_resched() for each chunk.  It's
not necessary to have a flag in 'struct shash_desc', nor is it necessary
to make individual shash algorithms aware of this at all.

Therefore, remove shash_desc::flags, and document that the
crypto_shash_*() functions can be called from any context.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2019-04-25 15:38:12 +08:00
..
eap_packet.h staging: ks7010: remove not used definition WPA_CAPABILITY_PREAUTH 2018-05-14 14:07:05 +02:00
Kconfig
ks7010_sdio.c staging: ks7010: avoid casting inside cpu_to_* assignments 2018-05-20 14:47:14 +02:00
ks_hostif.c crypto: shash - remove shash_desc::flags 2019-04-25 15:38:12 +08:00
ks_hostif.h staging: ks7010: change some casts from uint8_t to u8 in ks_hostif header 2018-05-06 18:58:38 -07:00
ks_wlan_ioctl.h staging: ks7010: add SPDX identifiers to all files 2018-05-06 18:58:36 -07:00
ks_wlan_net.c Staging: ks7010: Replace typecast to int 2019-03-01 09:05:01 +01:00
ks_wlan.h staging: ks7010: Remove unused define 2018-05-15 09:31:38 +02:00
Makefile staging: ks7010: removed custom Michael MIC implementation. 2019-02-28 19:14:53 +01:00
TODO staging: ks7010: removed custom Michael MIC implementation. 2019-02-28 19:14:53 +01:00