linux/drivers/platform/surface
Maximilian Luz 2691d0ae66 platform/surface: aggregator: Fix braces in if condition with unlikely() macro
The braces of the unlikely() macro inside the if condition only cover
the subtraction part, not the whole statement. This causes the result of
the subtraction to be converted to zero or one. While that still works
in this context, it causes static analysis tools to complain (and is
just plain wrong).

Fix the bracket placement and, while at it, simplify the if-condition.
Also add a comment to the if-condition explaining what we expect the
result to be and what happens on the failure path, as it seems to have
caused a bit of confusion.

This commit should not cause any difference in behavior or generated
code.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: c167b9c7e3 ("platform/surface: Add Surface Aggregator subsystem")
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210126172202.1428367-1-luzmaximilian@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
2021-02-03 12:00:17 +01:00
..
aggregator platform/surface: aggregator: Fix braces in if condition with unlikely() macro 2021-02-03 12:00:17 +01:00
Kconfig platform/surface: Add Surface ACPI Notify driver 2021-01-07 00:06:39 +01:00
Makefile platform/surface: Add Surface ACPI Notify driver 2021-01-07 00:06:39 +01:00
surface3_button.c platform/surface: Move Surface 3 Button driver to platform/surface 2020-10-27 12:51:24 +01:00
surface3_power.c platform/surface: Move Surface 3 Power OpRegion driver to platform/surface 2020-10-27 12:51:24 +01:00
surface3-wmi.c
surface_acpi_notify.c platform/surface: fix potential integer overflow on shift of a int 2021-01-13 10:25:10 +01:00
surface_aggregator_cdev.c platform/surface: aggregator_cdev: Add comments regarding unchecked allocation size 2021-01-13 10:30:21 +01:00
surface_gpe.c platform/surface: surface_gpe: Fix non-PM_SLEEP build warnings 2021-01-04 15:54:27 +01:00
surfacepro3_button.c platform/surface: Move Surface Pro 3 Button driver to platform/surface 2020-10-27 12:51:24 +01:00