linux

mainlining shenanigans

Go to file

Mark Syms 40920c2bb1 CIFS: handle guest access errors to Windows shares Commit `1a967d6c9b` ("correctly to anonymous authentication for the NTLM(v2) authentication") introduces a regression in handling errors related to attempting a guest connection to a Windows share which requires authentication. This should result in a permission denied error but actually causes the kernel module to enter a never-ending loop trying to follow a DFS referal which doesn't exist. The base cause of this is the failure now occurs later in the process during tree connect and not at the session setup setup and all errors in tree connect are interpreted as needing to follow the DFS paths which isn't in this case correct. So, check the returned error against EACCES and fail if this is returned error. Feedback from Aurelien: PS> net user guest /activate:no PS> mkdir C:\guestshare PS> icacls C:\guestshare /grant 'Everyone:(OI)(CI)F' PS> new-smbshare -name guestshare -path C:\guestshare -fullaccess Everyone I've tested v3.10, v4.4, master, master+your patch using default options (empty or no user "NU") and user=abc (U). NT_LOGON_FAILURE in session setup: LF This is what you seem to have in 3.10. NT_ACCESS_DENIED in tree connect to the share: AD This is what you get before your infinite loop. \| NU U -------------------------------- 3.10 \| LF LF 4.4 \| LF LF master \| AD LF master+patch \| AD LF No infinite DFS loop :( All these issues result in mount failing very fast with permission denied. I guess it could be from either the Windows version or the share/folder ACL. A deeper analysis of the packets might reveal more. In any case I did not notice any issues for on a basic DFS setup with the patch so I don't think it introduced any regressions, which is probably all that matters. It still bothers me a little I couldn't hit the bug. I've included kernel output w/ debugging output and network capture of my tests if anyone want to have a look at it. (master+patch = ml-guestfix). Signed-off-by: Mark Syms <mark.syms@citrix.com> Reviewed-by: Aurelien Aptel <aaptel@suse.com> Tested-by: Aurelien Aptel <aaptel@suse.com> Acked-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <smfrench@gmail.com>		2017-04-10 23:36:38 -05:00
arch	Merge branch 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm	2017-04-09 09:05:25 -07:00
block	blk-mq: Restart a single queue if tag sets are shared	2017-04-07 12:40:09 -06:00
certs	certs: Add a secondary system keyring that can be added to dynamically	2016-04-11 22:48:09 +01:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2017-03-31 12:11:32 -07:00
Documentation	Driver core fixes for 4.11-rc6	2017-04-09 09:03:51 -07:00
drivers	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2017-04-10 09:37:43 -07:00
firmware	WHENCE: use https://linuxtv.org for LinuxTV URLs	2015-12-04 10:35:11 -02:00
fs	CIFS: handle guest access errors to Windows shares	2017-04-10 23:36:38 -05:00
include	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-04-09 08:26:21 -07:00
init	mm: move mm_percpu_wq initialization earlier	2017-03-31 17:13:30 -07:00
ipc	Merge branch 'WIP.sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-03-03 10:16:38 -08:00
kernel	sysctl: report EINVAL if value is larger than UINT_MAX for proc_douintvec	2017-04-08 10:27:40 -07:00
lib	Merge branch 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-04-02 09:18:59 -07:00
mm	mm/mempolicy.c: fix error handling in set_mempolicy and mbind.	2017-04-08 10:57:55 -07:00
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-04-05 20:17:38 -07:00
samples	statx: Include a mask for stx_attributes in struct statx	2017-04-03 01:06:00 -04:00
scripts	Kbuild fixes for v4.11	2017-04-05 08:37:28 -07:00
security	Merge branch 'WIP.sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-03-03 10:16:38 -08:00
sound	ALSA: hda - fix a problem for lineout on a Dell AIO machine	2017-03-31 10:58:26 +02:00
tools	powerpc fixes for 4.11 #7	2017-04-08 11:06:12 -07:00
usr	kbuild: initramfs cleanup, set target from Kconfig	2017-01-05 09:40:16 -08:00
virt	KVM/ARM Fixes for v4.11-rc6	2017-04-05 16:27:47 +02:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.get_maintainer.ignore
.gitattributes	.gitattributes: set git diff driver for C source code files	2016-10-07 18:46:30 -07:00
.gitignore	Merge branch 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild	2016-08-02 16:48:52 -04:00
.mailmap	mailmap: update Yakir Yang email address	2017-04-08 00:47:49 -07:00
COPYING
CREDITS	MAINTAINERS: Remove old e-mail address	2017-02-13 12:24:56 -05:00
Kbuild	scripts/gdb: provide linux constants	2016-05-23 17:04:14 -07:00
Kconfig
MAINTAINERS	Driver core fixes for 4.11-rc6	2017-04-09 09:03:51 -07:00
Makefile	Linux 4.11-rc6	2017-04-09 09:49:44 -07:00
README	README: add a new README file, pointing to the Documentation/	2016-10-24 08:12:35 -02:00

README

Linux kernel
============

This file was moved to Documentation/admin-guide/README.rst

Please notice that there are several guides for kernel developers and users.
These guides can be rendered in a number of formats, like HTML and PDF.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
See Documentation/00-INDEX for a list of what is contained in each file.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.