3f6e698604
Since commit1bb8866677
("mtd: nand: denali: handle timing parameters by setup_data_interface()"), denali_dt.c gets the clock rate from the clock driver. The driver expects the frequency of the bus interface clock, whereas the clock driver of SOCFPGA provides the core clock. Thus, the setup_data_interface() hook calculates timing parameters based on a wrong frequency. To make it work without relying on the clock driver, hard-code the clock frequency, 200MHz. This is fine for existing DT of UniPhier, and also fixes the issue of SOCFPGA because both platforms use 200 MHz for the bus interface clock. Fixes:1bb8866677
("mtd: nand: denali: handle timing parameters by setup_data_interface()") Cc: linux-stable <stable@vger.kernel.org> #4.14+ Reported-by: Philipp Rosenberger <p.rosenberger@linutronix.de> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Tested-by: Richard Weinberger <richard@nod.at> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
168 lines
4.1 KiB
C
168 lines
4.1 KiB
C
/*
|
|
* NAND Flash Controller Device Driver for DT
|
|
*
|
|
* Copyright © 2011, Picochip.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "denali.h"
|
|
|
|
struct denali_dt {
|
|
struct denali_nand_info denali;
|
|
struct clk *clk;
|
|
};
|
|
|
|
struct denali_dt_data {
|
|
unsigned int revision;
|
|
unsigned int caps;
|
|
const struct nand_ecc_caps *ecc_caps;
|
|
};
|
|
|
|
NAND_ECC_CAPS_SINGLE(denali_socfpga_ecc_caps, denali_calc_ecc_bytes,
|
|
512, 8, 15);
|
|
static const struct denali_dt_data denali_socfpga_data = {
|
|
.caps = DENALI_CAP_HW_ECC_FIXUP,
|
|
.ecc_caps = &denali_socfpga_ecc_caps,
|
|
};
|
|
|
|
NAND_ECC_CAPS_SINGLE(denali_uniphier_v5a_ecc_caps, denali_calc_ecc_bytes,
|
|
1024, 8, 16, 24);
|
|
static const struct denali_dt_data denali_uniphier_v5a_data = {
|
|
.caps = DENALI_CAP_HW_ECC_FIXUP |
|
|
DENALI_CAP_DMA_64BIT,
|
|
.ecc_caps = &denali_uniphier_v5a_ecc_caps,
|
|
};
|
|
|
|
NAND_ECC_CAPS_SINGLE(denali_uniphier_v5b_ecc_caps, denali_calc_ecc_bytes,
|
|
1024, 8, 16);
|
|
static const struct denali_dt_data denali_uniphier_v5b_data = {
|
|
.revision = 0x0501,
|
|
.caps = DENALI_CAP_HW_ECC_FIXUP |
|
|
DENALI_CAP_DMA_64BIT,
|
|
.ecc_caps = &denali_uniphier_v5b_ecc_caps,
|
|
};
|
|
|
|
static const struct of_device_id denali_nand_dt_ids[] = {
|
|
{
|
|
.compatible = "altr,socfpga-denali-nand",
|
|
.data = &denali_socfpga_data,
|
|
},
|
|
{
|
|
.compatible = "socionext,uniphier-denali-nand-v5a",
|
|
.data = &denali_uniphier_v5a_data,
|
|
},
|
|
{
|
|
.compatible = "socionext,uniphier-denali-nand-v5b",
|
|
.data = &denali_uniphier_v5b_data,
|
|
},
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, denali_nand_dt_ids);
|
|
|
|
static int denali_dt_probe(struct platform_device *pdev)
|
|
{
|
|
struct resource *res;
|
|
struct denali_dt *dt;
|
|
const struct denali_dt_data *data;
|
|
struct denali_nand_info *denali;
|
|
int ret;
|
|
|
|
dt = devm_kzalloc(&pdev->dev, sizeof(*dt), GFP_KERNEL);
|
|
if (!dt)
|
|
return -ENOMEM;
|
|
denali = &dt->denali;
|
|
|
|
data = of_device_get_match_data(&pdev->dev);
|
|
if (data) {
|
|
denali->revision = data->revision;
|
|
denali->caps = data->caps;
|
|
denali->ecc_caps = data->ecc_caps;
|
|
}
|
|
|
|
denali->dev = &pdev->dev;
|
|
denali->irq = platform_get_irq(pdev, 0);
|
|
if (denali->irq < 0) {
|
|
dev_err(&pdev->dev, "no irq defined\n");
|
|
return denali->irq;
|
|
}
|
|
|
|
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "denali_reg");
|
|
denali->reg = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(denali->reg))
|
|
return PTR_ERR(denali->reg);
|
|
|
|
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "nand_data");
|
|
denali->host = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(denali->host))
|
|
return PTR_ERR(denali->host);
|
|
|
|
dt->clk = devm_clk_get(&pdev->dev, NULL);
|
|
if (IS_ERR(dt->clk)) {
|
|
dev_err(&pdev->dev, "no clk available\n");
|
|
return PTR_ERR(dt->clk);
|
|
}
|
|
ret = clk_prepare_enable(dt->clk);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/*
|
|
* Hardcode the clock rate for the backward compatibility.
|
|
* This works for both SOCFPGA and UniPhier.
|
|
*/
|
|
denali->clk_x_rate = 200000000;
|
|
|
|
ret = denali_init(denali);
|
|
if (ret)
|
|
goto out_disable_clk;
|
|
|
|
platform_set_drvdata(pdev, dt);
|
|
return 0;
|
|
|
|
out_disable_clk:
|
|
clk_disable_unprepare(dt->clk);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int denali_dt_remove(struct platform_device *pdev)
|
|
{
|
|
struct denali_dt *dt = platform_get_drvdata(pdev);
|
|
|
|
denali_remove(&dt->denali);
|
|
clk_disable_unprepare(dt->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver denali_dt_driver = {
|
|
.probe = denali_dt_probe,
|
|
.remove = denali_dt_remove,
|
|
.driver = {
|
|
.name = "denali-nand-dt",
|
|
.of_match_table = denali_nand_dt_ids,
|
|
},
|
|
};
|
|
module_platform_driver(denali_dt_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Jamie Iles");
|
|
MODULE_DESCRIPTION("DT driver for Denali NAND controller");
|