forked from Minki/linux
3f61cd879c
We allocate memory for 'new_data' with kmalloc(). If we get the memory
we then try to build_skb() and if that should fail (which it can) we
do not enter 'if (likely(skb)) {' and actually use 'new_data' but
instead fall through to the 'drop:' label and end up returning from
the function without ever assigning 'new'data' to anything or freeing
it. That leaks the memory allocated to 'new_data'.
This patch fixes the memory leak by doing a kfree(new_data) in the
case where build_skb() fails (or where allocation of 'new_data' itself
fails, but in taht case it's just a harmless kfree(NULL)).
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|---|---|---|
| .. | ||
| bnx2x_cmn.c | ||
| bnx2x_cmn.h | ||
| bnx2x_dcb.c | ||
| bnx2x_dcb.h | ||
| bnx2x_dump.h | ||
| bnx2x_ethtool.c | ||
| bnx2x_fw_defs.h | ||
| bnx2x_fw_file_hdr.h | ||
| bnx2x_hsi.h | ||
| bnx2x_init_ops.h | ||
| bnx2x_init.h | ||
| bnx2x_link.c | ||
| bnx2x_link.h | ||
| bnx2x_main.c | ||
| bnx2x_reg.h | ||
| bnx2x_sp.c | ||
| bnx2x_sp.h | ||
| bnx2x_stats.c | ||
| bnx2x_stats.h | ||
| bnx2x.h | ||
| Makefile | ||