Files
linux/drivers/gpu/drm
Chris Wilson 3dd66a94de drm/i915/gt: Always send a pulse down the engine after disabling heartbeat
Currently, we check we can send a pulse prior to disabling the
heartbeat to verify that we can change the heartbeat, but since we may
re-evaluate execution upon changing the heartbeat interval we need another
pulse afterwards to refresh execution.

v2: Tvrtko asked if we could reduce the double pulse to a single, which
opened up a discussion of how we should handle the pulse-error after
attempting to change the property, and the desire to serialise
adjustment of the property with its validating pulse, and unwind upon
failure.

Fixes: 9a40bddd47 ("drm/i915/gt: Expose heartbeat interval via sysfs")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: <stable@vger.kernel.org> # v5.7+
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200928221510.26044-2-chris@chris-wilson.co.uk
2020-09-29 09:03:17 +01:00
..
2020-07-24 08:48:05 +10:00
2020-08-11 11:58:31 +10:00
2020-08-18 14:14:25 +02:00
2020-08-19 15:49:10 +02:00
2020-08-12 20:42:08 +02:00
2020-08-11 11:58:31 +10:00
2020-07-24 08:48:05 +10:00
2020-08-18 14:14:25 +02:00
2020-07-28 17:21:58 +02:00
2020-07-23 10:06:22 +02:00
2020-04-03 17:11:41 +02:00
2020-08-18 14:14:25 +02:00
2020-08-18 10:49:13 +02:00
2020-06-24 09:17:34 +02:00
2020-05-27 14:31:42 +03:00
2020-04-03 17:11:41 +02:00
2020-07-27 22:06:13 +02:00
2020-08-11 11:58:31 +10:00
2020-07-16 18:16:31 -04:00
2020-05-29 12:58:11 +02:00
2020-08-11 11:58:31 +10:00
2020-08-11 11:58:31 +10:00