dc86d6bc9b
When creating a frame buffer, the driver verifies that the pitches for the chroma planes match the luma plane. This is done incorrectly for fully planar YUV formats, without taking horizontal subsampling into account. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
915 lines
21 KiB
C
915 lines
21 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* rcar_du_kms.c -- R-Car Display Unit Mode Setting
|
|
*
|
|
* Copyright (C) 2013-2015 Renesas Electronics Corporation
|
|
*
|
|
* Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
|
|
*/
|
|
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_crtc.h>
|
|
#include <drm/drm_device.h>
|
|
#include <drm/drm_fb_cma_helper.h>
|
|
#include <drm/drm_gem_cma_helper.h>
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include <drm/drm_vblank.h>
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/of_graph.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/wait.h>
|
|
|
|
#include "rcar_du_crtc.h"
|
|
#include "rcar_du_drv.h"
|
|
#include "rcar_du_encoder.h"
|
|
#include "rcar_du_kms.h"
|
|
#include "rcar_du_regs.h"
|
|
#include "rcar_du_vsp.h"
|
|
#include "rcar_du_writeback.h"
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
* Format helpers
|
|
*/
|
|
|
|
static const struct rcar_du_format_info rcar_du_format_infos[] = {
|
|
{
|
|
.fourcc = DRM_FORMAT_RGB565,
|
|
.v4l2 = V4L2_PIX_FMT_RGB565,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
.pnmr = PnMR_SPIM_TP | PnMR_DDDF_16BPP,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_ARGB1555,
|
|
.v4l2 = V4L2_PIX_FMT_ARGB555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
.pnmr = PnMR_SPIM_ALP | PnMR_DDDF_ARGB,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_XRGB1555,
|
|
.v4l2 = V4L2_PIX_FMT_XRGB555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.pnmr = PnMR_SPIM_ALP | PnMR_DDDF_ARGB,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_XRGB8888,
|
|
.v4l2 = V4L2_PIX_FMT_XBGR32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
.pnmr = PnMR_SPIM_TP | PnMR_DDDF_16BPP,
|
|
.edf = PnDDCR4_EDF_RGB888,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_ARGB8888,
|
|
.v4l2 = V4L2_PIX_FMT_ABGR32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
.pnmr = PnMR_SPIM_ALP | PnMR_DDDF_16BPP,
|
|
.edf = PnDDCR4_EDF_ARGB8888,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_UYVY,
|
|
.v4l2 = V4L2_PIX_FMT_UYVY,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 2,
|
|
.pnmr = PnMR_SPIM_TP_OFF | PnMR_DDDF_YC,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YUYV,
|
|
.v4l2 = V4L2_PIX_FMT_YUYV,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 2,
|
|
.pnmr = PnMR_SPIM_TP_OFF | PnMR_DDDF_YC,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV12,
|
|
.v4l2 = V4L2_PIX_FMT_NV12M,
|
|
.bpp = 12,
|
|
.planes = 2,
|
|
.hsub = 2,
|
|
.pnmr = PnMR_SPIM_TP_OFF | PnMR_DDDF_YC,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV21,
|
|
.v4l2 = V4L2_PIX_FMT_NV21M,
|
|
.bpp = 12,
|
|
.planes = 2,
|
|
.hsub = 2,
|
|
.pnmr = PnMR_SPIM_TP_OFF | PnMR_DDDF_YC,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV16,
|
|
.v4l2 = V4L2_PIX_FMT_NV16M,
|
|
.bpp = 16,
|
|
.planes = 2,
|
|
.hsub = 2,
|
|
.pnmr = PnMR_SPIM_TP_OFF | PnMR_DDDF_YC,
|
|
.edf = PnDDCR4_EDF_NONE,
|
|
},
|
|
/*
|
|
* The following formats are not supported on Gen2 and thus have no
|
|
* associated .pnmr or .edf settings.
|
|
*/
|
|
{
|
|
.fourcc = DRM_FORMAT_RGB332,
|
|
.v4l2 = V4L2_PIX_FMT_RGB332,
|
|
.bpp = 8,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_ARGB4444,
|
|
.v4l2 = V4L2_PIX_FMT_ARGB444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_XRGB4444,
|
|
.v4l2 = V4L2_PIX_FMT_XRGB444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGBA4444,
|
|
.v4l2 = V4L2_PIX_FMT_RGBA444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGBX4444,
|
|
.v4l2 = V4L2_PIX_FMT_RGBX444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_ABGR4444,
|
|
.v4l2 = V4L2_PIX_FMT_ABGR444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_XBGR4444,
|
|
.v4l2 = V4L2_PIX_FMT_XBGR444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_BGRA4444,
|
|
.v4l2 = V4L2_PIX_FMT_BGRA444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_BGRX4444,
|
|
.v4l2 = V4L2_PIX_FMT_BGRX444,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGBA5551,
|
|
.v4l2 = V4L2_PIX_FMT_RGBA555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGBX5551,
|
|
.v4l2 = V4L2_PIX_FMT_RGBX555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_ABGR1555,
|
|
.v4l2 = V4L2_PIX_FMT_ABGR555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_XBGR1555,
|
|
.v4l2 = V4L2_PIX_FMT_XBGR555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_BGRA5551,
|
|
.v4l2 = V4L2_PIX_FMT_BGRA555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_BGRX5551,
|
|
.v4l2 = V4L2_PIX_FMT_BGRX555,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_BGR888,
|
|
.v4l2 = V4L2_PIX_FMT_RGB24,
|
|
.bpp = 24,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGB888,
|
|
.v4l2 = V4L2_PIX_FMT_BGR24,
|
|
.bpp = 24,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGBA8888,
|
|
.v4l2 = V4L2_PIX_FMT_BGRA32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_RGBX8888,
|
|
.v4l2 = V4L2_PIX_FMT_BGRX32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_ABGR8888,
|
|
.v4l2 = V4L2_PIX_FMT_RGBA32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_XBGR8888,
|
|
.v4l2 = V4L2_PIX_FMT_RGBX32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_BGRA8888,
|
|
.v4l2 = V4L2_PIX_FMT_ARGB32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_BGRX8888,
|
|
.v4l2 = V4L2_PIX_FMT_XRGB32,
|
|
.bpp = 32,
|
|
.planes = 1,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YVYU,
|
|
.v4l2 = V4L2_PIX_FMT_YVYU,
|
|
.bpp = 16,
|
|
.planes = 1,
|
|
.hsub = 2,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_NV61,
|
|
.v4l2 = V4L2_PIX_FMT_NV61M,
|
|
.bpp = 16,
|
|
.planes = 2,
|
|
.hsub = 2,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YUV420,
|
|
.v4l2 = V4L2_PIX_FMT_YUV420M,
|
|
.bpp = 12,
|
|
.planes = 3,
|
|
.hsub = 2,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YVU420,
|
|
.v4l2 = V4L2_PIX_FMT_YVU420M,
|
|
.bpp = 12,
|
|
.planes = 3,
|
|
.hsub = 2,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YUV422,
|
|
.v4l2 = V4L2_PIX_FMT_YUV422M,
|
|
.bpp = 16,
|
|
.planes = 3,
|
|
.hsub = 2,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YVU422,
|
|
.v4l2 = V4L2_PIX_FMT_YVU422M,
|
|
.bpp = 16,
|
|
.planes = 3,
|
|
.hsub = 2,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YUV444,
|
|
.v4l2 = V4L2_PIX_FMT_YUV444M,
|
|
.bpp = 24,
|
|
.planes = 3,
|
|
.hsub = 1,
|
|
}, {
|
|
.fourcc = DRM_FORMAT_YVU444,
|
|
.v4l2 = V4L2_PIX_FMT_YVU444M,
|
|
.bpp = 24,
|
|
.planes = 3,
|
|
.hsub = 1,
|
|
},
|
|
};
|
|
|
|
const struct rcar_du_format_info *rcar_du_format_info(u32 fourcc)
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(rcar_du_format_infos); ++i) {
|
|
if (rcar_du_format_infos[i].fourcc == fourcc)
|
|
return &rcar_du_format_infos[i];
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
* Frame buffer
|
|
*/
|
|
|
|
int rcar_du_dumb_create(struct drm_file *file, struct drm_device *dev,
|
|
struct drm_mode_create_dumb *args)
|
|
{
|
|
struct rcar_du_device *rcdu = dev->dev_private;
|
|
unsigned int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8);
|
|
unsigned int align;
|
|
|
|
/*
|
|
* The R8A7779 DU requires a 16 pixels pitch alignment as documented,
|
|
* but the R8A7790 DU seems to require a 128 bytes pitch alignment.
|
|
*/
|
|
if (rcar_du_needs(rcdu, RCAR_DU_QUIRK_ALIGN_128B))
|
|
align = 128;
|
|
else
|
|
align = 16 * args->bpp / 8;
|
|
|
|
args->pitch = roundup(min_pitch, align);
|
|
|
|
return drm_gem_cma_dumb_create_internal(file, dev, args);
|
|
}
|
|
|
|
static struct drm_framebuffer *
|
|
rcar_du_fb_create(struct drm_device *dev, struct drm_file *file_priv,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
struct rcar_du_device *rcdu = dev->dev_private;
|
|
const struct rcar_du_format_info *format;
|
|
unsigned int chroma_pitch;
|
|
unsigned int max_pitch;
|
|
unsigned int align;
|
|
unsigned int i;
|
|
|
|
format = rcar_du_format_info(mode_cmd->pixel_format);
|
|
if (format == NULL) {
|
|
dev_dbg(dev->dev, "unsupported pixel format %08x\n",
|
|
mode_cmd->pixel_format);
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
if (rcdu->info->gen < 3) {
|
|
/*
|
|
* On Gen2 the DU limits the pitch to 4095 pixels and requires
|
|
* buffers to be aligned to a 16 pixels boundary (or 128 bytes
|
|
* on some platforms).
|
|
*/
|
|
unsigned int bpp = format->planes == 1 ? format->bpp / 8 : 1;
|
|
|
|
max_pitch = 4095 * bpp;
|
|
|
|
if (rcar_du_needs(rcdu, RCAR_DU_QUIRK_ALIGN_128B))
|
|
align = 128;
|
|
else
|
|
align = 16 * bpp;
|
|
} else {
|
|
/*
|
|
* On Gen3 the memory interface is handled by the VSP that
|
|
* limits the pitch to 65535 bytes and has no alignment
|
|
* constraint.
|
|
*/
|
|
max_pitch = 65535;
|
|
align = 1;
|
|
}
|
|
|
|
if (mode_cmd->pitches[0] & (align - 1) ||
|
|
mode_cmd->pitches[0] > max_pitch) {
|
|
dev_dbg(dev->dev, "invalid pitch value %u\n",
|
|
mode_cmd->pitches[0]);
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
/*
|
|
* Calculate the chroma plane(s) pitch using the horizontal subsampling
|
|
* factor. For semi-planar formats, the U and V planes are combined, the
|
|
* pitch must thus be doubled.
|
|
*/
|
|
chroma_pitch = mode_cmd->pitches[0] / format->hsub;
|
|
if (format->planes == 2)
|
|
chroma_pitch *= 2;
|
|
|
|
for (i = 1; i < format->planes; ++i) {
|
|
if (mode_cmd->pitches[i] != chroma_pitch) {
|
|
dev_dbg(dev->dev,
|
|
"luma and chroma pitches are not compatible\n");
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
}
|
|
|
|
return drm_gem_fb_create(dev, file_priv, mode_cmd);
|
|
}
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
* Atomic Check and Update
|
|
*/
|
|
|
|
static int rcar_du_atomic_check(struct drm_device *dev,
|
|
struct drm_atomic_state *state)
|
|
{
|
|
struct rcar_du_device *rcdu = dev->dev_private;
|
|
int ret;
|
|
|
|
ret = drm_atomic_helper_check(dev, state);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE))
|
|
return 0;
|
|
|
|
return rcar_du_atomic_check_planes(dev, state);
|
|
}
|
|
|
|
static void rcar_du_atomic_commit_tail(struct drm_atomic_state *old_state)
|
|
{
|
|
struct drm_device *dev = old_state->dev;
|
|
struct rcar_du_device *rcdu = dev->dev_private;
|
|
struct drm_crtc_state *crtc_state;
|
|
struct drm_crtc *crtc;
|
|
unsigned int i;
|
|
|
|
/*
|
|
* Store RGB routing to DPAD0 and DPAD1, the hardware will be configured
|
|
* when starting the CRTCs.
|
|
*/
|
|
rcdu->dpad1_source = -1;
|
|
|
|
for_each_new_crtc_in_state(old_state, crtc, crtc_state, i) {
|
|
struct rcar_du_crtc_state *rcrtc_state =
|
|
to_rcar_crtc_state(crtc_state);
|
|
struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
|
|
|
|
if (rcrtc_state->outputs & BIT(RCAR_DU_OUTPUT_DPAD0))
|
|
rcdu->dpad0_source = rcrtc->index;
|
|
|
|
if (rcrtc_state->outputs & BIT(RCAR_DU_OUTPUT_DPAD1))
|
|
rcdu->dpad1_source = rcrtc->index;
|
|
}
|
|
|
|
/* Apply the atomic update. */
|
|
drm_atomic_helper_commit_modeset_disables(dev, old_state);
|
|
drm_atomic_helper_commit_planes(dev, old_state,
|
|
DRM_PLANE_COMMIT_ACTIVE_ONLY);
|
|
drm_atomic_helper_commit_modeset_enables(dev, old_state);
|
|
|
|
drm_atomic_helper_commit_hw_done(old_state);
|
|
drm_atomic_helper_wait_for_flip_done(dev, old_state);
|
|
|
|
drm_atomic_helper_cleanup_planes(dev, old_state);
|
|
}
|
|
|
|
/* -----------------------------------------------------------------------------
|
|
* Initialization
|
|
*/
|
|
|
|
static const struct drm_mode_config_helper_funcs rcar_du_mode_config_helper = {
|
|
.atomic_commit_tail = rcar_du_atomic_commit_tail,
|
|
};
|
|
|
|
static const struct drm_mode_config_funcs rcar_du_mode_config_funcs = {
|
|
.fb_create = rcar_du_fb_create,
|
|
.atomic_check = rcar_du_atomic_check,
|
|
.atomic_commit = drm_atomic_helper_commit,
|
|
};
|
|
|
|
static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
|
|
enum rcar_du_output output,
|
|
struct of_endpoint *ep)
|
|
{
|
|
struct device_node *entity;
|
|
int ret;
|
|
|
|
/* Locate the connected entity and initialize the encoder. */
|
|
entity = of_graph_get_remote_port_parent(ep->local_node);
|
|
if (!entity) {
|
|
dev_dbg(rcdu->dev, "unconnected endpoint %pOF, skipping\n",
|
|
ep->local_node);
|
|
return -ENODEV;
|
|
}
|
|
|
|
if (!of_device_is_available(entity)) {
|
|
dev_dbg(rcdu->dev,
|
|
"connected entity %pOF is disabled, skipping\n",
|
|
entity);
|
|
of_node_put(entity);
|
|
return -ENODEV;
|
|
}
|
|
|
|
ret = rcar_du_encoder_init(rcdu, output, entity);
|
|
if (ret && ret != -EPROBE_DEFER && ret != -ENOLINK)
|
|
dev_warn(rcdu->dev,
|
|
"failed to initialize encoder %pOF on output %u (%d), skipping\n",
|
|
entity, output, ret);
|
|
|
|
of_node_put(entity);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
|
|
{
|
|
struct device_node *np = rcdu->dev->of_node;
|
|
struct device_node *ep_node;
|
|
unsigned int num_encoders = 0;
|
|
|
|
/*
|
|
* Iterate over the endpoints and create one encoder for each output
|
|
* pipeline.
|
|
*/
|
|
for_each_endpoint_of_node(np, ep_node) {
|
|
enum rcar_du_output output;
|
|
struct of_endpoint ep;
|
|
unsigned int i;
|
|
int ret;
|
|
|
|
ret = of_graph_parse_endpoint(ep_node, &ep);
|
|
if (ret < 0) {
|
|
of_node_put(ep_node);
|
|
return ret;
|
|
}
|
|
|
|
/* Find the output route corresponding to the port number. */
|
|
for (i = 0; i < RCAR_DU_OUTPUT_MAX; ++i) {
|
|
if (rcdu->info->routes[i].possible_crtcs &&
|
|
rcdu->info->routes[i].port == ep.port) {
|
|
output = i;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (i == RCAR_DU_OUTPUT_MAX) {
|
|
dev_warn(rcdu->dev,
|
|
"port %u references unexisting output, skipping\n",
|
|
ep.port);
|
|
continue;
|
|
}
|
|
|
|
/* Process the output pipeline. */
|
|
ret = rcar_du_encoders_init_one(rcdu, output, &ep);
|
|
if (ret < 0) {
|
|
if (ret == -EPROBE_DEFER) {
|
|
of_node_put(ep_node);
|
|
return ret;
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
num_encoders++;
|
|
}
|
|
|
|
return num_encoders;
|
|
}
|
|
|
|
static int rcar_du_properties_init(struct rcar_du_device *rcdu)
|
|
{
|
|
/*
|
|
* The color key is expressed as an RGB888 triplet stored in a 32-bit
|
|
* integer in XRGB8888 format. Bit 24 is used as a flag to disable (0)
|
|
* or enable source color keying (1).
|
|
*/
|
|
rcdu->props.colorkey =
|
|
drm_property_create_range(rcdu->ddev, 0, "colorkey",
|
|
0, 0x01ffffff);
|
|
if (rcdu->props.colorkey == NULL)
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
|
|
{
|
|
const struct device_node *np = rcdu->dev->of_node;
|
|
const char *vsps_prop_name = "renesas,vsps";
|
|
struct of_phandle_args args;
|
|
struct {
|
|
struct device_node *np;
|
|
unsigned int crtcs_mask;
|
|
} vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
|
|
unsigned int vsps_count = 0;
|
|
unsigned int cells;
|
|
unsigned int i;
|
|
int ret;
|
|
|
|
/*
|
|
* First parse the DT vsps property to populate the list of VSPs. Each
|
|
* entry contains a pointer to the VSP DT node and a bitmask of the
|
|
* connected DU CRTCs.
|
|
*/
|
|
ret = of_property_count_u32_elems(np, vsps_prop_name);
|
|
if (ret < 0) {
|
|
/* Backward compatibility with old DTBs. */
|
|
vsps_prop_name = "vsps";
|
|
ret = of_property_count_u32_elems(np, vsps_prop_name);
|
|
}
|
|
cells = ret / rcdu->num_crtcs - 1;
|
|
if (cells > 1)
|
|
return -EINVAL;
|
|
|
|
for (i = 0; i < rcdu->num_crtcs; ++i) {
|
|
unsigned int j;
|
|
|
|
ret = of_parse_phandle_with_fixed_args(np, vsps_prop_name,
|
|
cells, i, &args);
|
|
if (ret < 0)
|
|
goto error;
|
|
|
|
/*
|
|
* Add the VSP to the list or update the corresponding existing
|
|
* entry if the VSP has already been added.
|
|
*/
|
|
for (j = 0; j < vsps_count; ++j) {
|
|
if (vsps[j].np == args.np)
|
|
break;
|
|
}
|
|
|
|
if (j < vsps_count)
|
|
of_node_put(args.np);
|
|
else
|
|
vsps[vsps_count++].np = args.np;
|
|
|
|
vsps[j].crtcs_mask |= BIT(i);
|
|
|
|
/*
|
|
* Store the VSP pointer and pipe index in the CRTC. If the
|
|
* second cell of the 'renesas,vsps' specifier isn't present,
|
|
* default to 0 to remain compatible with older DT bindings.
|
|
*/
|
|
rcdu->crtcs[i].vsp = &rcdu->vsps[j];
|
|
rcdu->crtcs[i].vsp_pipe = cells >= 1 ? args.args[0] : 0;
|
|
}
|
|
|
|
/*
|
|
* Then initialize all the VSPs from the node pointers and CRTCs bitmask
|
|
* computed previously.
|
|
*/
|
|
for (i = 0; i < vsps_count; ++i) {
|
|
struct rcar_du_vsp *vsp = &rcdu->vsps[i];
|
|
|
|
vsp->index = i;
|
|
vsp->dev = rcdu;
|
|
|
|
ret = rcar_du_vsp_init(vsp, vsps[i].np, vsps[i].crtcs_mask);
|
|
if (ret < 0)
|
|
goto error;
|
|
}
|
|
|
|
return 0;
|
|
|
|
error:
|
|
for (i = 0; i < ARRAY_SIZE(vsps); ++i)
|
|
of_node_put(vsps[i].np);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int rcar_du_cmm_init(struct rcar_du_device *rcdu)
|
|
{
|
|
const struct device_node *np = rcdu->dev->of_node;
|
|
unsigned int i;
|
|
int cells;
|
|
|
|
cells = of_property_count_u32_elems(np, "renesas,cmms");
|
|
if (cells == -EINVAL)
|
|
return 0;
|
|
|
|
if (cells > rcdu->num_crtcs) {
|
|
dev_err(rcdu->dev,
|
|
"Invalid number of entries in 'renesas,cmms'\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
for (i = 0; i < cells; ++i) {
|
|
struct platform_device *pdev;
|
|
struct device_link *link;
|
|
struct device_node *cmm;
|
|
int ret;
|
|
|
|
cmm = of_parse_phandle(np, "renesas,cmms", i);
|
|
if (IS_ERR(cmm)) {
|
|
dev_err(rcdu->dev,
|
|
"Failed to parse 'renesas,cmms' property\n");
|
|
return PTR_ERR(cmm);
|
|
}
|
|
|
|
if (!of_device_is_available(cmm)) {
|
|
/* It's fine to have a phandle to a non-enabled CMM. */
|
|
of_node_put(cmm);
|
|
continue;
|
|
}
|
|
|
|
pdev = of_find_device_by_node(cmm);
|
|
if (IS_ERR(pdev)) {
|
|
dev_err(rcdu->dev, "No device found for CMM%u\n", i);
|
|
of_node_put(cmm);
|
|
return PTR_ERR(pdev);
|
|
}
|
|
|
|
of_node_put(cmm);
|
|
|
|
/*
|
|
* -ENODEV is used to report that the CMM config option is
|
|
* disabled: return 0 and let the DU continue probing.
|
|
*/
|
|
ret = rcar_cmm_init(pdev);
|
|
if (ret)
|
|
return ret == -ENODEV ? 0 : ret;
|
|
|
|
/*
|
|
* Enforce suspend/resume ordering by making the CMM a provider
|
|
* of the DU: CMM is suspended after and resumed before the DU.
|
|
*/
|
|
link = device_link_add(rcdu->dev, &pdev->dev, DL_FLAG_STATELESS);
|
|
if (!link) {
|
|
dev_err(rcdu->dev,
|
|
"Failed to create device link to CMM%u\n", i);
|
|
return -EINVAL;
|
|
}
|
|
|
|
rcdu->cmms[i] = pdev;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int rcar_du_modeset_init(struct rcar_du_device *rcdu)
|
|
{
|
|
static const unsigned int mmio_offsets[] = {
|
|
DU0_REG_OFFSET, DU2_REG_OFFSET
|
|
};
|
|
|
|
struct drm_device *dev = rcdu->ddev;
|
|
struct drm_encoder *encoder;
|
|
unsigned int dpad0_sources;
|
|
unsigned int num_encoders;
|
|
unsigned int num_groups;
|
|
unsigned int swindex;
|
|
unsigned int hwindex;
|
|
unsigned int i;
|
|
int ret;
|
|
|
|
ret = drmm_mode_config_init(dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
dev->mode_config.min_width = 0;
|
|
dev->mode_config.min_height = 0;
|
|
dev->mode_config.normalize_zpos = true;
|
|
dev->mode_config.funcs = &rcar_du_mode_config_funcs;
|
|
dev->mode_config.helper_private = &rcar_du_mode_config_helper;
|
|
|
|
if (rcdu->info->gen < 3) {
|
|
dev->mode_config.max_width = 4095;
|
|
dev->mode_config.max_height = 2047;
|
|
} else {
|
|
/*
|
|
* The Gen3 DU uses the VSP1 for memory access, and is limited
|
|
* to frame sizes of 8190x8190.
|
|
*/
|
|
dev->mode_config.max_width = 8190;
|
|
dev->mode_config.max_height = 8190;
|
|
}
|
|
|
|
rcdu->num_crtcs = hweight8(rcdu->info->channels_mask);
|
|
|
|
ret = rcar_du_properties_init(rcdu);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
/*
|
|
* Initialize vertical blanking interrupts handling. Start with vblank
|
|
* disabled for all CRTCs.
|
|
*/
|
|
ret = drm_vblank_init(dev, rcdu->num_crtcs);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
/* Initialize the groups. */
|
|
num_groups = DIV_ROUND_UP(rcdu->num_crtcs, 2);
|
|
|
|
for (i = 0; i < num_groups; ++i) {
|
|
struct rcar_du_group *rgrp = &rcdu->groups[i];
|
|
|
|
mutex_init(&rgrp->lock);
|
|
|
|
rgrp->dev = rcdu;
|
|
rgrp->mmio_offset = mmio_offsets[i];
|
|
rgrp->index = i;
|
|
/* Extract the channel mask for this group only. */
|
|
rgrp->channels_mask = (rcdu->info->channels_mask >> (2 * i))
|
|
& GENMASK(1, 0);
|
|
rgrp->num_crtcs = hweight8(rgrp->channels_mask);
|
|
|
|
/*
|
|
* If we have more than one CRTCs in this group pre-associate
|
|
* the low-order planes with CRTC 0 and the high-order planes
|
|
* with CRTC 1 to minimize flicker occurring when the
|
|
* association is changed.
|
|
*/
|
|
rgrp->dptsr_planes = rgrp->num_crtcs > 1
|
|
? (rcdu->info->gen >= 3 ? 0x04 : 0xf0)
|
|
: 0;
|
|
|
|
if (!rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE)) {
|
|
ret = rcar_du_planes_init(rgrp);
|
|
if (ret < 0)
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
/* Initialize the compositors. */
|
|
if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE)) {
|
|
ret = rcar_du_vsps_init(rcdu);
|
|
if (ret < 0)
|
|
return ret;
|
|
}
|
|
|
|
/* Initialize the Color Management Modules. */
|
|
ret = rcar_du_cmm_init(rcdu);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Create the CRTCs. */
|
|
for (swindex = 0, hwindex = 0; swindex < rcdu->num_crtcs; ++hwindex) {
|
|
struct rcar_du_group *rgrp;
|
|
|
|
/* Skip unpopulated DU channels. */
|
|
if (!(rcdu->info->channels_mask & BIT(hwindex)))
|
|
continue;
|
|
|
|
rgrp = &rcdu->groups[hwindex / 2];
|
|
|
|
ret = rcar_du_crtc_create(rgrp, swindex++, hwindex);
|
|
if (ret < 0)
|
|
return ret;
|
|
}
|
|
|
|
/* Initialize the encoders. */
|
|
ret = rcar_du_encoders_init(rcdu);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
if (ret == 0) {
|
|
dev_err(rcdu->dev, "error: no encoder could be initialized\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
num_encoders = ret;
|
|
|
|
/*
|
|
* Set the possible CRTCs and possible clones. There's always at least
|
|
* one way for all encoders to clone each other, set all bits in the
|
|
* possible clones field.
|
|
*/
|
|
list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
|
|
struct rcar_du_encoder *renc = to_rcar_encoder(encoder);
|
|
const struct rcar_du_output_routing *route =
|
|
&rcdu->info->routes[renc->output];
|
|
|
|
encoder->possible_crtcs = route->possible_crtcs;
|
|
encoder->possible_clones = (1 << num_encoders) - 1;
|
|
}
|
|
|
|
/* Create the writeback connectors. */
|
|
if (rcdu->info->gen >= 3) {
|
|
for (i = 0; i < rcdu->num_crtcs; ++i) {
|
|
struct rcar_du_crtc *rcrtc = &rcdu->crtcs[i];
|
|
|
|
ret = rcar_du_writeback_init(rcdu, rcrtc);
|
|
if (ret < 0)
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Initialize the default DPAD0 source to the index of the first DU
|
|
* channel that can be connected to DPAD0. The exact value doesn't
|
|
* matter as it should be overwritten by mode setting for the RGB
|
|
* output, but it is nonetheless required to ensure a valid initial
|
|
* hardware configuration on Gen3 where DU0 can't always be connected to
|
|
* DPAD0.
|
|
*/
|
|
dpad0_sources = rcdu->info->routes[RCAR_DU_OUTPUT_DPAD0].possible_crtcs;
|
|
rcdu->dpad0_source = ffs(dpad0_sources) - 1;
|
|
|
|
drm_mode_config_reset(dev);
|
|
|
|
drm_kms_helper_poll_init(dev);
|
|
|
|
return 0;
|
|
}
|