forked from Minki/linux
3777ea7bac
Letting xenbus_grant_ring() tear down grants in the error case is problematic, as the other side could already have used these grants. Calling gnttab_end_foreign_access_ref() without checking success is resulting in an unclear situation for any caller of xenbus_grant_ring() as in the error case the memory pages of the ring page might be partially mapped. Freeing them would risk unwanted foreign access to them, while not freeing them would leak memory. In order to remove the need to undo any gnttab_grant_foreign_access() calls, use gnttab_alloc_grant_references() to make sure no further error can occur in the loop granting access to the ring pages. It should be noted that this way of handling removes leaking of grant entries in the error case, too. This is CVE-2022-23040 / part of XSA-396. Reported-by: Demi Marie Obenour <demi@invisiblethingslab.com> Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Jan Beulich <jbeulich@suse.com> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| xenbus_client.c | ||
| xenbus_comms.c | ||
| xenbus_dev_backend.c | ||
| xenbus_dev_frontend.c | ||
| xenbus_probe_backend.c | ||
| xenbus_probe_frontend.c | ||
| xenbus_probe.c | ||
| xenbus_xs.c | ||
| xenbus.h | ||