Vlad Buslov 3929502b95 net/mlx5e: Provide cb_list pointer when setting up tc block on rep ... Recent refactoring of tc block offloads infrastructure introduced new flow_block_cb_setup_simple() method intended to be used as unified way for all drivers to register offload callbacks. However, commit that actually extended all users (drivers) with block cb list and provided it to flow_block infra missed mlx5 en_rep. This leads to following NULL-pointer dereference when creating Qdisc: [ 278.385175] BUG: kernel NULL pointer dereference, address: 0000000000000000 [ 278.393233] #PF: supervisor read access in kernel mode [ 278.399446] #PF: error_code(0x0000) - not-present page [ 278.405847] PGD 8000000850e73067 P4D 8000000850e73067 PUD 8620cd067 PMD 0 [ 278.414141] Oops: 0000 [#1] SMP PTI [ 278.419019] CPU: 7 PID: 3369 Comm: tc Not tainted 5.2.0-rc6+ #492 [ 278.426580] Hardware name: Supermicro SYS-2028TP-DECR/X10DRT-P, BIOS 2.0b 03/30/2017 [ 278.435853] RIP: 0010:flow_block_cb_setup_simple+0xc4/0x190 [ 278.442953] Code: 10 48 89 42 08 48 89 10 48 b8 00 01 00 00 00 00 ad de 49 89 00 48 05 00 01 00 00 49 89 40 08 31 c0 c3 b8 a1 ff ff ff c3 f3 c3 <48> 8b 06 48 39 c6 75 0a eb 1a 48 8b 00 48 39 c6 74 12 48 3b 50 28 [ 278.464829] RSP: 0018:ffffaf07c3f97990 EFLAGS: 00010246 [ 278.471648] RAX: 0000000000000000 RBX: ffff9b43ed4c7680 RCX: ffff9b43d5f80840 [ 278.480408] RDX: ffffffffc0491650 RSI: 0000000000000000 RDI: ffffaf07c3f97998 [ 278.489110] RBP: ffff9b43ddff9000 R08: ffff9b43d5f80840 R09: 0000000000000001 [ 278.497838] R10: 0000000000000009 R11: 00000000000003ad R12: ffffaf07c3f97c08 [ 278.506595] R13: ffff9b43d5f80000 R14: ffff9b43ed4c7680 R15: ffff9b43dfa20b40 [ 278.515374] FS: 00007f796be1b400(0000) GS:ffff9b43ef840000(0000) knlGS:0000000000000000 [ 278.525099] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 278.532453] CR2: 0000000000000000 CR3: 0000000840398002 CR4: 00000000001606e0 [ 278.541197] Call Trace: [ 278.545252] tcf_block_offload_cmd.isra.52+0x7e/0xb0 [ 278.551871] tcf_block_get_ext+0x365/0x3e0 [ 278.557569] qdisc_create+0x15c/0x4e0 [ 278.562859] ? kmem_cache_alloc_trace+0x1a2/0x1c0 [ 278.569235] tc_modify_qdisc+0x1c8/0x780 [ 278.574761] rtnetlink_rcv_msg+0x291/0x340 [ 278.580518] ? _cond_resched+0x15/0x40 [ 278.585856] ? rtnl_calcit.isra.29+0x120/0x120 [ 278.591868] netlink_rcv_skb+0x4a/0x110 [ 278.597198] netlink_unicast+0x1a0/0x250 [ 278.602601] netlink_sendmsg+0x2c1/0x3c0 [ 278.608022] sock_sendmsg+0x5b/0x60 [ 278.612969] ___sys_sendmsg+0x289/0x310 [ 278.618231] ? do_wp_page+0x99/0x730 [ 278.623216] ? page_add_new_anon_rmap+0xbe/0x140 [ 278.629298] ? __handle_mm_fault+0xc84/0x1360 [ 278.635113] ? __sys_sendmsg+0x5e/0xa0 [ 278.640285] __sys_sendmsg+0x5e/0xa0 [ 278.645239] do_syscall_64+0x5b/0x1b0 [ 278.650274] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 278.656697] RIP: 0033:0x7f796abdeb87 [ 278.661628] Code: 64 89 02 48 c7 c0 ff ff ff ff eb b9 0f 1f 80 00 00 00 00 8b 05 6a 2b 2c 00 48 63 d2 48 63 ff 85 c0 75 18 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 59 f3 c3 0f 1f 80 00 00 00 00 53 48 89 f3 48 [ 278.683248] RSP: 002b:00007ffde213ba48 EFLAGS: 00000246 ORIG_RAX: 000000000000002e [ 278.692245] RAX: ffffffffffffffda RBX: 000000005d261e6f RCX: 00007f796abdeb87 [ 278.700862] RDX: 0000000000000000 RSI: 00007ffde213bab0 RDI: 0000000000000003 [ 278.709527] RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000006 [ 278.718167] R10: 000000000000000c R11: 0000000000000246 R12: 0000000000000001 [ 278.726743] R13: 000000000067b580 R14: 0000000000000000 R15: 0000000000000000 [ 278.735302] Modules linked in: dummy vxlan ip6_udp_tunnel udp_tunnel sch_ingress nfsv3 nfs_acl nfs lockd grace fscache bridge stp llc sunrpc mlx5_ib ib_uverbs intel_rapl ib_core sb_edac x86_pkg_temp_ thermal intel_powerclamp coretemp kvm_intel kvm mlx5_core irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel igb ghash_clmulni_intel ses mei_me enclosure mlxfw ipmi_ssif intel_cstate iTCO_wdt ptp mei pps_core iTCO_vendor_support pcspkr joydev intel_uncore i2c_i801 ipmi_si lpc_ich intel_rapl_perf ioatdma wmi dca pcc_cpufreq ipmi_devintf ipmi_msghandler acpi_power_meter acpi_pad ast i2c_algo_bit drm_k ms_helper ttm drm mpt3sas raid_class scsi_transport_sas [ 278.802263] CR2: 0000000000000000 [ 278.807170] ---[ end trace b1f0a442a279e66f ]--- Extend en_rep with new static mlx5e_rep_block_cb_list list and pass it to flow_block_cb_setup_simple() function instead of hardcoded NULL pointer. Fixes: 955bcb6ea0 ("drivers: net: use flow block API") Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Acked-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-07-12 15:27:41 -07:00
..
3com	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
8390	SPDX update for 5.2-rc6	2019-06-21 09:58:42 -07:00
adaptec	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
aeroflex	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
agere	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
alacritech	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235	2019-06-19 17:09:07 +02:00
allwinner	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
alteon	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
altera	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
amazon	Revert "net: ena: ethtool: add extra properties retrieval via get_priv_flags"	2019-06-26 09:07:39 -07:00
amd	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
apm	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
apple	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
aquantia	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-27 21:06:39 -07:00
arc	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
atheros	atl1c: remove redundant assignment to variable tpd_req	2019-07-03 11:32:39 -07:00
aurora	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
broadcom	net: flow_offload: rename tc_cls_flower_offload to flow_cls_offload	2019-07-09 14:38:51 -07:00
brocade	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 292	2019-06-05 17:36:38 +02:00
cadence	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
calxeda	net/ethernet: using dev_get_drvdata directly	2019-07-05 15:25:04 -07:00
cavium	net: lio_core: fix potential sign-extension overflow on large shift	2019-06-18 21:00:40 -04:00
chelsio	net: flow_offload: rename tc_cls_flower_offload to flow_cls_offload	2019-07-09 14:38:51 -07:00
cirrus	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cisco	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
cortina
davicom	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
dec	SPDX update for 5.2-rc3, round 1	2019-05-31 08:34:32 -07:00
dlink	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
emulex	be2net: fix link failure after ethtool offline test	2019-06-22 09:40:50 -04:00
ezchip	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 291	2019-06-05 17:36:38 +02:00
faraday	Linux 5.2-rc4	2019-06-14 14:18:53 -06:00
freescale	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 20:20:36 -07:00
fujitsu	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
google	gve: fix unused variable/label warnings	2019-07-08 12:40:58 -07:00
hisilicon	net: hisilicon: Add an tx_desc to adapt HI13X1_GMAC	2019-07-09 14:29:27 -07:00
hp	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 86	2019-05-24 17:37:52 +02:00
huawei	hinic: add fw version query	2019-07-07 22:15:12 -07:00
i825xx	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
ibm	ibmvnic: Fix unchecked return codes of memory allocations	2019-06-09 19:51:28 -07:00
intel	net: flow_offload: rename tc_cls_flower_offload to flow_cls_offload	2019-07-09 14:38:51 -07:00
marvell	net: mvmdio: defer probe of orion-mdio if a clock is not ready	2019-07-09 13:03:04 -07:00
mediatek	net: ethernet: mediatek: Fix misuses of GENMASK macro	2019-07-11 14:30:07 -07:00
mellanox	net/mlx5e: Provide cb_list pointer when setting up tc block on rep	2019-07-12 15:27:41 -07:00
micrel	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
microchip	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
moxa	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
mscc	net: flow_offload: rename tc_cls_flower_offload to flow_cls_offload	2019-07-09 14:38:51 -07:00
myricom	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
natsemi	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
neterion	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
netronome	net: flow_offload: rename tc_cls_flower_offload to flow_cls_offload	2019-07-09 14:38:51 -07:00
ni	net: nixge: Fix misuse of strlcpy	2019-07-07 19:23:05 -07:00
nuvoton	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441	2019-06-05 17:37:17 +02:00
nvidia	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13	2019-05-21 11:28:45 +02:00
nxp	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
oki-semi	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 340	2019-06-05 17:37:07 +02:00
packetengines	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
pasemi	net: pasemi: fix an use-after-free in pasemi_mac_phy_init()	2019-07-08 16:33:02 -07:00
qlogic	net: flow_offload: rename tc_cls_flower_offload to flow_cls_offload	2019-07-09 14:38:51 -07:00
qualcomm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 20:20:36 -07:00
rdc	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
realtek	r8169: sync few chip names with vendor driver	2019-07-07 13:05:40 -07:00
renesas	net: sh_eth: fix mdio access in sh_eth_close() for R-Car Gen2 and RZ/A1 SoCs	2019-05-29 13:24:54 -07:00
rocker	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-07 11:00:14 -07:00
samsung	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
seeq	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sfc	sfc: Remove 'PCIE error reporting unavailable'	2019-07-08 12:16:48 -07:00
sgi	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
silan	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
sis	sis900: remove TxIDLE	2019-06-27 22:38:23 -07:00
smsc	docs: kbuild: convert docs to ReST and rename to *.rst	2019-06-14 14:21:21 -06:00
socionext	net: netsec: remove static declaration for netsec_set_tx_de()	2019-07-09 14:46:40 -07:00
stmicro	net: stmmac: Fix misuses of GENMASK macro	2019-07-11 14:30:07 -07:00
sun	net: ethernet: sun: remove redundant assignment to variable err	2019-07-04 12:12:13 -07:00
synopsys	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
tehuti	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ti	davinci_cpdma: don't cast dma_addr_t to pointer	2019-07-12 15:19:37 -07:00
toshiba	ps3_gelic: Use [] to denote a flexible array member	2019-06-18 10:43:20 -07:00
tundra	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
via	net: ipv4: provide __rcu annotation for ifa_list	2019-06-02 18:08:36 -07:00
wiznet	net: ethernet: wiznet: w5X00 add device tree support	2019-06-12 09:52:04 -07:00
xilinx	net: axienet: fix a potential double free in axienet_probe()	2019-07-08 16:28:32 -07:00
xircom	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
xscale	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 206	2019-05-30 11:29:53 -07:00
dnet.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
dnet.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
ec_bhf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
ethoc.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
fealnx.c
jme.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 195	2019-05-30 11:29:22 -07:00
jme.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 195	2019-05-30 11:29:22 -07:00
Kconfig	gve: Add basic driver framework for Compute Engine Virtual NIC	2019-07-01 19:36:35 -07:00
korina.c
lantiq_etop.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234	2019-06-19 17:09:07 +02:00
lantiq_xrx200.c
Makefile	gve: Add basic driver framework for Compute Engine Virtual NIC	2019-07-01 19:36:35 -07:00
netx-eth.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234	2019-06-19 17:09:07 +02:00