8fc3672a8a
Jakub Kicinski brought up a concern in ibmvnic_set_mac().
ibmvnic_set_mac() does this:
ether_addr_copy(adapter->mac_addr, addr->sa_data);
if (adapter->state != VNIC_PROBED)
rc = __ibmvnic_set_mac(netdev, addr->sa_data);
So if state == VNIC_PROBED, the user can assign an invalid address to
adapter->mac_addr, and ibmvnic_set_mac() will still return 0.
The fix is to validate ethernet address at the beginning of
ibmvnic_set_mac(), and move the ether_addr_copy to
the case of "adapter->state != VNIC_PROBED".
Fixes:
|
||
|---|---|---|
| .. | ||
| ehea | ||
| emac | ||
| ibmveth.c | ||
| ibmveth.h | ||
| ibmvnic.c | ||
| ibmvnic.h | ||
| Kconfig | ||
| Makefile | ||