leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35fcf02f80
linux/drivers/usb/storage
History
Jia-Ju Bai 2a3dae10d5 usb: storage: Replace mdelay with msleep in init_freecom 
init_freecom() is never called in atomic context.

init_freecom() is set as ".initFunction" through UNUSUAL_DEV().
And ->initFunction() is only called by usb_stor_acquire_resources(),
which is only called by usb_stor_probe2().
usb_stor_probe2() is called by *_probe() functions (like alauda_probe())
for each USB driver.
*_probe() functions are set ".probe" in struct usb_driver.
These functions are not called in atomic context.

Despite never getting called from atomic context, init_freecom()
calls mdelay() to busily wait.
This is not necessary and can be replaced with msleep() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-04-22 15:49:42 +02:00
..
alauda.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
cypress_atacb.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
datafab.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
debug.c USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
debug.h USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
ene_ub6250.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
freecom.c usb: storage: Replace mdelay with msleep in init_freecom 2018-04-22 15:49:42 +02:00
initializers.c USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
initializers.h USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
isd200.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
jumpshot.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
karma.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
Kconfig
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
onetouch.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
option_ms.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
option_ms.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
protocol.c USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
protocol.h USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
realtek_cr.c treewide: setup_timer() -> timer_setup() 2017-11-21 15:57:07 -08:00
scsiglue.c USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
scsiglue.h USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
sddr09.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
sddr55.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
shuttle_usbat.c USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
sierra_ms.c USB: move many drivers to use DEVICE_ATTR_RO 2018-01-24 08:49:52 +01:00
sierra_ms.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
transport.c USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
transport.h USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
uas-detect.h uas: Always apply US_FL_NO_ATA_1X quirk to Seagate devices 2017-11-28 15:17:49 +01:00
uas.c uas: fix comparison for error code 2018-03-06 09:13:32 -08:00
unusual_alauda.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_cypress.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_datafab.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_devs.h USB: storage: Add JMicron bridge 152d:2567 to unusual_devs.h 2018-03-08 10:03:04 -08:00
unusual_ene_ub6250.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_freecom.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_isd200.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_jumpshot.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_karma.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_onetouch.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_realtek.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_sddr09.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_sddr55.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
unusual_uas.h Merge 4.15-rc8 into usb-next 2018-01-15 15:00:11 +01:00
unusual_usbat.h USB: storage: Remove redundant license text 2017-11-04 11:55:38 +01:00
usb.c USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
usb.h USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00
usual-tables.c USB: storage: remove invalid URL from drivers 2018-01-23 10:22:34 +01:00