forked from Minki/linux
35d3fdd5f3
Resolve http://bugzilla.kernel.org/show_bug.cgi?id=11051 and other bugs related to the way the HPET glue code in rtc-cmos was incomplete and inconsistent: * Switch the approach so that the basic driver code flow isn't changed by having HPET ... instead, just have HPET shadow the RTC_CONTROL irq enables and RTC_FREQ_SELECT data. It's only coping with IRQ thievery, after all. * Do that consistently (!!) to avoid problems when the HPET code is out of sync with the real RTC intent. Examples include: - cmos_procfs(), which now reports correct data - cmos_irq_set_state() ... also removing the previous PIE_{ON,OFF} ioctl support so only one code path manages "periodic" IRQs - cmos_do_shutdown() ... currently a "just in case" change. - cmos_suspend() and cmos_resume() ... also handling a bug that was specific to HPET's IRQ thievery, where the alarm wasn't disabled after waking the system * Always call that HPET code under the RTC spinlock (it doesn't do its own locking) Also clean up the HPET glue: * Add some comments explaining what's going on. * Switch to having just one #ifdef for the HPET glue, and inline functions (not #defines) to avoid some compiler warnings. * Have the probe message also report when HPET IRQs are involved This still leaves various holes in the HPET glue, like the emulated update IRQs being out of sync with the RTC, alarms never using day or month matches, and many extra IRQs (at 64 Hz). [akpm@linux-foundation.org: fix build] Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Cc: Tomas Janousek <tomi@nomi.cz> Cc: Bernhard Walle <bwalle@suse.de> Cc: Carlos R. Mafra <crmafra@ift.unesp.br> Acked-by: Alessandro Zummo <a.zummo@towertech.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| class.c | ||
| hctosys.c | ||
| interface.c | ||
| Kconfig | ||
| Makefile | ||
| rtc-at32ap700x.c | ||
| rtc-at91rm9200.c | ||
| rtc-at91sam9.c | ||
| rtc-bfin.c | ||
| rtc-cmos.c | ||
| rtc-core.h | ||
| rtc-dev.c | ||
| rtc-ds1216.c | ||
| rtc-ds1302.c | ||
| rtc-ds1305.c | ||
| rtc-ds1307.c | ||
| rtc-ds1374.c | ||
| rtc-ds1511.c | ||
| rtc-ds1553.c | ||
| rtc-ds1672.c | ||
| rtc-ds1742.c | ||
| rtc-ep93xx.c | ||
| rtc-fm3130.c | ||
| rtc-isl1208.c | ||
| rtc-lib.c | ||
| rtc-m41t80.c | ||
| rtc-m41t94.c | ||
| rtc-m48t59.c | ||
| rtc-m48t86.c | ||
| rtc-max6900.c | ||
| rtc-max6902.c | ||
| rtc-omap.c | ||
| rtc-pcf8563.c | ||
| rtc-pcf8583.c | ||
| rtc-pl030.c | ||
| rtc-pl031.c | ||
| rtc-ppc.c | ||
| rtc-proc.c | ||
| rtc-r9701.c | ||
| rtc-rs5c313.c | ||
| rtc-rs5c348.c | ||
| rtc-rs5c372.c | ||
| rtc-s3c.c | ||
| rtc-s35390a.c | ||
| rtc-sa1100.c | ||
| rtc-sh.c | ||
| rtc-stk17ta8.c | ||
| rtc-sysfs.c | ||
| rtc-test.c | ||
| rtc-v3020.c | ||
| rtc-vr41xx.c | ||
| rtc-x1205.c | ||