Christophe Leroy 3194d2533e spi: fsl: don't map irq during probe ... With lastest kernel, the following warning is observed at startup: [ 1.500609] ------------[ cut here ]------------ [ 1.505225] remove_proc_entry: removing non-empty directory 'irq/22', leaking at least 'fsl_spi' [ 1.514234] WARNING: CPU: 0 PID: 1 at fs/proc/generic.c:682 remove_proc_entry+0x198/0x1c0 [ 1.522403] CPU: 0 PID: 1 Comm: swapper Not tainted 5.4.0-s3k-dev-02248-g93532430a4ff #2564 [ 1.530724] NIP: c0197694 LR: c0197694 CTR: c0050d80 [ 1.535762] REGS: df4a5af0 TRAP: 0700 Not tainted (5.4.0-02248-g93532430a4ff) [ 1.543818] MSR: 00029032 <EE,ME,IR,DR,RI> CR: 22028222 XER: 00000000 [ 1.550524] [ 1.550524] GPR00: c0197694 df4a5ba8 df4a0000 00000054 00000000 00000000 00004a38 00000010 [ 1.550524] GPR08: c07c5a30 00000800 00000000 00001032 22000208 00000000 c0004b14 00000000 [ 1.550524] GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 c0830000 c07fc078 [ 1.550524] GPR24: c08e8ca0 df665d10 df60ea98 c07c9db8 00000001 df5d5ae3 df5d5a80 df43f8e3 [ 1.585327] NIP [c0197694] remove_proc_entry+0x198/0x1c0 [ 1.590628] LR [c0197694] remove_proc_entry+0x198/0x1c0 [ 1.595829] Call Trace: [ 1.598280] [df4a5ba8] [c0197694] remove_proc_entry+0x198/0x1c0 (unreliable) [ 1.605321] [df4a5bd8] [c0067acc] unregister_irq_proc+0x5c/0x70 [ 1.611238] [df4a5bf8] [c005fbc4] free_desc+0x3c/0x80 [ 1.616286] [df4a5c18] [c005fe2c] irq_free_descs+0x70/0xa8 [ 1.621778] [df4a5c38] [c033d3fc] of_fsl_spi_probe+0xdc/0x3cc [ 1.627525] [df4a5c88] [c02f0f64] platform_drv_probe+0x44/0xa4 [ 1.633350] [df4a5c98] [c02eee44] really_probe+0x1ac/0x418 [ 1.638829] [df4a5cc8] [c02ed3e8] bus_for_each_drv+0x64/0xb0 [ 1.644481] [df4a5cf8] [c02ef950] __device_attach+0xd4/0x128 [ 1.650132] [df4a5d28] [c02ed61c] bus_probe_device+0xa0/0xbc [ 1.655783] [df4a5d48] [c02ebbe8] device_add+0x544/0x74c [ 1.661096] [df4a5d88] [c0382b78] of_platform_device_create_pdata+0xa4/0x100 [ 1.668131] [df4a5da8] [c0382cf4] of_platform_bus_create+0x120/0x20c [ 1.674474] [df4a5df8] [c0382d50] of_platform_bus_create+0x17c/0x20c [ 1.680818] [df4a5e48] [c0382e88] of_platform_bus_probe+0x9c/0xf0 [ 1.686907] [df4a5e68] [c0751404] __machine_initcall_cmpcpro_cmpcpro_declare_of_platform_devices+0x74/0x1a4 [ 1.696629] [df4a5e98] [c072a4cc] do_one_initcall+0x8c/0x1d4 [ 1.702282] [df4a5ef8] [c072a768] kernel_init_freeable+0x154/0x204 [ 1.708455] [df4a5f28] [c0004b2c] kernel_init+0x18/0x110 [ 1.713769] [df4a5f38] [c00122ac] ret_from_kernel_thread+0x14/0x1c [ 1.719926] Instruction dump: [ 1.722889] 2c030000 4182004c 3863ffb0 3c80c05f 80e3005c 388436a0 3c60c06d 7fa6eb78 [ 1.730630] 7fe5fb78 38840280 38634178 4be8c611 <0fe00000> 4bffff6c 3c60c071 7fe4fb78 [ 1.738556] ---[ end trace 05d0720bf2e352e2 ]--- The problem comes from the error path which calls irq_dispose_mapping() while the IRQ has been requested with devm_request_irq(). IRQ doesn't need to be mapped with irq_of_parse_and_map(). The only need is to get the IRQ virtual number. For that, use of_irq_to_resource() instead of the irq_of_parse_and_map()/irq_dispose_mapping() pair. Fixes: 500a32abaf ("spi: fsl: Call irq_dispose_mapping in err path") Cc: stable@vger.kernel.org Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Link: https://lore.kernel.org/r/518cfb83347d5372748e7fe72f94e2e9443d0d4a.1575905123.git.christophe.leroy@c-s.fr Signed-off-by: Mark Brown <broonie@kernel.org>		2019-12-09 18:44:40 +00:00
..
atmel-quadspi.c	spi: Remove dev_err() usage after platform_get_irq()	2019-08-02 12:15:43 +01:00
internals.h	spi: Add an helper to flush the message queue	2018-04-23 15:48:18 +01:00
Kconfig	spi: Fix Kconfig indentation	2019-11-20 17:11:50 +00:00
Makefile	ARM: SoC driver updates for v5.4	2019-09-16 15:52:38 -07:00
spi-altera.c	spi: altera: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:14:50 +01:00
spi-armada-3700.c	spi: a3700: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:15:09 +01:00
spi-at91-usart.c	spi: at91-usart: Use dma_request_chan() directly for channel request	2019-11-15 12:13:02 +00:00
spi-ath79.c	spi: ath79: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:15:29 +01:00
spi-atmel.c	spi: atmel: Use dma_request_chan() directly for channel request	2019-11-15 12:13:22 +00:00
spi-au1550.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
spi-axi-spi-engine.c	spi: spi-axi: extend support for the delay field	2019-10-15 11:47:26 +01:00
spi-bcm63xx-hsspi.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-bcm63xx.c	spi: bcm63xx: extend error condition to delay as well	2019-10-15 11:47:06 +01:00
spi-bcm2835.c	Merge branch 'spi-5.4' into spi-next	2019-09-15 10:32:06 +01:00
spi-bcm2835aux.c	spi: bcm2835aux: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:16:08 +01:00
spi-bcm-qspi.c	spi: bcm-qspi: Convert to use CS GPIO descriptors	2019-11-07 13:10:57 +00:00
spi-bcm-qspi.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 459	2019-06-19 17:09:09 +02:00
spi-bitbang-txrx.h
spi-bitbang.c	Linux 5.2-rc4	2019-06-10 18:52:53 +01:00
spi-brcmstb-qspi.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 459	2019-06-19 17:09:09 +02:00
spi-butterfly.c	spi: docs: convert to ReST and add it to the kABI bookset	2019-07-31 14:13:13 -06:00
spi-cadence.c	spi: cadence: Correct handling of native chipselect	2019-11-27 12:54:45 +00:00
spi-cavium-octeon.c	spi: octeon: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:17:27 +01:00
spi-cavium-thunderx.c	spi: spi-cavium-thunderx: Add missing pci_release_regions()	2019-12-09 18:44:19 +00:00
spi-cavium.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-cavium.h
spi-clps711x.c	spi: clps711x: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:17:36 +01:00
spi-coldfire-qspi.c	spi: coldfire-qspi: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:17:56 +01:00
spi-davinci.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
spi-dln2.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372	2019-06-05 17:37:10 +02:00
spi-dw-mid.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288	2019-06-05 17:36:37 +02:00
spi-dw-mmio.c	spi: dw: Add compatible string for Renesas RZ/N1 SPI Controller	2019-10-01 12:33:19 +01:00
spi-dw-pci.c	spi: dw-pci: Fix Chip Select amount on Intel Elkhart Lake PSE SPI	2019-10-22 17:57:43 +01:00
spi-dw.c	spi: dw: Correct handling of native chipselect	2019-11-28 13:16:36 +00:00
spi-dw.h	spi: dw: Drop GPIO header	2019-10-30 14:14:50 +00:00
spi-efm32.c	spi: Remove dev_err() usage after platform_get_irq()	2019-08-02 12:15:43 +01:00
spi-ep93xx.c	spi: Remove dev_err() usage after platform_get_irq()	2019-08-02 12:15:43 +01:00
spi-falcon.c	spi: spi-falcon: extend warning to delay as well	2019-10-15 11:46:57 +01:00
spi-fsl-cpm.c	spi: fsl-spi: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:24:26 +01:00
spi-fsl-cpm.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
spi-fsl-dspi.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-fsl-espi.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-fsl-lib.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
spi-fsl-lib.h	spi: fsl: Convert to use CS GPIO descriptors	2019-08-28 14:10:41 +01:00
spi-fsl-lpspi.c	spi: fsl-lpspi: Use dma_request_chan() directly for channel request	2019-11-15 12:13:41 +00:00
spi-fsl-qspi.c	Merge branch 'for-5.4' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi into spi-5.5	2019-10-08 19:12:28 +01:00
spi-fsl-spi.c	spi: fsl: don't map irq during probe	2019-12-09 18:44:40 +00:00
spi-fsl-spi.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
spi-geni-qcom.c	spi: spi-geni-qcom: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:18:25 +01:00
spi-gpio.c	Merge branch 'for-5.4' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi into spi-5.5	2019-10-08 19:12:28 +01:00
spi-img-spfi.c	spi: img-spfi: fix potential double release	2019-11-06 15:33:39 +00:00
spi-imx.c	spi: imx: Use dma_request_chan() directly for channel request	2019-11-15 12:14:00 +00:00
spi-iproc-qspi.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
spi-jcore.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
spi-lantiq-ssc.c	spi: lantiq-ssc: Use devm_platform_ioremap_resource() in lantiq_ssc_probe()	2019-10-01 12:34:18 +01:00
spi-lm70llp.c	spi: docs: convert to ReST and add it to the kABI bookset	2019-07-31 14:13:13 -06:00
spi-loopback-test.c	spi: spi-loopback-test: use new delay field	2019-10-15 11:45:19 +01:00
spi-lp8841-rtc.c	spi: lp-8841: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:18:35 +01:00
spi-mem.c	spi: spi-mem: fallback to using transfers when CS gpios are used	2019-11-07 13:11:18 +00:00
spi-meson-spicc.c	spi: meson-spicc: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:18:55 +01:00
spi-meson-spifc.c	spi: spi-meson-spifc: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:19:14 +01:00
spi-mpc52xx-psc.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-mpc52xx.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428	2019-06-05 17:37:16 +02:00
spi-mpc512x-psc.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-mt65xx.c	spi: mediatek: add SPI_CS_HIGH support	2019-11-18 17:47:00 +00:00
spi-mt7621.c	spi: mt7621: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:19:34 +01:00
spi-mxic.c	Merge branch 'for-5.4' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi into spi-5.5	2019-10-08 19:12:28 +01:00
spi-mxs.c	spi: mxs: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:19:54 +01:00
spi-npcm-fiu.c	spi: npcm-fiu: remove set but not used variable 'retlen'	2019-09-05 18:19:45 +01:00
spi-npcm-pspi.c	spi: npcm: Remove set but not used variable 'val'	2019-10-09 18:20:16 +01:00
spi-nxp-fspi.c	spi: nxp-fspi: Use devm API to fix missed unregistration of controller	2019-11-11 12:50:48 +00:00
spi-oc-tiny.c	spi: oc-tiny: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:20:33 +01:00
spi-omap2-mcspi.c	spi: omap2-mcspi: Remove redundant checks	2019-11-11 12:50:26 +00:00
spi-omap-100k.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-omap-uwire.c
spi-orion.c	spi: orion: use new word_delay field for SPI transfers	2019-10-15 11:43:31 +01:00
spi-pic32-sqi.c	spi: pic32-sqi: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:20:52 +01:00
spi-pic32.c	spi: pic32: Retire dma_request_slave_channel_compat()	2019-11-22 19:53:41 +00:00
spi-pl022.c	spi: pl022: Use dma_request_chan() directly for channel request	2019-11-15 12:14:19 +00:00
spi-ppc4xx.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
spi-pxa2xx-dma.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
spi-pxa2xx-pci.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
spi-pxa2xx.c	spi: pxa2xx: Add support for Intel Jasper Lake	2019-11-25 13:31:39 +00:00
spi-pxa2xx.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
spi-qcom-qspi.c	spi: spi-qcom-qspi: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:21:12 +01:00
spi-qup.c	spi: qup: Use dma_request_chan() directly for channel request	2019-11-15 12:14:29 +00:00
spi-rb4xx.c	spi: rb4xx: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:21:21 +01:00
spi-rockchip.c	Linux 5.2-rc4	2019-06-10 18:52:53 +01:00
spi-rspi.c	spi: rspi: Fix handling of QSPI code when transmit and receive	2019-05-02 10:38:44 +09:00
spi-s3c24xx-fiq.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
spi-s3c24xx-fiq.S	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
spi-s3c24xx.c	spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:21:31 +01:00
spi-s3c64xx.c	spi: s3c64xx: Use dma_request_chan() directly for channel request	2019-11-15 12:14:39 +00:00
spi-sc18is602.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-sh-hspi.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-sh-msiof.c	spi: sh-msiof: Use devm_platform_ioremap_resource() helper	2019-08-07 14:24:47 +01:00
spi-sh-sci.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
spi-sh.c	spi: Remove dev_err() usage after platform_get_irq()	2019-08-02 12:15:43 +01:00
spi-sifive.c	spi: sifive: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:21:41 +01:00
spi-sirf.c	spi: sirf: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:22:00 +01:00
spi-slave-mt27xx.c	spi: mediatek: Use devm_platform_ioremap_resource() in mtk_spi_slave_probe()	2019-10-01 12:34:58 +01:00
spi-slave-system-control.c	spi: slave: Fix missing break in switch	2018-10-03 16:23:10 +01:00
spi-slave-time.c
spi-sprd-adi.c	spi: sprd: adi: Set BIT_WDG_NEW bit when rebooting	2019-10-28 13:17:10 +00:00
spi-sprd.c	spi: sprd: Fix the incorrect SPI register	2019-12-04 12:14:13 +00:00
spi-st-ssc4.c	spi: st-ssc4: add missed pm_runtime_disable	2019-11-18 12:59:11 +00:00
spi-stm32-qspi.c	spi: stm32-qspi: Fix kernel oops when unbinding driver	2019-10-04 18:47:21 +01:00
spi-stm32.c	spi: stm32: return the get_irq error	2019-05-02 10:38:41 +09:00
spi-sun4i.c	spi: sun4i: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:22:29 +01:00
spi-sun6i.c	spi: sun6i: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:22:49 +01:00
spi-synquacer.c	spi: Remove dev_err() usage after platform_get_irq()	2019-08-02 12:15:43 +01:00
spi-tegra20-sflash.c	spi: tegra20-sflash: use to new spi_transfer_delay_exec	2019-10-15 11:45:07 +01:00
spi-tegra20-slink.c	spi: tegra20-slink: add missed clk_unprepare	2019-11-15 12:15:22 +00:00
spi-tegra114.c	spi: tegra114: Use dma_request_chan() directly for channel request	2019-11-15 12:15:01 +00:00
spi-test.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
spi-ti-qspi.c	spi: Remove dev_err() usage after platform_get_irq()	2019-08-02 12:15:43 +01:00
spi-tle62x0.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
spi-topcliff-pch.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-txx9.c	spi: txx9: Convert to use GPIO descriptors	2019-10-30 14:14:32 +00:00
spi-uniphier.c	Merge branch 'spi-5.4' into spi-next	2019-09-15 10:32:06 +01:00
spi-xcomm.c	spi: use new spi_transfer_delay_exec helper where straightforward	2019-10-15 11:51:57 +01:00
spi-xilinx.c	spi: xilinx: Add DT support for selecting transfer word width	2019-10-24 12:45:21 +01:00
spi-xlp.c	spi: xlp: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:23:28 +01:00
spi-xtensa-xtfpga.c	spi: xtensa-xtfpga: Use devm_platform_ioremap_resource() in xtfpga_spi_probe()	2019-10-01 12:35:18 +01:00
spi-zynq-qspi.c	spi: zynq-qspi: Support two chip selects	2019-11-08 17:45:09 +00:00
spi-zynqmp-gqspi.c	spi: zynqmp: use devm_platform_ioremap_resource() to simplify code	2019-09-04 17:23:48 +01:00
spi.c	spi: Fix regression to return zero on success instead of positive value	2019-11-12 18:23:51 +00:00
spidev.c	spi: spidev: use new delay field for spi transfers	2019-10-15 11:45:29 +01:00