forked from Minki/linux
6a90230593
This patch moves data allocated using kzalloc to managed data allocated
using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
functions. Also, linux/device.h is added to make sure the devm_*()
routine declarations are unambiguously available. The function
mddi_dummy_remove is removed as it is no longer required after
removing the kfree. The variable ret is also done away with.
The following Coccinelle semantic patch was used for making a part of
the change:
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};
@prb@
identifier platform.probefn, pdev;
expression e, e1, e2;
@@
probefn(struct platform_device *pdev, ...) {
<+...
- e = kzalloc(e1, e2)
+ e = devm_kzalloc(&pdev->dev, e1, e2)
...
?-kfree(e);
...+>
}
@rem depends on prb@
identifier platform.removefn;
expression e;
@@
removefn(...) {
<...
- kfree(e);
...>
}
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
86 lines
2.3 KiB
C
86 lines
2.3 KiB
C
/* drivers/video/msm_fb/mddi_client_dummy.c
|
|
*
|
|
* Support for "dummy" mddi client devices which require no
|
|
* special initialization code.
|
|
*
|
|
* Copyright (C) 2007 Google Incorporated
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/platform_data/video-msm_fb.h>
|
|
|
|
struct panel_info {
|
|
struct platform_device pdev;
|
|
struct msm_panel_data panel_data;
|
|
};
|
|
|
|
static int mddi_dummy_suspend(struct msm_panel_data *panel_data)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int mddi_dummy_resume(struct msm_panel_data *panel_data)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int mddi_dummy_blank(struct msm_panel_data *panel_data)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int mddi_dummy_unblank(struct msm_panel_data *panel_data)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int mddi_dummy_probe(struct platform_device *pdev)
|
|
{
|
|
struct msm_mddi_client_data *client_data = pdev->dev.platform_data;
|
|
struct panel_info *panel =
|
|
devm_kzalloc(&pdev->dev, sizeof(struct panel_info), GFP_KERNEL);
|
|
if (!panel)
|
|
return -ENOMEM;
|
|
platform_set_drvdata(pdev, panel);
|
|
panel->panel_data.suspend = mddi_dummy_suspend;
|
|
panel->panel_data.resume = mddi_dummy_resume;
|
|
panel->panel_data.blank = mddi_dummy_blank;
|
|
panel->panel_data.unblank = mddi_dummy_unblank;
|
|
panel->panel_data.caps = MSMFB_CAP_PARTIAL_UPDATES;
|
|
panel->pdev.name = "msm_panel";
|
|
panel->pdev.id = pdev->id;
|
|
platform_device_add_resources(&panel->pdev,
|
|
client_data->fb_resource, 1);
|
|
panel->panel_data.fb_data = client_data->private_client_data;
|
|
panel->pdev.dev.platform_data = &panel->panel_data;
|
|
return platform_device_register(&panel->pdev);
|
|
}
|
|
|
|
static struct platform_driver mddi_client_dummy = {
|
|
.probe = mddi_dummy_probe,
|
|
.driver = { .name = "mddi_c_dummy" },
|
|
};
|
|
|
|
static int __init mddi_client_dummy_init(void)
|
|
{
|
|
platform_driver_register(&mddi_client_dummy);
|
|
return 0;
|
|
}
|
|
|
|
module_init(mddi_client_dummy_init);
|
|
|