Jason Gunthorpe 2b1fe162e5 vfio/fsl-mc: Re-order vfio_fsl_mc_probe() ... vfio_add_group_dev() must be called only after all of the private data in vdev is fully setup and ready, otherwise there could be races with user space instantiating a device file descriptor and starting to call ops. For instance vfio_fsl_mc_reflck_attach() sets vdev->reflck and vfio_fsl_mc_open(), called by fops open, unconditionally derefs it, which will crash if things get out of order. This driver started life with the right sequence, but two commits added stuff after vfio_add_group_dev(). Fixes: 2e0d29561f ("vfio/fsl-mc: Add irq infrastructure for fsl-mc devices") Fixes: f2ba7e8c94 ("vfio/fsl-mc: Added lock support in preparation for interrupt handling") Co-developed-by: Diana Craciun OSS <diana.craciun@oss.nxp.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Message-Id: <5-v3-225de1400dfc+4e074-vfio1_jgg@nvidia.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>		2021-04-06 11:55:10 -06:00
..
fsl-mc	vfio/fsl-mc: Re-order vfio_fsl_mc_probe()	2021-04-06 11:55:10 -06:00
mdev	vfio-mdev: Wire in a request handler for mdev parent	2020-12-03 16:21:07 -07:00
pci	vfio/nvlink: Add missing SPAPR_TCE_IOMMU depends	2021-03-29 14:48:00 -06:00
platform	vfio/platform: Use vfio_init/register/unregister_group_dev	2021-04-06 11:55:10 -06:00
Kconfig	vfio: Depend on MMU	2021-03-16 10:39:28 -06:00
Makefile	vfio/fsl-mc: Add VFIO framework skeleton for fsl-mc devices	2020-10-07 14:17:33 -06:00
vfio_iommu_spapr_tce.c	vfio/spapr_tce: convert get_user_pages() --> pin_user_pages()	2020-07-27 13:43:38 -06:00
vfio_iommu_type1.c	vfio/type1: Empty batch for pfnmap pages	2021-03-25 12:48:38 -06:00
vfio_spapr_eeh.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
vfio.c	vfio: Split creation of a vfio_device into init and register ops	2021-04-06 11:55:10 -06:00
virqfd.c	vfio/virqfd: Drain events from eventfd in virqfd_wakeup()	2020-11-15 09:49:10 -05:00