forked from Minki/linux
df29c9db8a
The omap4 CEC hardware cannot tell a Nack from a Low Drive from an Arbitration Lost error, so just report a Nack, which is almost certainly the reason for the error anyway. This also simplifies the implementation. The only three interrupts that need to be enabled are: Transmit Buffer Full/Empty Change event: triggered when the transmit finished successfully and cleared the buffer. Receiver FIFO Not Empty event: triggered when a message was received. Frame Retransmit Count Exceeded event: triggered when a transmit failed repeatedly, usually due to the message being Nacked. Other reasons are possible (Low Drive, Arbitration Lost) but there is no way to know. If this happens the TX buffer needs to be cleared manually. While testing various error conditions I noticed that the hardware can receive messages up to 18 bytes in total, which exceeds the legal maximum of 16. This could cause a buffer overflow, so we check for this and constrain the size to 16 bytes. The old incorrect interrupt handler could cause the CEC framework to enter into a bad state because it mis-detected the "Start Bit Irregularity event" as an ARB_LOST transmit error when it actually is a receive error which should be ignored. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Reported-by: Henrik Austad <haustad@cisco.com> Tested-by: Henrik Austad <haustad@cisco.com> Tested-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> |
||
|---|---|---|
| .. | ||
| displays | ||
| dss | ||
| Kconfig | ||
| Makefile | ||
| omap_connector.c | ||
| omap_crtc.c | ||
| omap_debugfs.c | ||
| omap_dmm_priv.h | ||
| omap_dmm_tiler.c | ||
| omap_dmm_tiler.h | ||
| omap_drv.c | ||
| omap_drv.h | ||
| omap_encoder.c | ||
| omap_fb.c | ||
| omap_fbdev.c | ||
| omap_gem_dmabuf.c | ||
| omap_gem.c | ||
| omap_irq.c | ||
| omap_plane.c | ||
| tcm-sita.c | ||
| tcm-sita.h | ||
| tcm.h | ||
| TODO | ||