linux/drivers/scsi/mpt2sas
Arnd Bergmann c45d15d24e scsi: autoconvert trivial BKL users to private mutex
All these files use the big kernel lock in a trivial
way to serialize their private file operations,
typically resulting from an earlier semi-automatic
pushdown from VFS.

None of these drivers appears to want to lock against
other code, and they all use the BKL as the top-level
lock in their file operations, meaning that there
is no lock-order inversion problem.

Consequently, we can remove the BKL completely,
replacing it with a per-file mutex in every case.
Using a scripted approach means we can avoid
typos.

file=$1
name=$2
if grep -q lock_kernel ${file} ; then
    if grep -q 'include.*linux.mutex.h' ${file} ; then
            sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
    else
            sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
    fi
    sed -i ${file} \
        -e "/^#include.*linux.mutex.h/,$ {
                1,/^\(static\|int\|long\)/ {
                     /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);

} }"  \
    -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
    -e '/[      ]*cycle_kernel_lock();/d'
else
    sed -i -e '/include.*\<smp_lock.h\>/d' ${file}  \
                -e '/cycle_kernel_lock()/d'
fi

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: linux-scsi@vger.kernel.org
Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>
2010-09-15 21:00:45 +02:00
..
mpi [SCSI] mpt2sas: MPI header version N is updated. 2010-07-27 12:02:13 -05:00
Kconfig [SCSI] mpt2sas: Copyright 2010. 2010-04-11 09:24:02 -05:00
Makefile
mpt2sas_base.c [SCSI] mpt2sas: driver fails to recover from injected PCIe bus errors 2010-07-27 12:04:03 -05:00
mpt2sas_base.h Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial 2010-08-04 15:31:02 -07:00
mpt2sas_config.c [SCSI] mpt2sas: driver fails to recover from injected PCIe bus errors 2010-07-27 12:04:03 -05:00
mpt2sas_ctl.c scsi: autoconvert trivial BKL users to private mutex 2010-09-15 21:00:45 +02:00
mpt2sas_ctl.h [SCSI] mpt2sas: Copyright 2010. 2010-04-11 09:24:02 -05:00
mpt2sas_debug.h [SCSI] mpt2sas: Copyright 2010. 2010-04-11 09:24:02 -05:00
mpt2sas_scsih.c Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial 2010-08-04 15:31:02 -07:00
mpt2sas_transport.c [SCSI] mpt2sas: driver fails to recover from injected PCIe bus errors 2010-07-27 12:04:03 -05:00