linux/drivers/dma/sh
Yoshihiro Shimoda 26fd830a99 dmaengine: shdma: fix a race condition in __ld_cleanup()
This patch fixes a race condition about a list of shdma-base driver.
If we don't apply this patch, a dma slave driver (especially a usb
peripheral driver) may not be able to start the transfer.

If a dma slave driver has a callback, __ld_cleanup() will call
the callback before this driver removes the list. After the callback,
since the return value of __ld_cleanup() is not zero,
shdma_chan_ld_cleanup() calls __ld_cleanup() again. And, __ld_clean()
will removes the list.

At this time, if a dma slave driver calls dmaengine_submit() before
this driver removes the list, this driver will set schan->pm_state
to SHDMA_PM_PENDING in shdma_tx_submit(). And then, even if a dma
slave driver calls dma_async_issue_pending(), this driver don't
start the transfer because the schan->pm_state is SHDMA_PM_PENDING
in shdma_issue_pending().

So, this patch adds a new condition in __ld_clean() to check if the
schan->pm_state is SHDMA_PM_PENDING or not.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2014-11-17 13:50:42 +05:30
..
Kconfig dmaengine: sh: Rework Kconfig and Makefile 2014-07-31 17:15:45 +05:30
Makefile dmaengine: sh: Rework Kconfig and Makefile 2014-07-31 17:15:45 +05:30
rcar-audmapp.c dmaengine: Remove .owner field for driver 2014-11-06 11:54:18 +05:30
rcar-hpbdma.c dmaengine: Remove .owner field for driver 2014-11-06 11:54:18 +05:30
shdma-arm.h dmaengine: shdma: Use defines instead of hardcoded numbers 2014-07-15 18:02:29 +09:00
shdma-base.c dmaengine: shdma: fix a race condition in __ld_cleanup() 2014-11-17 13:50:42 +05:30
shdma-of.c dmaengine: Remove .owner field for driver 2014-11-06 11:54:18 +05:30
shdma-r8a73a4.c DMA: shdma: add r8a73a4 DMAC data to the device ID table 2013-08-27 14:26:21 +05:30
shdma.h dmaengine: sh: Rework Kconfig and Makefile 2014-07-31 17:15:45 +05:30
shdmac.c dmaengine: sh: Remove chancnt affectations 2014-11-06 11:33:07 +05:30
sudmac.c dmaengine: Remove .owner field for driver 2014-11-06 11:54:18 +05:30