linux/drivers/block
Luis Chamberlain 2598a2bb35 floppy: fix add_disk() assumption on exit due to new developments
After the patch titled "floppy: use blk_mq_alloc_disk and
blk_cleanup_disk" the floppy driver was modified to allocate
the blk_mq_alloc_disk() which allocates the disk with the
queue. This is further clarified later with the patch titled
"block: remove alloc_disk and alloc_disk_node". This clarifies
that:

   Most drivers should use and have been converted to use
   blk_alloc_disk and blk_mq_alloc_disk.  Only the scsi
   ULPs and dasd still allocate a disk separately from the
   request_queue so don't bother with convenience macros for
   something that should not see significant new users and
   remove these wrappers.

And then we have the patch titled, "block: hold a request_queue
reference for the lifetime of struct gendisk" which ensures
that a queue is *always* present for sure during the entire
lifetime of a disk.

In the floppy driver's case then the disk always comes with the
queue. So even if even if the queue was cleaned up on exit, putting
the disk *is* still required, and likewise, blk_cleanup_queue() on
a null queue should not happen now as disk->queue is valid from
disk allocation time on.

Automatic backport code scrapers should hopefully not cherry pick
this patch as a stable fix candidate without full due dilligence to
ensure all the work done on the block layer to make this happen is
merged first.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20210927220302.1073499-3-mcgrof@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2021-10-18 14:41:37 -06:00
..
aoe aoe: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
drbd drbd: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
mtip32xx mtip32xx: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
null_blk null_blk: poll queue support 2021-10-18 14:41:36 -06:00
paride pf: add error handling support for add_disk() 2021-10-18 14:41:37 -06:00
rnbd block: add a struct io_comp_batch argument to fops->iopoll() 2021-10-18 14:40:40 -06:00
rsxx block/rsxx: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
xen-blkback isystem: trim/fixup stdarg.h and other headers 2021-08-19 09:02:55 +09:00
zram block: switch polling to be bio based 2021-10-18 06:17:36 -06:00
amiflop.c block: drop unused includes in <linux/genhd.h> 2021-10-18 06:17:02 -06:00
ataflop.c block: drop unused includes in <linux/genhd.h> 2021-10-18 06:17:02 -06:00
brd.c block: switch polling to be bio based 2021-10-18 06:17:36 -06:00
cryptoloop.c cryptoloop: add a deprecation warning 2021-08-27 10:44:54 -06:00
floppy.c floppy: fix add_disk() assumption on exit due to new developments 2021-10-18 14:41:37 -06:00
Kconfig SCSI misc on 20210902 2021-09-02 15:09:46 -07:00
loop.c loop: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
loop.h loop: reduce the loop_ctl_mutex scope 2021-09-03 22:14:40 -06:00
Makefile drivers/block: remove the umem driver 2021-03-24 06:57:40 -06:00
n64cart.c n64cart: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
nbd.c nbd: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
pktcdvd.c pktcdvd: add error handling support for add_disk() 2021-10-18 14:41:36 -06:00
ps3disk.c ps3disk: use memcpy_{from,to}_bvec 2021-08-02 13:37:27 -06:00
ps3vram.c block: switch polling to be bio based 2021-10-18 06:17:36 -06:00
rbd_types.h libceph, rbd: replace zero-length array with flexible-array 2020-06-01 13:22:53 +02:00
rbd.c rbd: add add_disk() error handling 2021-10-18 14:41:37 -06:00
sunvdc.c Char / Misc driver updates for 5.14-rc1 2021-07-05 13:42:16 -07:00
swim3.c block/swim3: add error handling support for add_disk() 2021-10-18 14:41:37 -06:00
swim_asm.S
swim.c block: drop unused includes in <linux/genhd.h> 2021-10-18 06:17:02 -06:00
sx8.c block/sx8: add error handling support for add_disk() 2021-10-18 14:41:37 -06:00
virtio_blk.c Revert "virtio-blk: Add validation for block size in config space" 2021-10-13 08:35:36 -04:00
xen-blkfront.c block: drop unused includes in <linux/genhd.h> 2021-10-18 06:17:02 -06:00
z2ram.c for-5.14/drivers-2021-06-29 2021-06-30 12:21:16 -07:00