forked from Minki/linux
ed5c2f5fd1
The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
118 lines
2.6 KiB
C
118 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright 2009-2010 Creative Product Design
|
|
* Marc Reilly marc@cpdesign.com.au
|
|
*/
|
|
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/mfd/core.h>
|
|
#include <linux/mfd/mc13xxx.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/of_gpio.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/err.h>
|
|
|
|
#include "mc13xxx.h"
|
|
|
|
static const struct i2c_device_id mc13xxx_i2c_device_id[] = {
|
|
{
|
|
.name = "mc13892",
|
|
.driver_data = (kernel_ulong_t)&mc13xxx_variant_mc13892,
|
|
}, {
|
|
.name = "mc34708",
|
|
.driver_data = (kernel_ulong_t)&mc13xxx_variant_mc34708,
|
|
}, {
|
|
/* sentinel */
|
|
}
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, mc13xxx_i2c_device_id);
|
|
|
|
static const struct of_device_id mc13xxx_dt_ids[] = {
|
|
{
|
|
.compatible = "fsl,mc13892",
|
|
.data = &mc13xxx_variant_mc13892,
|
|
}, {
|
|
.compatible = "fsl,mc34708",
|
|
.data = &mc13xxx_variant_mc34708,
|
|
}, {
|
|
/* sentinel */
|
|
}
|
|
};
|
|
MODULE_DEVICE_TABLE(of, mc13xxx_dt_ids);
|
|
|
|
static const struct regmap_config mc13xxx_regmap_i2c_config = {
|
|
.reg_bits = 8,
|
|
.val_bits = 24,
|
|
|
|
.max_register = MC13XXX_NUMREGS,
|
|
|
|
.cache_type = REGCACHE_NONE,
|
|
};
|
|
|
|
static int mc13xxx_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct mc13xxx *mc13xxx;
|
|
int ret;
|
|
|
|
mc13xxx = devm_kzalloc(&client->dev, sizeof(*mc13xxx), GFP_KERNEL);
|
|
if (!mc13xxx)
|
|
return -ENOMEM;
|
|
|
|
dev_set_drvdata(&client->dev, mc13xxx);
|
|
|
|
mc13xxx->irq = client->irq;
|
|
|
|
mc13xxx->regmap = devm_regmap_init_i2c(client,
|
|
&mc13xxx_regmap_i2c_config);
|
|
if (IS_ERR(mc13xxx->regmap)) {
|
|
ret = PTR_ERR(mc13xxx->regmap);
|
|
dev_err(&client->dev, "Failed to initialize regmap: %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
if (client->dev.of_node) {
|
|
const struct of_device_id *of_id =
|
|
of_match_device(mc13xxx_dt_ids, &client->dev);
|
|
mc13xxx->variant = of_id->data;
|
|
} else {
|
|
mc13xxx->variant = (void *)id->driver_data;
|
|
}
|
|
|
|
return mc13xxx_common_init(&client->dev);
|
|
}
|
|
|
|
static void mc13xxx_i2c_remove(struct i2c_client *client)
|
|
{
|
|
mc13xxx_common_exit(&client->dev);
|
|
}
|
|
|
|
static struct i2c_driver mc13xxx_i2c_driver = {
|
|
.id_table = mc13xxx_i2c_device_id,
|
|
.driver = {
|
|
.name = "mc13xxx",
|
|
.of_match_table = mc13xxx_dt_ids,
|
|
},
|
|
.probe = mc13xxx_i2c_probe,
|
|
.remove = mc13xxx_i2c_remove,
|
|
};
|
|
|
|
static int __init mc13xxx_i2c_init(void)
|
|
{
|
|
return i2c_add_driver(&mc13xxx_i2c_driver);
|
|
}
|
|
subsys_initcall(mc13xxx_i2c_init);
|
|
|
|
static void __exit mc13xxx_i2c_exit(void)
|
|
{
|
|
i2c_del_driver(&mc13xxx_i2c_driver);
|
|
}
|
|
module_exit(mc13xxx_i2c_exit);
|
|
|
|
MODULE_DESCRIPTION("i2c driver for Freescale MC13XXX PMIC");
|
|
MODULE_AUTHOR("Marc Reilly <marc@cpdesign.com.au");
|
|
MODULE_LICENSE("GPL v2");
|