forked from Minki/linux
2382960793
Smatch found a bug in the error handling: drivers/mtd/devices/docg3.c:1634 doc_register_sysfs() error: buffer overflow 'doc_sys_attrs' 4 <= 4 The problem is that if the very last device_create_file() fails, then we are beyond the end of the array. Actually, any time i == 3 then there is a problem. We can fix this an simplify the code at the same time by moving the !ret conditions out of the for loops and using a goto instead. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by: Brian Norris <computersforpeace@gmail.com> |
||
|---|---|---|
| .. | ||
| bcm47xxsflash.c | ||
| bcm47xxsflash.h | ||
| block2mtd.c | ||
| docg3.c | ||
| docg3.h | ||
| Kconfig | ||
| lart.c | ||
| m25p80.c | ||
| Makefile | ||
| ms02-nv.c | ||
| ms02-nv.h | ||
| mtd_dataflash.c | ||
| mtdram.c | ||
| phram.c | ||
| pmc551.c | ||
| powernv_flash.c | ||
| serial_flash_cmds.h | ||
| slram.c | ||
| spear_smi.c | ||
| sst25l.c | ||
| st_spi_fsm.c | ||