Anatol Pomazau 238191d65d scsi: iscsi: Don't send data to unbound connection ... If a faulty initiator fails to bind the socket to the iSCSI connection before emitting a command, for instance, a subsequent send_pdu, it will crash the kernel due to a null pointer dereference in sock_sendmsg(), as shown in the log below. This patch makes sure the bind succeeded before trying to use the socket. BUG: kernel NULL pointer dereference, address: 0000000000000018 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] SMP PTI CPU: 3 PID: 7 Comm: kworker/u8:0 Not tainted 5.4.0-rc2.iscsi+ #13 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 [ 24.158246] Workqueue: iscsi_q_0 iscsi_xmitworker [ 24.158883] RIP: 0010:apparmor_socket_sendmsg+0x5/0x20 [...] [ 24.161739] RSP: 0018:ffffab6440043ca0 EFLAGS: 00010282 [ 24.162400] RAX: ffffffff891c1c00 RBX: ffffffff89d53968 RCX: 0000000000000001 [ 24.163253] RDX: 0000000000000030 RSI: ffffab6440043d00 RDI: 0000000000000000 [ 24.164104] RBP: 0000000000000030 R08: 0000000000000030 R09: 0000000000000030 [ 24.165166] R10: ffffffff893e66a0 R11: 0000000000000018 R12: ffffab6440043d00 [ 24.166038] R13: 0000000000000000 R14: 0000000000000000 R15: ffff9d5575a62e90 [ 24.166919] FS: 0000000000000000(0000) GS:ffff9d557db80000(0000) knlGS:0000000000000000 [ 24.167890] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 24.168587] CR2: 0000000000000018 CR3: 000000007a838000 CR4: 00000000000006e0 [ 24.169451] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 24.170320] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 24.171214] Call Trace: [ 24.171537] security_socket_sendmsg+0x3a/0x50 [ 24.172079] sock_sendmsg+0x16/0x60 [ 24.172506] iscsi_sw_tcp_xmit_segment+0x77/0x120 [ 24.173076] iscsi_sw_tcp_pdu_xmit+0x58/0x170 [ 24.173604] ? iscsi_dbg_trace+0x63/0x80 [ 24.174087] iscsi_tcp_task_xmit+0x101/0x280 [ 24.174666] iscsi_xmit_task+0x83/0x110 [ 24.175206] iscsi_xmitworker+0x57/0x380 [ 24.175757] ? __schedule+0x2a2/0x700 [ 24.176273] process_one_work+0x1b5/0x360 [ 24.176837] worker_thread+0x50/0x3c0 [ 24.177353] kthread+0xf9/0x130 [ 24.177799] ? process_one_work+0x360/0x360 [ 24.178401] ? kthread_park+0x90/0x90 [ 24.178915] ret_from_fork+0x35/0x40 [ 24.179421] Modules linked in: [ 24.179856] CR2: 0000000000000018 [ 24.180327] ---[ end trace b4b7674b6df5f480 ]--- Signed-off-by: Anatol Pomazau <anatol@google.com> Co-developed-by: Frank Mayhar <fmayhar@google.com> Signed-off-by: Frank Mayhar <fmayhar@google.com> Co-developed-by: Bharath Ravi <rbharath@google.com> Signed-off-by: Bharath Ravi <rbharath@google.com> Co-developed-by: Khazhimsel Kumykov <khazhy@google.com> Signed-off-by: Khazhimsel Kumykov <khazhy@google.com> Co-developed-by: Gabriel Krisman Bertazi <krisman@collabora.com> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> Reviewed-by: Lee Duncan <lduncan@suse.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2019-11-19 21:37:35 -05:00
..
accessibility
acpi	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
amba	ARM updates for 5.4-rc1:	2019-09-22 09:39:09 -07:00
android
ata	scsi: core: Clean up SG_NONE	2019-11-12 22:21:35 -05:00
atm	atm: he: clean up an indentation issue	2019-09-25 13:54:45 +02:00
auxdisplay	It's a somewhat calmer cycle for docs this time, as the churn of the mass	2019-09-17 16:22:26 -07:00
base	mm,thp: stats for file backed THP	2019-09-24 15:54:11 -07:00
bcma	bcma: make arrays pwr_info_offset and sprom_sizes static const, shrinks object size	2019-09-13 16:44:49 +03:00
block	Merge branch 'akpm' (patches from Andrew)	2019-09-26 10:29:42 -07:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-15 14:17:27 +02:00
bus	ARM: SoC fixes	2019-09-30 10:04:28 -07:00
cdrom
char	Merge branch 'entropy'	2019-09-29 19:25:39 -07:00
clk	ARM SCMI fixes for v5.4	2019-09-29 11:20:41 -07:00
clocksource	Main MIPS changes for v5.4:	2019-09-22 09:30:30 -07:00
connector
counter
cpufreq	Power management updates for 5.4-rc1	2019-09-17 19:15:14 -07:00
cpuidle	Power management updates for 5.4-rc1	2019-09-17 19:15:14 -07:00
crypto	Merge branch 'akpm' (patches from Andrew)	2019-09-24 16:10:23 -07:00
dax
dca
devfreq
dio
dma	Main MIPS changes for v5.4:	2019-09-22 09:30:30 -07:00
dma-buf
edac	ARM updates for 5.4-rc1:	2019-09-22 09:39:09 -07:00
eisa
extcon	chrome platform changes for v5.4	2019-09-19 14:14:28 -07:00
firewire
firmware	ARM: SoC fixes	2019-09-30 10:04:28 -07:00
fpga	Char/Misc driver patches for 5.4-rc1	2019-09-18 11:14:31 -07:00
fsi
gnss
gpio	pwm: Changes for v5.4-rc1	2019-09-27 12:19:47 -07:00
gpu	drm fixes for 5.4-rc1	2019-09-27 11:13:35 -07:00
greybus
hid	- First round of vmbus hibernation support from Dexuan Cui.	2019-09-24 12:36:31 -07:00
hsi	HSI changes for the 5.4 series	2019-09-22 12:02:21 -07:00
hv	- First round of vmbus hibernation support from Dexuan Cui.	2019-09-24 12:36:31 -07:00
hwmon	ARM SCMI fixes for v5.4	2019-09-29 11:20:41 -07:00
hwspinlock
hwtracing	Char/Misc driver patches for 5.4-rc1	2019-09-18 11:14:31 -07:00
i2c	i2c: slave-eeprom: Add read only mode	2019-09-28 20:44:12 +02:00
i3c
ide
idle
iio	chrome platform changes for v5.4	2019-09-19 14:14:28 -07:00
infiniband	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-28 17:47:33 -07:00
input	chrome platform changes for v5.4	2019-09-19 14:14:28 -07:00
interconnect
iommu	IOMMU Fixes for Linux v5.4-rc1	2019-09-29 10:00:14 -07:00
ipack
irqchip	Main MIPS changes for v5.4:	2019-09-22 09:30:30 -07:00
isdn	mISDN: enforce CAP_NET_RAW for raw sockets	2019-09-24 16:37:18 +02:00
leds	leds: lm3532: Fix optional led-max-microamp prop error handling	2019-09-12 20:45:52 +02:00
lightnvm	lightnvm: print error when target is not found	2019-09-05 13:17:01 -06:00
macintosh
mailbox	mailbox: qcom-apcs: fix max_register value	2019-09-17 00:54:29 -05:00
mcb
md	for-5.4/post-2019-09-24	2019-09-24 16:31:50 -07:00
media	media/v4l2-core: untag user pointers in videobuf_dma_contig_user_get	2019-09-25 17:51:41 -07:00
memory
memstick	ms_block: fix spelling mistake "randomally" -> "randomly"	2019-09-11 16:11:01 +02:00
message
mfd	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal	2019-09-29 10:24:23 -07:00
misc	Merge branch 'i2c/for-5.4' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2019-09-24 16:48:02 -07:00
mmc	mmc: host: sdhci-pci: Add Genesys Logic GL975x support	2019-09-27 20:48:20 +02:00
mtd	Main MIPS changes for v5.4:	2019-09-22 09:30:30 -07:00
mux
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-28 17:47:33 -07:00
nfc	NFC: st95hf: clean up indentation issue	2019-09-27 20:31:18 +02:00
ntb	NTB: fix IDT Kconfig typos/spellos	2019-09-23 17:20:40 -04:00
nubus
nvdimm	libnvdimm fixes v5.4-rc1	2019-09-29 10:33:41 -07:00
nvme	for-5.4/post-2019-09-24	2019-09-24 16:31:50 -07:00
nvmem	Char/Misc driver patches for 5.4-rc1	2019-09-18 11:14:31 -07:00
of	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-28 17:47:33 -07:00
opp
oprofile
parisc	dma-mapping updates for 5.4:	2019-09-19 13:27:23 -07:00
parport	Char/Misc driver patches for 5.4-rc1	2019-09-18 11:14:31 -07:00
pci	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
pcmcia	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
perf
phy	pci-v5.4-changes	2019-09-23 19:16:01 -07:00
pinctrl	This is the bulk of pin control changes for the v5.4 kernel	2019-09-19 14:19:33 -07:00
platform	platform-drivers-x86 for v5.4-2	2019-09-24 12:39:40 -07:00
pnp
power	power supply and reset changes for the v5.4 series	2019-09-22 12:04:59 -07:00
powercap	Power management updates for 5.4-rc1	2019-09-17 19:15:14 -07:00
pps
ps3
ptp	ptp: correctly disable flags on old ioctls	2019-09-27 20:25:32 +02:00
pwm	pwm: Changes for v5.4-rc1	2019-09-27 12:19:47 -07:00
rapidio
ras
regulator	LED updates for 5.4-rc1	2019-09-17 18:40:42 -07:00
remoteproc	remoteproc updates for v5.4	2019-09-22 10:55:08 -07:00
reset	ARM: SoC fixes	2019-09-30 10:04:28 -07:00
rpmsg	rpmsg: glink-smem: Name the edge based on parent remoteproc	2019-09-17 15:33:31 -07:00
rtc	RTC for 5.4	2019-09-22 11:05:43 -07:00
s390	scsi: zfcp: trace channel log even for FCP command responses	2019-10-28 22:16:15 -04:00
sbus
scsi	scsi: iscsi: Don't send data to unbound connection	2019-11-19 21:37:35 -05:00
sfi
sh
siox
slimbus
soc	ARM: SoC driver updates for v5.4	2019-09-16 15:52:38 -07:00
soundwire	soundwire updates for v5.4-rc1	2019-09-22 10:52:23 -07:00
spi	LED updates for 5.4-rc1	2019-09-17 18:40:42 -07:00
spmi
ssb	ssb: make array pwr_info_offset static const, makes object smaller	2019-09-13 17:23:18 +03:00
staging	mm: introduce page_size()	2019-09-24 15:54:08 -07:00
target	scsi: target: iscsi: Wait for all commands to finish before freeing a session	2019-11-19 21:37:35 -05:00
tc
tee	tee/shm: untag user pointers in tee_shm_register	2019-09-25 17:51:41 -07:00
thermal	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal	2019-09-29 10:24:23 -07:00
thunderbolt
tty	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
uio	Char/Misc driver patches for 5.4-rc1	2019-09-18 11:14:31 -07:00
usb	scsi: core: Clean up SG_NONE	2019-11-12 22:21:35 -05:00
vfio	vfio/type1: untag user pointers in vaddr_get_pfn	2019-09-25 17:51:41 -07:00
vhost	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-15 14:17:27 +02:00
video	- Core Frameworks	2019-09-23 19:33:56 -07:00
virt
virtio	virtio_ring: fix unmap of indirect descriptors	2019-09-09 10:43:15 -04:00
visorbus
vlynq
vme
w1
watchdog	linux-watchdog 5.4-rc1 tag	2019-09-27 11:17:38 -07:00
xen	xen: features for 5.4-rc1	2019-09-26 11:22:14 -07:00
zorro
Kconfig	Staging/IIO driver patches for 5.4-rc1	2019-09-18 11:05:34 -07:00
Makefile	Staging/IIO driver patches for 5.4-rc1	2019-09-18 11:05:34 -07:00