forked from Minki/linux
94dfc73e7c
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
This code was transformed with the help of Coccinelle:
(linux-5.19-rc2$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file script.cocci --include-headers --dir . > output.patch)
@@
identifier S, member, array;
type T1, T2;
@@
struct S {
...
T1 member;
T2 array[
- 0
];
};
-fstrict-flex-arrays=3 is coming and we need to land these changes
to prevent issues like these in the short future:
../fs/minix/dir.c:337:3: warning: 'strcpy' will always overflow; destination buffer has size 0,
but the source string has length 2 (including NUL byte) [-Wfortify-source]
strcpy(de3->name, ".");
^
Since these are all [0] to [] changes, the risk to UAPI is nearly zero. If
this breaks anything, we can use a union with a new member name.
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Build-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/62b675ec.wKX6AOZ6cbE71vtF%25lkp@intel.com/
Acked-by: Dan Williams <dan.j.williams@intel.com> # For ndctl.h
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
78 lines
1.9 KiB
C
78 lines
1.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
|
|
/*
|
|
* Copyright (C) 2007, 2008 Karsten Wiese <fzu@wemgehoertderstaat.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
|
|
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software Foundation,
|
|
* Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#ifndef _UAPI__SOUND_USB_STREAM_H
|
|
#define _UAPI__SOUND_USB_STREAM_H
|
|
|
|
#define USB_STREAM_INTERFACE_VERSION 2
|
|
|
|
#define SNDRV_USB_STREAM_IOCTL_SET_PARAMS \
|
|
_IOW('H', 0x90, struct usb_stream_config)
|
|
|
|
struct usb_stream_packet {
|
|
unsigned offset;
|
|
unsigned length;
|
|
};
|
|
|
|
|
|
struct usb_stream_config {
|
|
unsigned version;
|
|
unsigned sample_rate;
|
|
unsigned period_frames;
|
|
unsigned frame_size;
|
|
};
|
|
|
|
struct usb_stream {
|
|
struct usb_stream_config cfg;
|
|
unsigned read_size;
|
|
unsigned write_size;
|
|
|
|
int period_size;
|
|
|
|
unsigned state;
|
|
|
|
int idle_insize;
|
|
int idle_outsize;
|
|
int sync_packet;
|
|
unsigned insize_done;
|
|
unsigned periods_done;
|
|
unsigned periods_polled;
|
|
|
|
struct usb_stream_packet outpacket[2];
|
|
unsigned inpackets;
|
|
unsigned inpacket_head;
|
|
unsigned inpacket_split;
|
|
unsigned inpacket_split_at;
|
|
unsigned next_inpacket_split;
|
|
unsigned next_inpacket_split_at;
|
|
struct usb_stream_packet inpacket[];
|
|
};
|
|
|
|
enum usb_stream_state {
|
|
usb_stream_invalid,
|
|
usb_stream_stopped,
|
|
usb_stream_sync0,
|
|
usb_stream_sync1,
|
|
usb_stream_ready,
|
|
usb_stream_running,
|
|
usb_stream_xrun,
|
|
};
|
|
|
|
#endif /* _UAPI__SOUND_USB_STREAM_H */
|