linux/drivers/scsi/fnic
Gustavo A. R. Silva 5febf6d6ae scsi: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare variable-length
types such as these ones is a flexible array member[1][2], introduced in
C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by this
change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Link: https://lore.kernel.org/r/20200224161406.GA21454@embeddedor
Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Satish Kharat <satishkh@cisco.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-03-11 23:07:56 -04:00
..
cq_desc.h
cq_enet_desc.h
cq_exch_desc.h
fcpio.h
fnic_attrs.c
fnic_debugfs.c scsi: fnic: remove redundant assignment of variable rc 2019-08-19 21:51:00 -04:00
fnic_fcs.c scsi: fnic: print port speed only at driver init or speed change 2019-08-30 03:32:35 -04:00
fnic_fip.h
fnic_io.h scsi: fnic: support to display 20G port speed 2019-01-22 21:18:33 -05:00
fnic_isr.c scsi: fnic: fix msix interrupt allocation 2019-09-07 15:29:12 -04:00
fnic_main.c scsi: fnic: no need to check return value of debugfs_create functions 2019-01-29 00:40:53 -05:00
fnic_res.c
fnic_res.h
fnic_scsi.c scsi: fnic: do not queue commands during fwreset 2020-01-20 23:58:14 -05:00
fnic_stats.h scsi: fnic: no need to check return value of debugfs_create functions 2019-01-29 00:40:53 -05:00
fnic_trace.c scsi: fnic: print port speed only at driver init or speed change 2019-08-30 03:32:35 -04:00
fnic_trace.h scsi: fnic: no need to check return value of debugfs_create functions 2019-01-29 00:40:53 -05:00
fnic.h scsi: fnic: Update fnic driver version to 1.6.0.47 2019-01-22 21:18:35 -05:00
Makefile
rq_enet_desc.h
vnic_cq_copy.h
vnic_cq.c
vnic_cq.h
vnic_dev.c scsi: fnic: fix invalid stack access 2020-01-15 22:59:59 -05:00
vnic_dev.h scsi: fnic: Enable fnic devcmd2 interface 2019-01-22 21:18:35 -05:00
vnic_devcmd.h scsi: Replace zero-length array with flexible-array member 2020-03-11 23:07:56 -04:00
vnic_intr.c
vnic_intr.h
vnic_nic.h
vnic_resource.h scsi: fnic: fnic devcmd2 interface definitions 2019-01-22 21:18:34 -05:00
vnic_rq.c scsi: fnic: Remove set but not used variable 'vdev' 2019-01-29 01:16:09 -05:00
vnic_rq.h
vnic_scsi.h
vnic_stats.h
vnic_wq_copy.c
vnic_wq_copy.h
vnic_wq.c scsi: fnic: Remove set but not used variable 'vdev' 2019-01-29 01:16:09 -05:00
vnic_wq.h scsi: fnic: Add devcmd2 initialization helpers 2019-01-22 21:18:34 -05:00
wq_enet_desc.h