forked from Minki/linux
8a7c6f859a
Currently, you cannot ovewrwrite what's in your kunitconfig via --kconfig_add. Nor can you override something in a qemu_config via either means. This patch makes it so we have this level of priority * --kconfig_add * kunitconfig file (the default or the one from --kunitconfig) * qemu_config The rationale for this order is that the more "dynamic" sources of kconfig options should take priority. --kconfig_add is obviously the most dynamic. And for kunitconfig, users probably tweak the file manually or specify --kunitconfig more often than they delve into qemu_config python files. And internally, we convert the kconfigs from a python list into a set or dict fairly often. We should just use a dict internally. We exposed the set transform in the past since we didn't define __eq__, so also take the chance to shore up the kunit_kconfig.Kconfig interface. Example ======= Let's consider the unrealistic example where someone would want to disable CONFIG_KUNIT. I.e. they run $ ./tools/testing/kunit/kunit.py config --kconfig_add=CONFIG_KUNIT=n Before ------ We'd write the following > # CONFIG_KUNIT is not set > CONFIG_KUNIT_ALL_TESTS=y > CONFIG_KUNIT_TEST=y > CONFIG_KUNIT=y > CONFIG_KUNIT_EXAMPLE_TEST=y And we'd error out with > ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. > This is probably due to unsatisfied dependencies. > Missing: # CONFIG_KUNIT is not set After ----- We'd write the following > # CONFIG_KUNIT is not set > CONFIG_KUNIT_TEST=y > CONFIG_KUNIT_ALL_TESTS=y > CONFIG_KUNIT_EXAMPLE_TEST=y And we'd error out with > ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. > This is probably due to unsatisfied dependencies. > Missing: CONFIG_KUNIT_EXAMPLE_TEST=y, CONFIG_KUNIT_TEST=y, CONFIG_KUNIT_ALL_TESTS=y Signed-off-by: Daniel Latypov <dlatypov@google.com> Reviewed-by: David Gow <davidgow@google.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
100 lines
2.5 KiB
Python
100 lines
2.5 KiB
Python
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Builds a .config from a kunitconfig.
|
|
#
|
|
# Copyright (C) 2019, Google LLC.
|
|
# Author: Felix Guo <felixguoxiuping@gmail.com>
|
|
# Author: Brendan Higgins <brendanhiggins@google.com>
|
|
|
|
from dataclasses import dataclass
|
|
import re
|
|
from typing import Dict, Iterable, Set
|
|
|
|
CONFIG_IS_NOT_SET_PATTERN = r'^# CONFIG_(\w+) is not set$'
|
|
CONFIG_PATTERN = r'^CONFIG_(\w+)=(\S+|".*")$'
|
|
|
|
@dataclass(frozen=True)
|
|
class KconfigEntry:
|
|
name: str
|
|
value: str
|
|
|
|
def __str__(self) -> str:
|
|
if self.value == 'n':
|
|
return f'# CONFIG_{self.name} is not set'
|
|
return f'CONFIG_{self.name}={self.value}'
|
|
|
|
|
|
class KconfigParseError(Exception):
|
|
"""Error parsing Kconfig defconfig or .config."""
|
|
|
|
|
|
class Kconfig:
|
|
"""Represents defconfig or .config specified using the Kconfig language."""
|
|
|
|
def __init__(self) -> None:
|
|
self._entries = {} # type: Dict[str, str]
|
|
|
|
def __eq__(self, other) -> bool:
|
|
if not isinstance(other, self.__class__):
|
|
return False
|
|
return self._entries == other._entries
|
|
|
|
def __repr__(self) -> str:
|
|
return ','.join(str(e) for e in self.as_entries())
|
|
|
|
def as_entries(self) -> Iterable[KconfigEntry]:
|
|
for name, value in self._entries.items():
|
|
yield KconfigEntry(name, value)
|
|
|
|
def add_entry(self, name: str, value: str) -> None:
|
|
self._entries[name] = value
|
|
|
|
def is_subset_of(self, other: 'Kconfig') -> bool:
|
|
for name, value in self._entries.items():
|
|
b = other._entries.get(name)
|
|
if b is None:
|
|
if value == 'n':
|
|
continue
|
|
return False
|
|
if value != b:
|
|
return False
|
|
return True
|
|
|
|
def merge_in_entries(self, other: 'Kconfig') -> None:
|
|
for name, value in other._entries.items():
|
|
self._entries[name] = value
|
|
|
|
def write_to_file(self, path: str) -> None:
|
|
with open(path, 'a+') as f:
|
|
for e in self.as_entries():
|
|
f.write(str(e) + '\n')
|
|
|
|
def parse_file(path: str) -> Kconfig:
|
|
with open(path, 'r') as f:
|
|
return parse_from_string(f.read())
|
|
|
|
def parse_from_string(blob: str) -> Kconfig:
|
|
"""Parses a string containing Kconfig entries."""
|
|
kconfig = Kconfig()
|
|
is_not_set_matcher = re.compile(CONFIG_IS_NOT_SET_PATTERN)
|
|
config_matcher = re.compile(CONFIG_PATTERN)
|
|
for line in blob.split('\n'):
|
|
line = line.strip()
|
|
if not line:
|
|
continue
|
|
|
|
match = config_matcher.match(line)
|
|
if match:
|
|
kconfig.add_entry(match.group(1), match.group(2))
|
|
continue
|
|
|
|
empty_match = is_not_set_matcher.match(line)
|
|
if empty_match:
|
|
kconfig.add_entry(empty_match.group(1), 'n')
|
|
continue
|
|
|
|
if line[0] == '#':
|
|
continue
|
|
raise KconfigParseError('Failed to parse: ' + line)
|
|
return kconfig
|