forked from Minki/linux
1cada2f307
The hierarchical parts of MSM pinctrl/GPIO is only
used when the device tree has a "wakeup-parent" as
a phandle, but the .irq_eoi is anyway assigned leading
to semantic problems on elder Qualcomm chipsets.
When the drivers/mfd/qcom-pm8xxx.c driver calls
chained_irq_exit() that call will in turn call chip->irq_eoi()
which is set to irq_chip_eoi_parent() by default on a
hierachical IRQ chip, and the parent is pinctrl-msm.c
so that will in turn unconditionally call
irq_chip_eoi_parent() again, but its parent is invalid
so we get the following crash:
Unnable to handle kernel NULL pointer dereference at
virtual address 00000010
pgd = (ptrval)
[00000010] *pgd=00000000
Internal error: Oops: 5 [#1] PREEMPT SMP ARM
(...)
PC is at irq_chip_eoi_parent+0x4/0x10
LR is at pm8xxx_irq_handler+0x1b4/0x2d8
If we solve this crash by avoiding to call up to
irq_chip_eoi_parent(), the machine will hang and get
reset by the watchdog, because of semantic issues,
probably inside irq_chip.
As a solution, just assign the .irq_eoi conditionally if
we are actually using a wakeup parent.
Cc: David Heidelberg <david@ixit.cz>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Lina Iyer <ilina@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: stable@vger.kernel.org
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| pinctrl-apq8064.c | ||
| pinctrl-apq8084.c | ||
| pinctrl-ipq4019.c | ||
| pinctrl-ipq8064.c | ||
| pinctrl-ipq8074.c | ||
| pinctrl-mdm9615.c | ||
| pinctrl-msm8x74.c | ||
| pinctrl-msm8660.c | ||
| pinctrl-msm8916.c | ||
| pinctrl-msm8960.c | ||
| pinctrl-msm8976.c | ||
| pinctrl-msm8994.c | ||
| pinctrl-msm8996.c | ||
| pinctrl-msm8998.c | ||
| pinctrl-msm.c | ||
| pinctrl-msm.h | ||
| pinctrl-qcs404.c | ||
| pinctrl-qdf2xxx.c | ||
| pinctrl-sc7180.c | ||
| pinctrl-sdm660.c | ||
| pinctrl-sdm845.c | ||
| pinctrl-sm8150.c | ||
| pinctrl-spmi-gpio.c | ||
| pinctrl-spmi-mpp.c | ||
| pinctrl-ssbi-gpio.c | ||
| pinctrl-ssbi-mpp.c | ||