leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
1c167b87f4f9c89e33dcffb92a45e30f937f04d6
linux/fs/btrfs
History
Filipe Manana 1c167b87f4 btrfs: remove unnecessary NULL check for the new inode during rename exchange 
At the very end of btrfs_rename_exchange(), in case an error happened, we
are checking if 'new_inode' is NULL, but that is not needed since during a
rename exchange, unlike regular renames, 'new_inode' can never be NULL,
and if it were, we would have a crashed much earlier when we dereference it
multiple times.

So remove the check because it is not necessary and because it is causing
static checkers to emit a warning. I probably introduced the check by
copy-pasting similar code from btrfs_rename(), where 'new_inode' can be
NULL, in commit 86e8aa0e77 ("Btrfs: unpin logs if rename exchange
operation fails").

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
2021-08-23 13:19:10 +02:00
..
tests
btrfs: remove ignore_offset argument from btrfs_find_all_roots()
2021-08-23 13:19:01 +02:00
acl.c
fs: make helpers idmap mount aware
2021-01-24 14:27:20 +01:00
async-thread.c
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-03-23 17:01:51 +01:00
async-thread.h
Btrfs: fix crash during unmount due to race with delayed inode workers
2020-03-23 17:01:51 +01:00
backref.c
btrfs: remove ignore_offset argument from btrfs_find_all_roots()
2021-08-23 13:19:01 +02:00
backref.h
btrfs: remove ignore_offset argument from btrfs_find_all_roots()
2021-08-23 13:19:01 +02:00
block-group.c
btrfs: rescue: allow ibadroots to skip bad extent tree when reading block group items
2021-08-23 13:19:00 +02:00
block-group.h
btrfs: rework chunk allocation to avoid exhaustion of the system chunk array
2021-07-07 17:42:41 +02:00
block-rsv.c
btrfs: introduce mount option rescue=ignorebadroots
2020-12-08 15:53:41 +01:00
block-rsv.h
btrfs: Remove __ prefix from btrfs_block_rsv_release
2020-03-23 17:01:55 +01:00
btrfs_inode.h
btrfs: initial fsverity support
2021-08-23 13:19:09 +02:00
check-integrity.c
btrfs: check-integrity: drop kmap/kunmap for block pages
2021-08-23 13:19:00 +02:00
check-integrity.h
btrfs: remove btrfsic_submit_bh()
2020-03-23 17:01:39 +01:00
compression.c
btrfs: rework btrfs_decompress_buf2page()
2021-08-23 13:19:04 +02:00
compression.h
btrfs: rework btrfs_decompress_buf2page()
2021-08-23 13:19:04 +02:00
ctree.c
btrfs: introduce btrfs_search_backwards function
2021-08-23 13:19:09 +02:00
ctree.h
btrfs: introduce btrfs_search_backwards function
2021-08-23 13:19:09 +02:00
delalloc-space.c
btrfs: fix typos in comments
2021-06-22 14:11:57 +02:00
delalloc-space.h
btrfs: make btrfs_delalloc_reserve_space take btrfs_inode
2020-07-27 12:55:36 +02:00
delayed-inode.c
btrfs: add ro compat flags to inodes
2021-08-23 13:19:09 +02:00
delayed-inode.h
btrfs: make btrfs_delayed_update_inode take btrfs_inode
2020-12-08 15:54:10 +01:00
delayed-ref.c
btrfs: fix lock inversion problem when doing qgroup extent tracing
2021-07-22 15:50:07 +02:00
delayed-ref.h
btrfs: only let one thread pre-flush delayed refs in commit
2021-02-08 22:58:56 +01:00
dev-replace.c
btrfs: fix typos in comments
2021-06-22 14:11:57 +02:00
dev-replace.h
btrfs: zoned: mark block groups to copy for device-replace
2021-02-09 02:46:07 +01:00
dir-item.c
btrfs: introduce btrfs_lookup_match_dir
2021-08-23 13:19:02 +02:00
discard.c
btrfs: fix typos in comments
2021-06-22 14:11:57 +02:00
discard.h
btrfs: cleanup btrfs_discard_update_discardable usage
2020-12-08 15:54:02 +01:00
disk-io.c
btrfs: allow read-write for 4K sectorsize on 64K page size systems
2021-08-23 13:19:06 +02:00
disk-io.h
btrfs: split alloc_log_tree()
2021-02-09 02:46:07 +01:00
export.c
btrfs: locking: rip out path->leave_spinning
2020-12-08 15:54:02 +01:00
export.h
btrfs: export helpers for subvolume name/id resolution
2020-03-23 17:01:42 +01:00
extent_io.c
btrfs: initial fsverity support
2021-08-23 13:19:09 +02:00
extent_io.h
btrfs: fix argument type of btrfs_bio_clone_partial()
2021-08-23 13:19:08 +02:00
extent_map.c
btrfs: fix parameter description of btrfs_add_extent_mapping
2021-02-08 22:58:53 +01:00
extent_map.h
btrfs: remove extent_map::bdev
2019-11-18 23:43:44 +01:00
extent-io-tree.h
btrfs: use fixed width int type for extent_state::state
2020-12-08 15:54:13 +01:00
extent-tree.c
btrfs: pass NULL as trans to btrfs_search_slot if we only want to search
2021-08-23 13:19:00 +02:00
file-item.c
btrfs: remove unneeded return variable in btrfs_lookup_file_extent
2021-08-23 13:19:01 +02:00
file.c
btrfs: initial fsverity support
2021-08-23 13:19:09 +02:00
free-space-cache.c
btrfs: allocate file_ra_state on stack in readahead_cache
2021-08-23 13:19:10 +02:00
free-space-cache.h
btrfs: zoned: track unusable bytes for zones
2021-02-09 02:46:03 +01:00
free-space-tree.c
btrfs: fix possible free space tree corruption with online conversion
2021-01-25 18:44:37 +01:00
free-space-tree.h
btrfs: rename btrfs_block_group_cache
2019-11-18 17:51:51 +01:00
inode-item.c
btrfs: locking: rip out path->leave_spinning
2020-12-08 15:54:02 +01:00
inode.c
btrfs: remove unnecessary NULL check for the new inode during rename exchange
2021-08-23 13:19:10 +02:00
ioctl.c
btrfs: allocate btrfs_ioctl_defrag_range_args on stack
2021-08-23 13:19:10 +02:00
Kconfig
btrfs: disable build on platforms having page size 256K
2021-06-22 14:11:57 +02:00
locking.c
btrfs: fix typos in comments
2021-06-22 14:11:57 +02:00
locking.h
btrfs: remove the recurse parameter from __btrfs_tree_read_lock
2020-12-08 15:54:09 +01:00
lzo.c
btrfs: rework lzo_decompress_bio() to make it subpage compatible
2021-08-23 13:19:04 +02:00
Makefile
btrfs: initial fsverity support
2021-08-23 13:19:09 +02:00
misc.h
btrfs: rename tree_entry to rb_simple_node and export it
2020-05-25 11:25:19 +02:00
ordered-data.c
btrfs: remove uptodate parameter from btrfs_dec_test_first_ordered_pending
2021-08-23 13:19:02 +02:00
ordered-data.h
btrfs: remove uptodate parameter from btrfs_dec_test_first_ordered_pending
2021-08-23 13:19:02 +02:00
orphan.c
…
print-tree.c
btrfs: print the actual offset in btrfs_root_name
2021-01-07 17:25:05 +01:00
print-tree.h
btrfs: print the actual offset in btrfs_root_name
2021-01-07 17:25:05 +01:00
props.c
btrfs: props: change how empty value is interpreted
2021-06-22 14:11:58 +02:00
props.h
btrfs: delete unused function btrfs_set_prop_trans
2019-04-29 19:02:54 +02:00
qgroup.c
btrfs: remove ignore_offset argument from btrfs_find_all_roots()
2021-08-23 13:19:01 +02:00
qgroup.h
btrfs: fix lock inversion problem when doing qgroup extent tracing
2021-07-22 15:50:07 +02:00
raid56.c
btrfs: constify and cleanup variables in comparators
2021-08-23 13:19:03 +02:00
raid56.h
btrfs: constify map parameter for nr_parity_stripes and nr_data_stripes
2019-07-01 13:34:58 +02:00
rcu-string.h
btrfs: rcu-string: Replace zero-length array with flexible-array member
2020-03-23 17:01:53 +01:00
reada.c
btrfs: subpage: make readahead work properly
2021-03-16 11:06:21 +01:00
ref-verify.c
btrfs: stop doing GFP_KERNEL memory allocations in the ref verify tool
2021-08-23 13:19:00 +02:00
ref-verify.h
…
reflink.c
btrfs: reflink: make copy_inline_to_page() to be subpage compatible
2021-06-21 15:19:10 +02:00
reflink.h
Btrfs: move all reflink implementation code into its own file
2020-03-23 17:01:54 +01:00
relocation.c
btrfs: subpage: fix relocation potentially overwriting last page data
2021-08-23 13:19:06 +02:00
root-tree.c
btrfs: qgroup: fix qgroup meta rsv leak for subvolume operations
2020-10-07 12:12:13 +02:00
scrub.c
btrfs: fix typos in comments
2021-06-22 14:11:57 +02:00
send.c
btrfs: allocate backref_ctx on stack in find_extent_clone
2021-08-23 13:19:10 +02:00
send.h
btrfs: send: avoid copying file data
2020-10-07 12:13:17 +02:00
space-info.c
btrfs: wait on async extents when flushing delalloc
2021-08-23 13:19:07 +02:00
space-info.h
btrfs: rip out btrfs_space_info::total_bytes_pinned
2021-06-22 14:55:25 +02:00
struct-funcs.c
btrfs: add special case to setget helpers for 64k pages
2021-08-23 13:18:58 +02:00
subpage.c
btrfs: subpage: fix a potential use-after-free in writeback helper
2021-08-23 13:19:05 +02:00
subpage.h
btrfs: subpage: fix writeback which does not have ordered extent
2021-08-23 13:19:04 +02:00
super.c
btrfs: introduce btrfs_search_backwards function
2021-08-23 13:19:09 +02:00
sysfs.c
btrfs: initial fsverity support
2021-08-23 13:19:09 +02:00
sysfs.h
btrfs: split and refactor btrfs_sysfs_remove_devices_dir
2020-10-07 12:12:21 +02:00
transaction.c
btrfs: rework chunk allocation to avoid exhaustion of the system chunk array
2021-07-07 17:42:41 +02:00
transaction.h
btrfs: rework chunk allocation to avoid exhaustion of the system chunk array
2021-07-07 17:42:41 +02:00
tree-checker.c
btrfs: add ro compat flags to inodes
2021-08-23 13:19:09 +02:00
tree-checker.h
…
tree-defrag.c
btrfs: locking: remove all the blocking helpers
2020-12-08 15:54:01 +01:00
tree-log.c
btrfs: add ro compat flags to inodes
2021-08-23 13:19:09 +02:00
tree-log.h
btrfs: make fast fsyncs wait only for writeback
2020-10-07 12:06:56 +02:00
tree-mod-log.c
btrfs: fix race when picking most recent mod log operation for an old root
2021-04-20 19:27:17 +02:00
tree-mod-log.h
btrfs: add and use helper to get lowest sequence number for the tree mod log
2021-04-19 17:25:17 +02:00
ulist.c
…
ulist.h
…
uuid-tree.c
btrfs: remove unnecessary casts in printk
2020-12-08 15:53:52 +01:00
verity.c
btrfs: verity metadata orphan items
2021-08-23 13:19:09 +02:00
volumes.c
btrfs: introduce btrfs_search_backwards function
2021-08-23 13:19:09 +02:00
volumes.h
btrfs: uninline btrfs_bg_flags_to_raid_index
2021-08-23 13:19:03 +02:00
xattr.c
Merge tag 'for-5.12-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
2021-03-05 12:21:14 -08:00
xattr.h
…
zlib.c
btrfs: rework btrfs_decompress_buf2page()
2021-08-23 13:19:04 +02:00
zoned.c
btrfs: use btrfs_next_leaf instead of btrfs_next_item when slots > nritems
2021-08-23 13:19:01 +02:00
zoned.h
btrfs: zoned: remove max_zone_append_size logic
2021-08-23 13:18:58 +02:00
zstd.c
btrfs: rework btrfs_decompress_buf2page()
2021-08-23 13:19:04 +02:00