leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1af7e7f8c1
linux/drivers/net/wireless/realtek/rtlwifi
History
Ping-Ke Shih 4dfde294b9 rtlwifi: rise completion at the last step of firmware callback 
request_firmware_nowait() which schedules another work is used to load
firmware when USB is probing. If USB is unplugged before running the
firmware work, it goes disconnect ops, and then causes use-after-free.
Though we wait for completion of firmware work before freeing the hw,
firmware callback rises completion too early. So I move it to the
last step.

usb 5-1: Direct firmware load for rtlwifi/rtl8192cufw.bin failed with error -2
rtlwifi: Loading alternative firmware rtlwifi/rtl8192cufw.bin
rtlwifi: Selected firmware is not available
==================================================================
BUG: KASAN: use-after-free in rtl_fw_do_work.cold+0x68/0x6a drivers/net/wireless/realtek/rtlwifi/core.c:93
Write of size 4 at addr ffff8881454cff50 by task kworker/0:6/7379

CPU: 0 PID: 7379 Comm: kworker/0:6 Not tainted 5.10.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events request_firmware_work_func
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x107/0x163 lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xae/0x4c8 mm/kasan/report.c:385
 __kasan_report mm/kasan/report.c:545 [inline]
 kasan_report.cold+0x1f/0x37 mm/kasan/report.c:562
 rtl_fw_do_work.cold+0x68/0x6a drivers/net/wireless/realtek/rtlwifi/core.c:93
 request_firmware_work_func+0x12c/0x230 drivers/base/firmware_loader/main.c:1079
 process_one_work+0x933/0x1520 kernel/workqueue.c:2272
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2418
 kthread+0x38c/0x460 kernel/kthread.c:292
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:296

The buggy address belongs to the page:
page:00000000f54435b3 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1454cf
flags: 0x200000000000000()
raw: 0200000000000000 0000000000000000 ffffea00051533c8 0000000000000000
raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881454cfe00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
 ffff8881454cfe80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff8881454cff00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
                                                 ^
 ffff8881454cff80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
 ffff8881454d0000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

Reported-by: syzbot+65be4277f3c489293939@syzkaller.appspotmail.com
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201214053106.7748-1-pkshih@realtek.com
2020-12-17 18:37:47 +02:00
..
btcoexist rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables 2020-11-07 18:14:44 +02:00
rtl8188ee rtlwifi: rtl8188ee: avoid accessing the data mapped to streaming DMA 2020-11-24 17:06:34 +02:00
rtl8192c rtlwifi: Use ffs in <foo>_phy_calculate_bit_shift 2020-09-22 10:16:41 +03:00
rtl8192ce rtlwifi: rtl8192ce: avoid accessing the data mapped to streaming DMA 2020-11-24 17:06:35 +02:00
rtl8192cu rtlwifi: rtl8192cu: trx: Demote clear abuse of kernel-doc format 2020-11-07 18:14:35 +02:00
rtl8192de rtlwifi: rtl8192de: fix ofdm power compensation 2020-12-09 09:22:37 +02:00
rtl8192ee rtlwifi: rtl8192ee: use true,false for bool variable large_cfo_hit 2020-09-22 10:17:42 +03:00
rtl8192se rtlwifi: rtl8192se: remove duplicated legacy_httxpowerdiff 2020-10-08 13:47:14 +03:00
rtl8723ae rtlwifi: rtl8723ae: avoid accessing the data mapped to streaming DMA 2020-11-24 17:06:38 +02:00
rtl8723be rtlwifi: rtl8723be: Remove set but unused variable 'cck_highpwr' 2020-11-07 18:14:45 +02:00
rtl8723com rtlwifi: Use ffs in <foo>_phy_calculate_bit_shift 2020-09-22 10:16:41 +03:00
rtl8821ae rtlwifi: fix spelling typo of workaround 2020-11-10 20:56:34 +02:00
base.c net: rtlwifi: Replace in_interrupt() for context detection 2020-09-29 14:02:55 -07:00
base.h net: rtlwifi: Remove void* casts related to delayed work 2020-09-29 14:02:55 -07:00
cam.c rtlwifi: Replace RT_TRACE with rtl_dbg 2020-08-31 18:25:43 +03:00
cam.h rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
core.c rtlwifi: rise completion at the last step of firmware callback 2020-12-17 18:37:47 +02:00
core.h rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
debug.c net: rtlwifi: Remove in_interrupt() from debug macro 2020-09-29 14:02:55 -07:00
debug.h net: rtlwifi: Remove in_interrupt() from debug macro 2020-09-29 14:02:55 -07:00
efuse.c rtlwifi: Replace RT_TRACE with rtl_dbg 2020-08-31 18:25:43 +03:00
efuse.h rtlwifi: Remove CamelCase variables from base code 2019-02-19 17:02:51 +02:00
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
pci.c net: rtlwifi: Replace in_interrupt() for context detection 2020-09-29 14:02:55 -07:00
pci.h rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
ps.c net: rtlwifi: Replace in_interrupt() for context detection 2020-09-29 14:02:55 -07:00
ps.h net: rtlwifi: Replace in_interrupt() for context detection 2020-09-29 14:02:55 -07:00
pwrseqcmd.h rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
rc.c mac80211: populate debugfs only after cfg80211 init 2020-04-24 11:30:13 +02:00
rc.h rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
regd.c rtlwifi: Replace RT_TRACE with rtl_dbg 2020-08-31 18:25:43 +03:00
regd.h rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
stats.c rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
stats.h rtlwifi: Replace old-style license information 2019-02-19 16:59:43 +02:00
usb.c rtlwifi: Fix non-canonical address access issues 2020-11-07 17:49:57 +02:00
usb.h rtlwifi: Fix blank line errors in main header files 2019-02-28 10:30:01 +02:00
wifi.h rtlwifi: rtl8192se: remove duplicated legacy_httxpowerdiff 2020-10-08 13:47:14 +03:00