c601cb2135
Currently we shutdown rc6 during i915_gem_resume() but this is called
during the preparation phase (i915_drm_prepare) for all suspend paths,
but we only want to shutdown rc6 for S3+. Move the actual shutdown to
i915_gem_suspend_late().
We then need to differentiate between suspend targets, to distinguish S0
(s2idle) where the device is kept awake but needs to be in a low power
mode (the same as runtime suspend) from the device suspend levels where
we lose control of HW and so must disable any HW access to dangling
memory.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111909
Fixes: c113236718 ("drm/i915: Extract GT render sleep (rc6) management")
Testcase: igt/gem_exec_suspend/power-S0
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
Acked-by: Andi Shyti <andi.shyti@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191101141009.15581-4-chris@chris-wilson.co.uk
129 lines
3.4 KiB
C
129 lines
3.4 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#include "gem/i915_gem_pm.h"
|
|
#include "gt/intel_gt.h"
|
|
#include "gt/intel_gt_pm.h"
|
|
#include "gt/intel_gt_requests.h"
|
|
|
|
#include "i915_drv.h"
|
|
|
|
void i915_gem_suspend(struct drm_i915_private *i915)
|
|
{
|
|
GEM_TRACE("\n");
|
|
|
|
intel_wakeref_auto(&i915->ggtt.userfault_wakeref, 0);
|
|
flush_workqueue(i915->wq);
|
|
|
|
/*
|
|
* We have to flush all the executing contexts to main memory so
|
|
* that they can saved in the hibernation image. To ensure the last
|
|
* context image is coherent, we have to switch away from it. That
|
|
* leaves the i915->kernel_context still active when
|
|
* we actually suspend, and its image in memory may not match the GPU
|
|
* state. Fortunately, the kernel_context is disposable and we do
|
|
* not rely on its state.
|
|
*/
|
|
intel_gt_suspend_prepare(&i915->gt);
|
|
|
|
i915_gem_drain_freed_objects(i915);
|
|
}
|
|
|
|
static struct drm_i915_gem_object *first_mm_object(struct list_head *list)
|
|
{
|
|
return list_first_entry_or_null(list,
|
|
struct drm_i915_gem_object,
|
|
mm.link);
|
|
}
|
|
|
|
void i915_gem_suspend_late(struct drm_i915_private *i915)
|
|
{
|
|
struct drm_i915_gem_object *obj;
|
|
struct list_head *phases[] = {
|
|
&i915->mm.shrink_list,
|
|
&i915->mm.purge_list,
|
|
NULL
|
|
}, **phase;
|
|
unsigned long flags;
|
|
|
|
/*
|
|
* Neither the BIOS, ourselves or any other kernel
|
|
* expects the system to be in execlists mode on startup,
|
|
* so we need to reset the GPU back to legacy mode. And the only
|
|
* known way to disable logical contexts is through a GPU reset.
|
|
*
|
|
* So in order to leave the system in a known default configuration,
|
|
* always reset the GPU upon unload and suspend. Afterwards we then
|
|
* clean up the GEM state tracking, flushing off the requests and
|
|
* leaving the system in a known idle state.
|
|
*
|
|
* Note that is of the upmost importance that the GPU is idle and
|
|
* all stray writes are flushed *before* we dismantle the backing
|
|
* storage for the pinned objects.
|
|
*
|
|
* However, since we are uncertain that resetting the GPU on older
|
|
* machines is a good idea, we don't - just in case it leaves the
|
|
* machine in an unusable condition.
|
|
*/
|
|
|
|
intel_gt_suspend_late(&i915->gt);
|
|
|
|
spin_lock_irqsave(&i915->mm.obj_lock, flags);
|
|
for (phase = phases; *phase; phase++) {
|
|
LIST_HEAD(keep);
|
|
|
|
while ((obj = first_mm_object(*phase))) {
|
|
list_move_tail(&obj->mm.link, &keep);
|
|
|
|
/* Beware the background _i915_gem_free_objects */
|
|
if (!kref_get_unless_zero(&obj->base.refcount))
|
|
continue;
|
|
|
|
spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
|
|
|
|
i915_gem_object_lock(obj);
|
|
WARN_ON(i915_gem_object_set_to_gtt_domain(obj, false));
|
|
i915_gem_object_unlock(obj);
|
|
i915_gem_object_put(obj);
|
|
|
|
spin_lock_irqsave(&i915->mm.obj_lock, flags);
|
|
}
|
|
|
|
list_splice_tail(&keep, *phase);
|
|
}
|
|
spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
|
|
}
|
|
|
|
void i915_gem_resume(struct drm_i915_private *i915)
|
|
{
|
|
GEM_TRACE("\n");
|
|
|
|
intel_uncore_forcewake_get(&i915->uncore, FORCEWAKE_ALL);
|
|
|
|
if (intel_gt_init_hw(&i915->gt))
|
|
goto err_wedged;
|
|
|
|
/*
|
|
* As we didn't flush the kernel context before suspend, we cannot
|
|
* guarantee that the context image is complete. So let's just reset
|
|
* it and start again.
|
|
*/
|
|
if (intel_gt_resume(&i915->gt))
|
|
goto err_wedged;
|
|
|
|
out_unlock:
|
|
intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
|
|
return;
|
|
|
|
err_wedged:
|
|
if (!intel_gt_is_wedged(&i915->gt)) {
|
|
dev_err(i915->drm.dev,
|
|
"Failed to re-initialize GPU, declaring it wedged!\n");
|
|
intel_gt_set_wedged(&i915->gt);
|
|
}
|
|
goto out_unlock;
|
|
}
|