linux/drivers/net/wireless/intel/iwlegacy
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
3945-debug.c
3945-mac.c wireless: Set NL80211_EXT_FEATURE_CQM_RSSI_LIST in multiple drivers 2017-03-06 09:21:39 +01:00
3945-rs.c iwlegacy: remove usage of txrc->max_rate_idx 2017-03-07 09:42:11 +01:00
3945.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
3945.h
4965-calib.c
4965-debug.c
4965-mac.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
4965-rs.c iwlegacy: remove usage of txrc->max_rate_idx 2017-03-07 09:42:11 +01:00
4965.c cfg80211: remove enum ieee80211_band 2016-04-12 15:56:15 +02:00
4965.h cfg80211: remove enum ieee80211_band 2016-04-12 15:56:15 +02:00
commands.h
common.c iwlegacy: warn when enabling power save 2017-05-24 16:43:11 +03:00
common.h iwlegacy: warn when enabling power save 2017-05-24 16:43:11 +03:00
csr.h
debug.c cfg80211: remove enum ieee80211_band 2016-04-12 15:56:15 +02:00
iwl-spectrum.h
Kconfig
Makefile Makefile: drop -D__CHECK_ENDIAN__ from cflags 2016-12-16 00:13:43 +02:00
prph.h