forked from Minki/linux
fdeba99b1e
Syzbot has reported those issues as: ================================================================== BUG: KASAN: use-after-free in tipc_bcast_get_mode+0x3ab/0x400 net/tipc/bcast.c:759 Read of size 1 at addr ffff88805e6b3571 by task kworker/0:6/3850 CPU: 0 PID: 3850 Comm: kworker/0:6 Not tainted 5.8.0-rc7-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: events tipc_net_finalize_work Thread 1's call trace: [...] kfree+0x103/0x2c0 mm/slab.c:3757 <- bcbase releasing tipc_bcast_stop+0x1b0/0x2f0 net/tipc/bcast.c:721 tipc_exit_net+0x24/0x270 net/tipc/core.c:112 [...] Thread 2's call trace: [...] tipc_bcast_get_mode+0x3ab/0x400 net/tipc/bcast.c:759 <- bcbase has already been freed by Thread 1 tipc_node_broadcast+0x9e/0xcc0 net/tipc/node.c:1744 tipc_nametbl_publish+0x60b/0x970 net/tipc/name_table.c:752 tipc_net_finalize net/tipc/net.c:141 [inline] tipc_net_finalize+0x1fa/0x310 net/tipc/net.c:131 tipc_net_finalize_work+0x55/0x80 net/tipc/net.c:150 [...] ================================================================== BUG: KASAN: use-after-free in tipc_named_reinit+0xef/0x290 net/tipc/name_distr.c:344 Read of size 8 at addr ffff888052ab2000 by task kworker/0:13/30628 CPU: 0 PID: 30628 Comm: kworker/0:13 Not tainted 5.8.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: events tipc_net_finalize_work Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1f0/0x31e lib/dump_stack.c:118 print_address_description+0x66/0x5a0 mm/kasan/report.c:383 __kasan_report mm/kasan/report.c:513 [inline] kasan_report+0x132/0x1d0 mm/kasan/report.c:530 tipc_named_reinit+0xef/0x290 net/tipc/name_distr.c:344 tipc_net_finalize+0x85/0xe0 net/tipc/net.c:138 tipc_net_finalize_work+0x50/0x70 net/tipc/net.c:150 process_one_work+0x789/0xfc0 kernel/workqueue.c:2269 worker_thread+0xaa4/0x1460 kernel/workqueue.c:2415 kthread+0x37e/0x3a0 drivers/block/aoe/aoecmd.c:1234 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 [...] Freed by task 14058: save_stack mm/kasan/common.c:48 [inline] set_track mm/kasan/common.c:56 [inline] kasan_set_free_info mm/kasan/common.c:316 [inline] __kasan_slab_free+0x114/0x170 mm/kasan/common.c:455 __cache_free mm/slab.c:3426 [inline] kfree+0x10a/0x220 mm/slab.c:3757 tipc_exit_net+0x29/0x50 net/tipc/core.c:113 ops_exit_list net/core/net_namespace.c:186 [inline] cleanup_net+0x708/0xba0 net/core/net_namespace.c:603 process_one_work+0x789/0xfc0 kernel/workqueue.c:2269 worker_thread+0xaa4/0x1460 kernel/workqueue.c:2415 kthread+0x37e/0x3a0 drivers/block/aoe/aoecmd.c:1234 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 Fix it by calling flush_scheduled_work() to make sure the tipc_net_finalize_work() stopped before releasing bcbase object. Reported-by: syzbot+6ea1f7a8df64596ef4d7@syzkaller.appspotmail.com Reported-by: syzbot+e9cc557752ab126c1b99@syzkaller.appspotmail.com Acked-by: Jon Maloy <jmaloy@redhat.com> Signed-off-by: Hoang Huu Le <hoang.h.le@dektech.com.au> Signed-off-by: David S. Miller <davem@davemloft.net>
230 lines
5.8 KiB
C
230 lines
5.8 KiB
C
/*
|
|
* net/tipc/core.c: TIPC module code
|
|
*
|
|
* Copyright (c) 2003-2006, 2013, Ericsson AB
|
|
* Copyright (c) 2005-2006, 2010-2013, Wind River Systems
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the names of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
* Software Foundation.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "core.h"
|
|
#include "name_table.h"
|
|
#include "subscr.h"
|
|
#include "bearer.h"
|
|
#include "net.h"
|
|
#include "socket.h"
|
|
#include "bcast.h"
|
|
#include "node.h"
|
|
#include "crypto.h"
|
|
|
|
#include <linux/module.h>
|
|
|
|
/* configurable TIPC parameters */
|
|
unsigned int tipc_net_id __read_mostly;
|
|
int sysctl_tipc_rmem[3] __read_mostly; /* min/default/max */
|
|
|
|
static int __net_init tipc_init_net(struct net *net)
|
|
{
|
|
struct tipc_net *tn = net_generic(net, tipc_net_id);
|
|
int err;
|
|
|
|
tn->net_id = 4711;
|
|
tn->node_addr = 0;
|
|
tn->trial_addr = 0;
|
|
tn->addr_trial_end = 0;
|
|
tn->capabilities = TIPC_NODE_CAPABILITIES;
|
|
memset(tn->node_id, 0, sizeof(tn->node_id));
|
|
memset(tn->node_id_string, 0, sizeof(tn->node_id_string));
|
|
tn->mon_threshold = TIPC_DEF_MON_THRESHOLD;
|
|
get_random_bytes(&tn->random, sizeof(int));
|
|
INIT_LIST_HEAD(&tn->node_list);
|
|
spin_lock_init(&tn->node_list_lock);
|
|
|
|
#ifdef CONFIG_TIPC_CRYPTO
|
|
err = tipc_crypto_start(&tn->crypto_tx, net, NULL);
|
|
if (err)
|
|
goto out_crypto;
|
|
#endif
|
|
err = tipc_sk_rht_init(net);
|
|
if (err)
|
|
goto out_sk_rht;
|
|
|
|
err = tipc_nametbl_init(net);
|
|
if (err)
|
|
goto out_nametbl;
|
|
|
|
INIT_LIST_HEAD(&tn->dist_queue);
|
|
|
|
err = tipc_bcast_init(net);
|
|
if (err)
|
|
goto out_bclink;
|
|
|
|
err = tipc_attach_loopback(net);
|
|
if (err)
|
|
goto out_bclink;
|
|
|
|
return 0;
|
|
|
|
out_bclink:
|
|
tipc_nametbl_stop(net);
|
|
out_nametbl:
|
|
tipc_sk_rht_destroy(net);
|
|
out_sk_rht:
|
|
|
|
#ifdef CONFIG_TIPC_CRYPTO
|
|
tipc_crypto_stop(&tn->crypto_tx);
|
|
out_crypto:
|
|
#endif
|
|
return err;
|
|
}
|
|
|
|
static void __net_exit tipc_exit_net(struct net *net)
|
|
{
|
|
tipc_detach_loopback(net);
|
|
tipc_net_stop(net);
|
|
|
|
/* Make sure the tipc_net_finalize_work stopped
|
|
* before releasing the resources.
|
|
*/
|
|
flush_scheduled_work();
|
|
tipc_bcast_stop(net);
|
|
tipc_nametbl_stop(net);
|
|
tipc_sk_rht_destroy(net);
|
|
#ifdef CONFIG_TIPC_CRYPTO
|
|
tipc_crypto_stop(&tipc_net(net)->crypto_tx);
|
|
#endif
|
|
}
|
|
|
|
static void __net_exit tipc_pernet_pre_exit(struct net *net)
|
|
{
|
|
tipc_node_pre_cleanup_net(net);
|
|
}
|
|
|
|
static struct pernet_operations tipc_pernet_pre_exit_ops = {
|
|
.pre_exit = tipc_pernet_pre_exit,
|
|
};
|
|
|
|
static struct pernet_operations tipc_net_ops = {
|
|
.init = tipc_init_net,
|
|
.exit = tipc_exit_net,
|
|
.id = &tipc_net_id,
|
|
.size = sizeof(struct tipc_net),
|
|
};
|
|
|
|
static struct pernet_operations tipc_topsrv_net_ops = {
|
|
.init = tipc_topsrv_init_net,
|
|
.exit = tipc_topsrv_exit_net,
|
|
};
|
|
|
|
static int __init tipc_init(void)
|
|
{
|
|
int err;
|
|
|
|
pr_info("Activated (version " TIPC_MOD_VER ")\n");
|
|
|
|
sysctl_tipc_rmem[0] = RCVBUF_MIN;
|
|
sysctl_tipc_rmem[1] = RCVBUF_DEF;
|
|
sysctl_tipc_rmem[2] = RCVBUF_MAX;
|
|
|
|
err = tipc_register_sysctl();
|
|
if (err)
|
|
goto out_sysctl;
|
|
|
|
err = register_pernet_device(&tipc_net_ops);
|
|
if (err)
|
|
goto out_pernet;
|
|
|
|
err = tipc_socket_init();
|
|
if (err)
|
|
goto out_socket;
|
|
|
|
err = register_pernet_device(&tipc_topsrv_net_ops);
|
|
if (err)
|
|
goto out_pernet_topsrv;
|
|
|
|
err = register_pernet_subsys(&tipc_pernet_pre_exit_ops);
|
|
if (err)
|
|
goto out_register_pernet_subsys;
|
|
|
|
err = tipc_bearer_setup();
|
|
if (err)
|
|
goto out_bearer;
|
|
|
|
err = tipc_netlink_start();
|
|
if (err)
|
|
goto out_netlink;
|
|
|
|
err = tipc_netlink_compat_start();
|
|
if (err)
|
|
goto out_netlink_compat;
|
|
|
|
pr_info("Started in single node mode\n");
|
|
return 0;
|
|
|
|
out_netlink_compat:
|
|
tipc_netlink_stop();
|
|
out_netlink:
|
|
tipc_bearer_cleanup();
|
|
out_bearer:
|
|
unregister_pernet_subsys(&tipc_pernet_pre_exit_ops);
|
|
out_register_pernet_subsys:
|
|
unregister_pernet_device(&tipc_topsrv_net_ops);
|
|
out_pernet_topsrv:
|
|
tipc_socket_stop();
|
|
out_socket:
|
|
unregister_pernet_device(&tipc_net_ops);
|
|
out_pernet:
|
|
tipc_unregister_sysctl();
|
|
out_sysctl:
|
|
pr_err("Unable to start in single node mode\n");
|
|
return err;
|
|
}
|
|
|
|
static void __exit tipc_exit(void)
|
|
{
|
|
tipc_netlink_compat_stop();
|
|
tipc_netlink_stop();
|
|
tipc_bearer_cleanup();
|
|
unregister_pernet_subsys(&tipc_pernet_pre_exit_ops);
|
|
unregister_pernet_device(&tipc_topsrv_net_ops);
|
|
tipc_socket_stop();
|
|
unregister_pernet_device(&tipc_net_ops);
|
|
tipc_unregister_sysctl();
|
|
|
|
pr_info("Deactivated\n");
|
|
}
|
|
|
|
module_init(tipc_init);
|
|
module_exit(tipc_exit);
|
|
|
|
MODULE_DESCRIPTION("TIPC: Transparent Inter Process Communication");
|
|
MODULE_LICENSE("Dual BSD/GPL");
|
|
MODULE_VERSION(TIPC_MOD_VER);
|