leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12e750bc62
linux/drivers/scsi/device_handler
History
YueHaibing 12e750bc62 scsi: scsi_dh_alua: Fix possible null-ptr-deref 
If alloc_workqueue fails in alua_init, it should return -ENOMEM, otherwise
it will trigger null-ptr-deref while unloading module which calls
destroy_workqueue dereference
wq->lock like this:

BUG: KASAN: null-ptr-deref in __lock_acquire+0x6b4/0x1ee0
Read of size 8 at addr 0000000000000080 by task syz-executor.0/7045

CPU: 0 PID: 7045 Comm: syz-executor.0 Tainted: G         C        5.1.0+ #28
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1
Call Trace:
 dump_stack+0xa9/0x10e
 __kasan_report+0x171/0x18d
 ? __lock_acquire+0x6b4/0x1ee0
 kasan_report+0xe/0x20
 __lock_acquire+0x6b4/0x1ee0
 lock_acquire+0xb4/0x1b0
 __mutex_lock+0xd8/0xb90
 drain_workqueue+0x25/0x290
 destroy_workqueue+0x1f/0x3f0
 __x64_sys_delete_module+0x244/0x330
 do_syscall_64+0x72/0x2a0
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 03197b61c5 ("scsi_dh_alua: Use workqueue for RTPG")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2019-05-29 22:04:09 -04:00
..
Kconfig scsi_dh: force modular build if SCSI is a module 2016-02-23 21:27:02 -05:00
Makefile
scsi_dh_alua.c scsi: scsi_dh_alua: Fix possible null-ptr-deref 2019-05-29 22:04:09 -04:00
scsi_dh_emc.c scsi: return blk_status_t from device handler ->prep_fn 2018-11-09 19:17:14 -07:00
scsi_dh_hp_sw.c scsi: return blk_status_t from device handler ->prep_fn 2018-11-09 19:17:14 -07:00
scsi_dh_rdac.c scsi: return blk_status_t from device handler ->prep_fn 2018-11-09 19:17:14 -07:00