linux/sound/soc/sof
Guennadi Liakhovetski 1183e9a634
ASoC: SOF: ipc: fix a race, leading to IPC timeouts
Currently on all supported platforms the IPC IRQ thread first signals
the sender when an IPC response is received from the DSP, then unmasks
the IPC interrupt. Those actions are performed without holding any
locks, so the thread can be interrupted between them. IPC timeouts
have been observed in such scenarios: if the sender is woken up and it
proceeds with sending the next message without unmasking the IPC
interrupt, it can miss the next response. This patch takes a spin-lock
to prevent the IRQ thread from being preempted at that point. It also
makes sure, that the next IPC transmission by the host cannot take
place before the IRQ thread has finished updating all the required IPC
registers.

Fixes: 53e0c72d98 ("ASoC: SOF: Add support for IPC IO between DSP and Host")
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2019-05-28 15:48:47 +01:00
..
intel ASoC: SOF: ipc: fix a race, leading to IPC timeouts 2019-05-28 15:48:47 +01:00
xtensa ASoC: SOF: Add xtensa support 2019-04-28 02:49:31 +09:00
control.c ASoC: SOF: control: correct the copy size for bytes kcontrol put 2019-05-28 15:48:27 +01:00
core.c ASoC: SOF: core: fix error handling with the probe workqueue 2019-05-28 15:47:19 +01:00
debug.c ASoC: SOF: Add driver debug support. 2019-04-28 02:47:54 +09:00
ipc.c ASoC: SOF: ipc: fix a race, leading to IPC timeouts 2019-05-28 15:48:47 +01:00
Kconfig ASoC: SOF: nocodec: fix undefined reference 2019-05-13 12:36:56 +01:00
loader.c ASoC: SOF: fix race in FW boot timeout handling 2019-05-13 12:37:12 +01:00
Makefile ASoC: SOF: Add Build support for SOF core and Intel drivers 2019-04-28 02:51:46 +09:00
nocodec.c ASoC: SOF: Add Nocodec machine driver support 2019-04-28 02:49:26 +09:00
ops.c ASoC: SOF: Fix a compile warning with CONFIG_PCI=n 2019-05-07 11:23:57 +09:00
ops.h ASoC: SOF: IPC: add ipc dump function 2019-05-03 15:02:16 +09:00
pcm.c ASoC: SOF: pcm: remove warning - initialize workqueue on open 2019-05-28 15:48:05 +01:00
pm.c ASoC: SOF: intel: hda: add hw_params_upon_resume flag for hda stream 2019-05-03 15:01:45 +09:00
sof-acpi-dev.c ASoC: SOF: Add ACPI device support 2019-04-28 02:51:01 +09:00
sof-pci-dev.c ASoC: SOF: Add PCI device support 2019-04-28 02:51:05 +09:00
sof-priv.h ASoC: SOF: IPC: add ipc dump function 2019-05-03 15:02:16 +09:00
topology.c ASoC: SOF: topology: add support for stricter ABI checks 2019-05-03 14:56:31 +09:00
trace.c ASoC: SOF: Add DSP firmware logger support 2019-04-28 02:48:10 +09:00
utils.c ASoC: SOF: Add utils 2019-04-28 02:49:47 +09:00