forked from Minki/linux
ef24ba7091
NO_IRQ has been == 0 on powerpc for just over ten years (since commit
0ebfff1491 ("[POWERPC] Add new interrupt mapping core and change
platforms to use it")). It's also 0 on most other arches.
Although it's fairly harmless, every now and then it causes confusion
when a driver is built on powerpc and another arch which doesn't define
NO_IRQ. There's at least 6 definitions of NO_IRQ in drivers/, at least
some of which are to work around that problem.
So we'd like to remove it. This is fairly trivial in the arch code, we
just convert:
if (irq == NO_IRQ) to if (!irq)
if (irq != NO_IRQ) to if (irq)
irq = NO_IRQ; to irq = 0;
return NO_IRQ; to return 0;
And a few other odd cases as well.
At least for now we keep the #define NO_IRQ, because there is driver
code that uses NO_IRQ and the fixes to remove those will go via other
trees.
Note we also change some occurrences in PPC sound drivers, drivers/ps3,
and drivers/macintosh.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
58 lines
1.6 KiB
C
58 lines
1.6 KiB
C
/*
|
|
* Copyright (C) 2001 Dave Engebretsen IBM Corporation
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <asm/prom.h>
|
|
|
|
#include "pseries.h"
|
|
|
|
void request_event_sources_irqs(struct device_node *np,
|
|
irq_handler_t handler,
|
|
const char *name)
|
|
{
|
|
int i, index, count = 0;
|
|
struct of_phandle_args oirq;
|
|
unsigned int virqs[16];
|
|
|
|
/* First try to do a proper OF tree parsing */
|
|
for (index = 0; of_irq_parse_one(np, index, &oirq) == 0;
|
|
index++) {
|
|
if (count > 15)
|
|
break;
|
|
virqs[count] = irq_create_of_mapping(&oirq);
|
|
if (!virqs[count]) {
|
|
pr_err("event-sources: Unable to allocate "
|
|
"interrupt number for %s\n",
|
|
np->full_name);
|
|
WARN_ON(1);
|
|
} else {
|
|
count++;
|
|
}
|
|
}
|
|
|
|
/* Now request them */
|
|
for (i = 0; i < count; i++) {
|
|
if (request_irq(virqs[i], handler, 0, name, NULL)) {
|
|
pr_err("event-sources: Unable to request interrupt "
|
|
"%d for %s\n", virqs[i], np->full_name);
|
|
WARN_ON(1);
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
|