The j1939_session_deactivate() is decrementing the session ref-count and
potentially can free() the session. This would cause use-after-free
situation.
However, the code calling j1939_session_deactivate() does always hold
another reference to the session, so that it would not be free()ed in
this code path.
This patch adds a comment to make this clear and a WARN_ON, to ensure
that future changes will not violate this requirement. Further this
patch avoids dereferencing the session pointer as a precaution to avoid
use-after-free if the session is actually free()ed.
Fixes:
|
||
---|---|---|
.. | ||
address-claim.c | ||
bus.c | ||
j1939-priv.h | ||
Kconfig | ||
main.c | ||
Makefile | ||
socket.c | ||
transport.c |