linux

mainlining shenanigans

Go to file

Kai Vehmanen 06f07e2365 ASoC: hdac_hda: fix deadlock after PCM open error Commit `5bd70440cb` ("ASoC: soc-dai: revert all changes to DAI startup/shutdown sequence"), introduced a slight change of semantics to DAI startup/shutdown. If startup() returns an error, shutdown() is now called for the DAI. This causes a deadlock in hdac_hda which issues a call to snd_hda_codec_pcm_put() in case open fails. Upon error, soc_pcm_open() will call shutdown(), and pcm_put() ends up getting called twice. Result is a deadlock on pcm->open_mutex, as snd_device_free() gets called from within snd_pcm_open(). Typical task backtrace looks like this: [ 334.244627] snd_pcm_dev_disconnect+0x49/0x340 [snd_pcm] [ 334.244634] __snd_device_disconnect.part.0+0x2c/0x50 [snd] [ 334.244640] __snd_device_free+0x7f/0xc0 [snd] [ 334.244650] snd_hda_codec_pcm_put+0x87/0x120 [snd_hda_codec] [ 334.244660] soc_pcm_open+0x6a0/0xbe0 [snd_soc_core] [ 334.244676] ? dpcm_add_paths.isra.0+0x491/0x590 [snd_soc_core] [ 334.244679] ? kfree+0x9a/0x230 [ 334.244686] dpcm_be_dai_startup+0x255/0x300 [snd_soc_core] [ 334.244695] dpcm_fe_dai_open+0x20e/0xf30 [snd_soc_core] [ 334.244701] ? snd_pcm_hw_rule_muldivk+0x110/0x110 [snd_pcm] [ 334.244709] ? dpcm_be_dai_startup+0x300/0x300 [snd_soc_core] [ 334.244714] ? snd_pcm_attach_substream+0x3c4/0x540 [snd_pcm] [ 334.244719] snd_pcm_open_substream+0x69a/0xb60 [snd_pcm] [ 334.244729] ? snd_pcm_release_substream+0x30/0x30 [snd_pcm] [ 334.244732] ? __mutex_lock_slowpath+0x10/0x10 [ 334.244736] snd_pcm_open+0x1b3/0x3c0 [snd_pcm] Fixes: `5bd70440cb` ("ASoC: soc-dai: revert all changes to DAI startup/shutdown sequence") Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@linux.intel.com> BugLink: https://github.com/thesofproject/linux/issues/2159 Link: https://lore.kernel.org/r/20200717101950.3885187-3-kai.vehmanen@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>		2020-07-22 14:31:58 +01:00
arch	ARM: dts: motorola-mapphone-common: remove unneeded "simple-graph-card"	2020-07-01 17:21:08 +01:00
block	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
certs	.gitignore: add SPDX License Identifier	2020-03-25 11:50:48 +01:00
crypto	Merge branch 'rwonce/rework' of git://git.kernel.org/pub/scm/linux/kernel/git/will/linux	2020-06-10 14:46:54 -07:00
Documentation	ASoC: Replace HTTP links with HTTPS ones	2020-07-22 14:31:55 +01:00
drivers	ASoC: hdmi-codec: merge .digital_mute() into .mute_stream()	2020-07-16 23:06:06 +01:00
fs	for-5.8-part2-tag	2020-06-14 09:47:25 -07:00
include	Merge series "ASoC: Intel: machine driver updates for 5.9" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:	2020-07-20 15:34:31 +01:00
init	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
ipc	mmap locking API: use coccinelle to convert mmap_sem rwsem call sites	2020-06-09 09:39:14 -07:00
kernel	Add additional LSM hooks for SafeSetID	2020-06-14 11:39:31 -07:00
lib	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
LICENSES
mm	Kbuild updates for v5.8 (2nd)	2020-06-13 13:29:16 -07:00
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-06-13 16:27:13 -07:00
samples	binderfs: add gitignore for generated sample program	2020-06-13 13:41:24 -07:00
scripts	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-06-13 16:27:13 -07:00
security	Add additional LSM hooks for SafeSetID	2020-06-14 11:39:31 -07:00
sound	ASoC: hdac_hda: fix deadlock after PCM open error	2020-07-22 14:31:58 +01:00
tools	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-06-13 16:27:13 -07:00
usr	bpfilter: match bit size of bpfilter_umh to that of the kernel	2020-05-17 18:52:01 +09:00
virt	MIPS:	2020-06-12 11:05:52 -07:00
.clang-format	block: add bio_for_each_bvec_all()	2020-05-25 11:25:24 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore	modpost: generate vmlinux.symvers and reuse it for the second modpost	2020-06-06 23:38:12 +09:00
.mailmap	A fair amount of stuff this time around, dominated by yet another massive	2020-06-01 15:45:27 -07:00
COPYING	COPYING: state that all contributions really are covered by this file	2020-02-10 13:32:20 -08:00
CREDITS	mailmap: change email for Ricardo Ribalda	2020-05-25 18:59:59 -06:00
Kbuild
Kconfig	kbuild: ensure full rebuild when the compiler is updated	2020-05-12 13:28:33 +09:00
MAINTAINERS	Merge series "ASoC: topology: fix error handling flow" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:	2020-07-08 16:50:36 +01:00
Makefile	Linux 5.8-rc1	2020-06-14 12:45:04 -07:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.