leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
06168a64b1
linux/drivers/video/backlight
History
Bhushan Shah 06168a64b1 backlight: lm3630a: Bump REG_MAX value to 0x50 instead of 0x1F 
In the lm3630a_chip_init we try to write to 0x50 register, which is
higher value then the max_register value, this resulted in regmap_write
return -EIO.

Fix this by bumping REG_MAX value to 0x50.

This code was introduced with the chip revision in commit 28e64a68a2,
however setting filter strength was failing silently because it used
unsigned int for storing and comparing the return values. Bug related to
signedness was fixed in 2a0c316bf3, which made it error out correctly
instead of failing silently.

I found this issue by using this driver on LGE Nexus 5 (hammerhead).
After this commit lm3630a_chip_init succeeds instead of failing with
-EIO.

Fixes: 28e64a68a2 ("backlight: lm3630: apply chip revision")
Fixes: 2a0c316bf3 ("drivers/video/backlight/lm3630a_bl.c: fix
signedness bug in lm3630a_chip_init()")

Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Bhushan Shah <bshah@kde.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
2017-07-17 13:27:06 +01:00
..
88pm860x_bl.c backlight: 88pm860x_bl: Add missing of_node_put 2015-10-15 12:06:21 +01:00
aat2870_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
adp5520_bl.c backlight: adp5520: Fix error handling in adp5520_bl_probe() 2017-01-04 11:37:31 +00:00
adp8860_bl.c backlight: adp8860: Move header file out of I2C realm 2017-07-06 08:56:08 +01:00
adp8870_bl.c video: adp8870: move header file out of I2C realm 2017-07-06 08:58:39 +01:00
ams369fg06.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
apple_bl.c
arcxcnn_bl.c backlight: Add support for Arctic Sand LED backlight driver chips 2017-04-25 09:22:23 +01:00
as3711_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
backlight.c backlight: Report error on failure 2017-05-30 09:27:53 +01:00
bd6107.c backlight: Remove trivial get_brightness implementations 2014-06-23 13:24:22 +01:00
corgi_lcd.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
cr_bllcd.c backlight: cr_bllcd: Add blank line after declarations 2014-08-29 08:24:51 +01:00
da903x_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
da9052_bl.c backlight: da9052: Fix module autoload 2017-01-04 11:37:58 +00:00
ep93xx_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
generic_bl.c backlight: generic_bl: Remove unused function 2014-08-28 14:10:16 +01:00
gpio_backlight.c backlight: gpio-backlight: Use default-on on GPIO request 2016-01-11 07:58:35 +00:00
hp680_bl.c
hx8357.c backlight: hx8357: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ili922x.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
ili9320.c backlight: ili9320: remove unnecessary OOM messages 2014-04-03 16:21:10 -07:00
ili9320.h
ipaq_micro_bl.c backlight: ipaq_micro: Fix sparse non static symbol warning 2014-07-31 10:31:22 +01:00
jornada720_bl.c backlight: jornada720: Remove 'else' after a return 2014-08-29 08:26:32 +01:00
jornada720_lcd.c backlight: jornada720: Remove 'else' after a return 2014-08-29 08:26:51 +01:00
kb3886_bl.c backlight: kb3886_bl: fix incorrect placement of __initdata marker 2014-01-23 16:36:57 -08:00
Kconfig backlight: Add support for Arctic Sand LED backlight driver chips 2017-04-25 09:22:23 +01:00
l4f00242t03.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
lcd.c backlight: lcd: Fix race condition during register 2017-01-04 11:37:31 +00:00
ld9040_gamma.h
ld9040.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
lm3533_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
lm3630a_bl.c backlight: lm3630a: Bump REG_MAX value to 0x50 instead of 0x1F 2017-07-17 13:27:06 +01:00
lm3639_bl.c backlight: lm3639: Remove unnecessary return statements 2014-08-29 08:25:23 +01:00
lms283gf05.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
lms501kf03.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
locomolcd.c
lp855x_bl.c backlight: lp855x: Add enable regulator 2016-06-29 10:06:21 +01:00
lp8788_bl.c backlight: lp8788: Explicitly apply PWM config extracted from pwm_args 2016-05-17 14:45:04 +02:00
ltv350qv.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
ltv350qv.h
lv5207lp.c backlight: Remove trivial get_brightness implementations 2014-06-23 13:24:22 +01:00
Makefile backlight: Add support for Arctic Sand LED backlight driver chips 2017-04-25 09:22:23 +01:00
max8925_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
omap1_bl.c backlight: omap1: add blank line after declarations 2014-08-29 08:27:53 +01:00
ot200_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
pandora_bl.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
pcf50633-backlight.c backlight: pcf50633: Add blank line after declarations 2014-08-29 08:25:53 +01:00
platform_lcd.c backlight: Remove .owner field for drivers using module_platform_driver 2014-08-28 14:09:48 +01:00
pm8941-wled.c backlight: pm8941-wled: Add default-brightness property 2015-10-30 18:47:51 +00:00
pwm_bl.c backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction() 2017-04-19 19:59:44 +01:00
s6e63m0_gamma.h
s6e63m0.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
sky81452-backlight.c backlight: sky81452: Remove unneeded use of IS_ERR_VALUE() macro 2015-08-25 08:43:21 +01:00
tdo24m.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
tosa_bl.c backlight-tosa: Delete unnecessary assignment for the field "owner" 2016-10-06 09:27:25 +01:00
tosa_lcd.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
tps65217_bl.c backlight: tps65217_bl: Add MODULE_DEVICE_TABLE 2016-01-11 06:36:35 +00:00
vgg2432a4.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
wm831x_bl.c backlight: wm831x_bl: Add blank line after declarations 2014-08-29 08:26:21 +01:00