048578a195
Remove unnecessary static on local variable fw_dump_ops.
Such variable is initialized before being used, on every
execution path throughout the function. The static has no
benefit and, removing it reduces the object file size.
This issue was detected using Coccinelle and the following semantic patch:
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>
@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
T x@p;
... when != x
when strict
?x = e;
In the following log you can see a difference in the object file size.
This log is the output of the size command, before and after the code
change:
before:
text data bss dec hex filename
19032 2136 64 21232 52f0 drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.o
after:
text data bss dec hex filename
19020 2048 0 21068 524c drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.o
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| qlcnic_83xx_hw.c | ||
| qlcnic_83xx_hw.h | ||
| qlcnic_83xx_init.c | ||
| qlcnic_83xx_vnic.c | ||
| qlcnic_ctx.c | ||
| qlcnic_dcb.c | ||
| qlcnic_dcb.h | ||
| qlcnic_ethtool.c | ||
| qlcnic_hdr.h | ||
| qlcnic_hw.c | ||
| qlcnic_hw.h | ||
| qlcnic_init.c | ||
| qlcnic_io.c | ||
| qlcnic_main.c | ||
| qlcnic_minidump.c | ||
| qlcnic_sriov_common.c | ||
| qlcnic_sriov_pf.c | ||
| qlcnic_sriov.h | ||
| qlcnic_sysfs.c | ||
| qlcnic.h | ||