Nicholas Piggin 044d0d6de9
lockdep: Only trace IRQ edges ...
Problem:
raw_local_irq_save(); // software state on
local_irq_save(); // software state off
...
local_irq_restore(); // software state still off, because we don't enable IRQs
raw_local_irq_restore(); // software state still off, *whoopsie*
existing instances:
- lock_acquire()
raw_local_irq_save()
__lock_acquire()
arch_spin_lock(&graph_lock)
pv_wait() := kvm_wait() (same or worse for Xen/HyperV)
local_irq_save()
- trace_clock_global()
raw_local_irq_save()
arch_spin_lock()
pv_wait() := kvm_wait()
local_irq_save()
- apic_retrigger_irq()
raw_local_irq_save()
apic->send_IPI() := default_send_IPI_single_phys()
local_irq_save()
Possible solutions:
A) make it work by enabling the tracing inside raw_*()
B) make it work by keeping tracing disabled inside raw_*()
C) call it broken and clean it up now
Now, given that the only reason to use the raw_* variant is because you don't
want tracing. Therefore A) seems like a weird option (although it can be done).
C) is tempting, but OTOH it ends up converting a _lot_ of code to raw just
because there is one raw user, this strips the validation/tracing off for all
the other users.
So we pick B) and declare any code that ends up doing:
raw_local_irq_save()
local_irq_save()
lockdep_assert_irqs_disabled();
broken. AFAICT this problem has existed forever, the only reason it came
up is because commit: 859d069ee1npiggin@gmail.com >
[rewrote changelog]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org >
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org >
Reviewed-by: Thomas Gleixner <tglx@linutronix.de >
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com >
Tested-by: Marco Elver <elver@google.com >
Link: https://lkml.kernel.org/r/20200723105615.1268126-1-npiggin@gmail.com
2020-08-26 12:41:56 +02:00
2020-06-30 00:32:59 +02:00
2020-05-22 20:47:21 -07:00
2020-06-15 23:08:31 -05:00
2020-08-04 19:41:12 +02:00
2020-07-24 02:19:08 -07:00
2020-08-03 11:05:26 +02:00
2020-07-31 11:49:08 +02:00
2020-08-12 10:57:59 -07:00
2020-08-03 18:19:23 -07:00
2020-08-05 11:43:47 -07:00
2020-08-05 20:13:21 -07:00
2020-08-04 01:22:02 +02:00
2020-07-13 15:07:34 +01:00
2020-07-08 22:31:51 -07:00
2020-08-12 10:57:59 -07:00
2020-08-07 12:58:11 -07:00
2020-08-15 08:09:38 -07:00
2020-06-05 14:05:57 -07:00
2020-08-06 16:43:36 -07:00
2020-08-05 20:13:21 -07:00
2020-08-07 08:54:16 +02:00
2020-06-25 22:25:13 -07:00
2020-07-24 15:41:53 -07:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2020-05-18 19:30:56 +05:30
2020-08-15 08:18:22 -07:00
2020-07-29 22:33:10 +02:00
2020-07-22 18:19:03 -07:00
2020-07-16 15:35:21 +02:00
2020-07-17 00:16:50 +01:00
2020-07-28 17:11:02 -07:00
2020-06-16 14:19:57 +02:00
2020-08-17 09:39:18 -07:00
2020-08-12 10:57:59 -07:00
2020-07-21 16:05:40 +05:30
2020-07-27 14:55:22 +01:00
2020-08-15 08:26:55 -07:00
2020-08-05 20:13:21 -07:00
2020-07-15 20:34:02 -07:00
2020-07-28 15:51:31 +01:00
2020-08-04 18:11:58 -07:00
2020-07-22 10:22:05 +02:00
2020-08-03 19:30:59 -07:00
2020-08-12 10:57:59 -07:00
2020-07-19 18:16:40 -07:00
2020-06-11 08:03:24 +02:00
2020-06-25 08:23:22 -07:00
2020-06-11 08:03:24 +02:00
2020-07-21 11:12:31 -04:00
2020-07-08 17:20:46 -06:00
2020-07-08 17:20:46 -06:00
2020-07-20 10:27:11 +01:00
2020-05-24 20:48:11 +02:00
2020-07-21 08:24:52 -05:00
2020-06-29 09:09:08 -06:00
2020-08-10 12:16:51 -07:00
2020-06-04 19:06:25 -07:00
2020-07-08 10:48:35 -07:00
2020-07-17 07:15:10 -06:00
2020-07-08 17:05:53 -06:00
2020-05-14 09:48:03 -06:00
2020-07-28 10:22:19 -06:00
2020-08-05 11:12:34 -07:00
2020-07-17 20:18:16 -07:00
2020-06-22 22:22:58 +02:00
2020-07-25 20:16:35 -07:00
2020-07-17 20:18:16 -07:00
2020-08-06 16:39:14 -07:00
2020-07-24 15:41:54 -07:00
2020-05-15 10:56:31 -07:00
2020-06-11 15:14:53 +02:00
2020-07-21 13:26:26 -07:00
2020-06-25 16:17:05 +02:00
2020-08-12 10:57:59 -07:00
2020-06-24 09:16:02 -06:00
2020-05-19 09:40:29 -06:00
2020-06-09 09:39:16 -07:00
2020-07-19 20:14:42 +02:00
2020-06-15 23:08:31 -05:00
2020-07-08 16:20:01 -06:00
2020-07-09 16:28:44 -07:00
2020-07-07 13:34:11 -07:00
2020-08-03 15:07:18 -07:00
2020-08-12 10:57:56 -07:00
2020-08-14 19:56:56 -07:00
2020-08-04 13:26:06 -07:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:57:59 -07:00
2020-08-04 13:49:43 -07:00
2020-08-03 14:25:40 -07:00
2020-06-24 17:08:33 +02:00
2020-06-24 17:08:31 +02:00
2020-06-11 15:14:36 +02:00
2020-07-24 13:56:23 +02:00
2020-07-21 15:48:40 +02:00
2020-05-14 11:11:20 +02:00
2020-05-19 12:55:29 +02:00
2020-06-17 17:28:08 +02:00
2020-08-11 17:29:45 +02:00
2020-08-20 10:57:29 -07:00
2020-08-26 12:41:53 +02:00
2020-08-12 10:58:01 -07:00
2020-06-09 09:39:13 -07:00
2020-07-16 21:49:09 +10:00
2020-06-24 09:16:02 -06:00
2020-06-09 09:39:13 -07:00
2020-07-29 16:14:27 +02:00
2020-06-11 15:15:28 +02:00
2020-07-10 13:54:00 -07:00
2020-08-12 10:57:59 -07:00
2020-06-08 11:05:56 -07:00
2020-07-30 19:26:10 +02:00
2020-07-30 17:22:57 +09:00
2020-06-01 16:44:06 -07:00
2020-08-03 11:57:03 -07:00
2020-08-05 13:02:45 -07:00
2020-06-05 14:59:41 -04:00
2020-07-10 15:39:29 +05:30
2020-08-14 15:22:43 -07:00
2020-08-14 16:27:00 +02:00
2020-07-21 09:42:19 +02:00
2020-08-14 16:27:00 +02:00
2020-06-09 09:39:13 -07:00
2020-07-29 16:14:25 +02:00
2020-08-07 12:41:36 -07:00
2020-07-24 14:33:39 +02:00
2020-07-24 17:00:08 +02:00
2020-08-06 16:13:13 +02:00
2020-06-16 19:25:20 +02:00
2020-07-27 12:14:28 +02:00
2020-08-07 11:33:28 -07:00
2020-05-29 10:23:24 -06:00
2020-07-27 14:29:22 -04:00
2020-07-27 14:29:23 -04:00
2020-06-04 19:06:25 -07:00
2020-06-24 17:16:42 +02:00
2020-07-24 14:59:04 +02:00
2020-07-24 15:03:42 +02:00
2020-06-05 13:17:05 -07:00
2020-07-08 12:39:05 -07:00
2020-08-12 10:57:59 -07:00
2020-07-27 23:24:00 +02:00
2020-08-04 07:37:23 +02:00
2020-06-17 00:07:38 +02:00
2020-06-03 23:16:55 -04:00
2020-07-13 11:03:45 -07:00
2020-07-25 20:16:34 -07:00
2020-07-17 13:12:44 -04:00
2020-08-12 10:57:57 -07:00
2020-07-14 14:45:41 +02:00
2020-07-29 16:14:27 +02:00
2020-08-16 10:55:12 -07:00
2020-06-15 23:08:31 -05:00
2020-07-21 16:02:13 -07:00
2020-07-27 23:25:50 +02:00
2020-07-27 23:24:00 +02:00
2020-07-21 16:02:41 -07:00
2020-05-19 15:51:18 +02:00
2020-06-15 14:09:49 +02:00
2020-05-15 16:34:52 +02:00
2020-08-12 10:57:59 -07:00
2020-07-17 20:18:00 -06:00
2020-06-03 20:09:45 -07:00
2020-07-10 12:00:01 +02:00
2020-07-20 17:00:02 -07:00
2020-06-24 15:45:51 +10:00
2020-08-12 10:57:57 -07:00
2020-07-10 16:24:28 -03:00
2020-07-17 16:06:14 +02:00
2020-08-06 16:13:13 +02:00
2020-08-14 19:56:56 -07:00
2020-08-12 10:58:02 -07:00
2020-08-06 17:54:04 +02:00
2020-05-28 07:59:45 -07:00
2020-06-20 09:16:19 +00:00
2020-05-15 11:23:49 +02:00
2020-05-29 12:53:04 +02:00
2020-08-13 18:41:00 -07:00
2020-07-24 17:12:41 -07:00
2020-06-19 13:41:59 -07:00
2020-05-19 12:54:05 +02:00
2020-05-28 10:31:09 +02:00
2020-08-03 10:54:54 +02:00
2020-07-14 13:46:42 -07:00
2020-07-07 15:48:38 -07:00
2020-05-20 20:31:27 -04:00
2020-07-20 13:28:16 -04:00
2020-06-23 15:11:19 -07:00
2020-08-04 21:02:38 -04:00
2020-07-30 08:22:33 +02:00
2020-07-24 13:56:23 +02:00
2020-07-27 14:17:36 +02:00
2020-07-24 14:33:39 +02:00
2020-05-18 15:37:25 +02:00
2020-06-16 16:43:23 +03:00
2020-06-10 14:04:39 -07:00
2020-07-30 11:16:01 -07:00
2020-08-14 19:56:57 -07:00
2020-08-14 19:56:57 -07:00
2020-07-24 12:42:42 -07:00
2020-07-24 14:29:47 +02:00
2020-06-05 16:19:28 -07:00
2020-07-29 14:42:00 +02:00
2020-06-07 10:59:32 -07:00
2020-06-08 11:05:56 -07:00
2020-07-24 17:12:41 -07:00
2020-05-18 10:30:21 +01:00
2020-06-28 17:01:20 +02:00
2020-07-27 16:20:40 +02:00
2020-07-27 08:55:04 +01:00
2020-07-04 10:02:06 +02:00
2020-05-18 10:29:26 +01:00
2020-08-26 12:41:56 +02:00
2020-07-04 10:02:06 +02:00
2020-08-21 11:03:38 -07:00
2020-08-12 10:57:59 -07:00
2020-06-19 14:17:05 -06:00
2020-07-08 15:59:57 -07:00
2020-08-07 11:33:28 -07:00
2020-06-26 10:01:08 -06:00
2020-06-02 15:15:46 +01:00
2020-08-12 10:58:02 -07:00
2020-07-29 23:47:53 +10:00
2020-05-19 15:42:22 +01:00
2020-05-14 09:46:54 -06:00
2020-07-09 20:12:19 -07:00
2020-05-30 10:34:03 -07:00
2020-07-23 10:33:12 +02:00
2020-08-07 18:29:15 -07:00
2020-06-11 13:25:53 -07:00
2020-08-06 16:13:13 +02:00
2020-08-06 12:59:31 -07:00
2020-07-29 16:14:29 +02:00
2020-07-09 13:29:42 -04:00
2020-07-22 14:41:29 +02:00
2020-08-12 10:57:59 -07:00
2020-07-22 14:42:07 +02:00
2020-06-27 15:20:03 -07:00
2020-07-28 19:29:22 -06:00
2020-07-01 07:27:24 -06:00
2020-07-20 17:59:43 -07:00
2020-08-02 20:39:44 -07:00
2020-05-28 10:31:09 +02:00
2020-05-28 10:31:09 +02:00
2020-07-28 10:45:46 +02:00
2020-08-26 12:41:53 +02:00
2020-05-19 15:47:38 +01:00
2020-08-11 14:30:36 -07:00
2020-08-11 14:30:36 -07:00
2020-06-22 16:28:34 -07:00
2020-08-07 21:27:37 -07:00
2020-06-26 13:40:09 -07:00
2020-07-10 15:08:09 +02:00
2020-08-14 19:56:57 -07:00
2020-06-10 13:42:09 -07:00
2020-08-12 10:57:56 -07:00
2020-05-28 11:22:13 +02:00
2020-05-22 09:35:43 +02:00
2020-07-23 09:35:36 +02:00
2020-08-12 10:58:02 -07:00
2020-08-14 19:56:56 -07:00
2020-08-14 19:56:56 -07:00
2020-08-14 19:56:57 -07:00
2020-08-07 11:33:26 -07:00
2020-06-09 09:39:14 -07:00
2020-08-26 12:41:53 +02:00
2020-08-07 11:33:21 -07:00
2020-08-12 10:57:56 -07:00
2020-07-23 09:12:15 +02:00
2020-08-05 10:31:28 +02:00
2020-05-19 11:42:16 +01:00
2020-07-20 10:39:54 +02:00
2020-06-09 15:40:50 -07:00
2020-06-02 10:59:07 -07:00
2020-07-31 18:08:59 +10:00
2020-07-24 15:41:54 -07:00
2020-07-24 15:41:54 -07:00
2020-08-06 16:13:13 +02:00
2020-07-24 15:41:54 -07:00
2020-08-05 20:13:21 -07:00
2020-08-13 04:16:15 +02:00
2020-07-24 15:41:54 -07:00
2020-07-15 07:45:25 -07:00
2020-08-15 08:26:55 -07:00
2020-07-13 17:52:45 -04:00
2020-07-13 17:52:46 -04:00
2020-07-13 17:52:45 -04:00
2020-07-21 10:50:36 +01:00
2020-06-05 20:02:08 -04:00
2020-07-29 07:45:20 +02:00
2020-07-29 07:45:21 +02:00
2020-07-29 17:12:08 +02:00
2020-07-29 17:12:08 +02:00
2020-07-28 22:49:52 +02:00
2020-07-28 15:51:32 +01:00
2020-07-01 10:49:02 +02:00
2020-07-28 15:51:32 +01:00
2020-07-28 15:51:32 +01:00
2020-06-30 15:57:34 -07:00
2020-08-03 19:30:59 -07:00
2020-08-12 10:57:56 -07:00
2020-06-16 20:45:08 -07:00
2020-07-23 17:34:18 +10:00
2020-06-02 10:59:09 -07:00
2020-07-16 12:32:25 -07:00
2020-06-04 15:36:52 -04:00
2020-08-07 11:33:29 -07:00
2020-08-14 19:56:56 -07:00
2020-05-15 13:51:28 -07:00
2020-05-27 05:21:23 -06:00
2020-08-12 12:09:36 -07:00
2020-06-04 12:59:16 -05:00
2020-07-24 09:50:41 -05:00
2020-05-22 12:35:07 +01:00
2020-08-07 18:48:15 -07:00
2020-08-07 11:33:26 -07:00
2020-07-21 10:50:37 +01:00
2020-08-05 20:13:21 -07:00
2020-08-17 21:50:54 +03:00
2020-08-03 15:01:02 -07:00
2020-08-17 11:46:22 -07:00
2020-06-04 13:54:34 -07:00
2020-06-13 09:56:21 -07:00
2020-07-28 17:07:06 -07:00
2020-07-14 15:14:27 +02:00
2020-08-04 12:44:53 +02:00
2020-08-04 12:39:28 +02:00
2020-07-27 13:52:36 +02:00
2020-08-12 10:57:59 -07:00
2020-08-06 16:50:59 +02:00
2020-07-31 14:33:56 +02:00
2020-08-03 23:24:26 -07:00
2020-05-19 15:51:17 +02:00
2020-07-27 17:46:24 +09:00
2020-07-25 20:16:32 -07:00
2020-07-19 14:16:09 +02:00
2020-05-20 19:10:37 +01:00
2020-06-15 14:10:03 +02:00
2020-06-15 17:38:53 +10:00
2020-05-31 19:49:00 -07:00
2020-05-30 10:34:03 -07:00
2020-05-31 19:49:00 -07:00
2020-05-30 10:34:03 -07:00
2020-06-02 10:59:10 -07:00
2020-05-15 13:48:59 -07:00
2020-07-21 10:50:37 +01:00
2020-06-17 20:42:11 +02:00
2020-07-24 22:09:54 -04:00
2020-07-13 22:43:43 -07:00
2020-05-28 10:31:09 +02:00
2020-08-03 23:24:26 -07:00
2020-07-27 17:46:24 +09:00
2020-07-27 17:46:24 +09:00
2020-06-29 11:58:11 -07:00
2020-08-03 14:39:35 -07:00
2020-06-29 12:00:46 -07:00
2020-06-29 11:59:26 -07:00
2020-06-29 11:59:26 -07:00
2020-06-29 11:59:25 -07:00
2020-05-20 03:39:40 -04:00
2020-07-17 00:03:11 +01:00
2020-07-27 14:31:13 -04:00
2020-08-04 20:16:37 -07:00
2020-07-28 17:09:49 -07:00
2020-06-30 17:18:56 -04:00
2020-06-09 09:39:14 -07:00
2020-07-21 14:07:51 -07:00
2020-07-16 13:35:25 +02:00
2020-07-22 13:39:31 +02:00
2020-07-16 23:19:51 +02:00
2020-07-06 16:07:25 +02:00
2020-07-20 11:50:47 +01:00
2020-08-14 14:17:51 -07:00
2020-07-13 09:40:21 +01:00
2020-05-18 17:47:48 +01:00
2020-06-15 23:08:32 -05:00
2020-08-04 21:00:11 -07:00
2020-06-14 11:39:31 -07:00
2020-06-04 19:06:26 -07:00
2020-08-06 16:13:13 +02:00
2020-07-29 17:14:38 +02:00
2020-07-20 09:39:11 +02:00
2020-06-11 15:19:17 +02:00
2020-08-07 11:33:24 -07:00
2020-08-07 21:14:30 -07:00
2020-06-30 10:46:39 -07:00
2020-08-07 11:33:25 -07:00
2020-08-07 11:33:25 -07:00
2020-08-07 11:33:25 -07:00
2020-06-28 17:01:20 +02:00
2020-06-28 17:01:20 +02:00
2020-06-30 09:34:23 -04:00
2020-08-10 12:06:44 -07:00
2020-06-17 18:33:13 +02:00
2020-06-17 18:33:13 +02:00
2020-05-17 14:10:07 -06:00
2020-06-10 19:14:18 -07:00
2020-05-14 16:44:24 +02:00
2020-07-15 12:45:06 +03:00
2020-06-03 20:09:42 -07:00
2020-07-28 19:28:32 -06:00
2020-08-12 10:57:56 -07:00
2020-08-14 19:56:56 -07:00
2020-08-14 19:56:56 -07:00
2020-07-25 19:34:48 -06:00
2020-05-15 14:53:19 +02:00
2020-06-30 12:18:08 -06:00
2020-07-27 14:11:22 +02:00
2020-07-31 17:00:44 -07:00
2020-05-25 23:15:03 +02:00
2020-07-07 15:55:21 +02:00
2020-06-22 19:58:06 +03:00
2020-06-15 23:08:32 -05:00
2020-07-08 11:14:22 +02:00
2020-08-06 16:13:13 +02:00
2020-06-18 11:37:03 +02:00
2020-06-29 12:01:44 -07:00
2020-07-24 08:16:01 +03:00
2020-07-24 09:26:23 +03:00
2020-08-07 17:05:01 -04:00
2020-08-03 13:34:37 -04:00
2020-07-29 16:14:18 +02:00
2020-06-04 15:50:42 -07:00
2020-05-29 14:52:53 +02:00
2020-08-12 10:57:59 -07:00
2020-06-30 09:34:23 -04:00
2020-07-04 09:35:36 -05:00
2020-07-15 16:48:11 +02:00
2020-07-07 11:58:59 -05:00
2020-07-20 15:04:32 +02:00
2020-07-10 13:45:32 +02:00
2020-08-05 19:00:23 -04:00
2020-05-28 15:53:29 -06:00
2020-08-01 11:28:17 +02:00
2020-08-06 16:13:13 +02:00
2020-08-05 11:08:41 -04:00
2020-08-05 19:56:03 -04:00
2020-05-28 16:31:30 -07:00
2020-08-05 09:30:19 -04:00
2020-08-12 10:57:57 -07:00
2020-06-26 00:27:38 -07:00
2020-08-07 11:33:24 -07:00
2020-07-10 14:55:25 +02:00
2020-06-02 02:45:13 -04:00
2020-06-24 17:08:31 +02:00
2020-05-19 15:08:24 +01:00
2020-08-05 18:43:02 +02:00
2020-08-12 10:57:59 -07:00
2020-06-01 11:02:28 -04:00
2020-06-05 16:19:28 -07:00
2020-08-06 16:13:13 +02:00
2020-06-08 11:05:56 -07:00
2020-08-09 13:58:04 -07:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:57:59 -07:00
2020-06-02 10:59:10 -07:00
044d0d6de9