forked from Minki/linux
6f3b62781b
Everyone who implements connector_helper_funcs->atomic_check reaches into the connector state to get the atomic state. Instead of continuing this pattern, change the callback signature to just give atomic state and let the driver determine what it does and does not need from it. Eventually all atomic functions should do this, but that's just too much busy work for me. Changes in v3: - Added to the set Changes in v4: - None Changes in v5: - intel_digital_connector_atomic_check declaration moved to i915_atomic.h Link to v3: https://patchwork.freedesktop.org/patch/msgid/20190502194956.218441-5-sean@poorly.run Link to v4: https://patchwork.freedesktop.org/patch/msgid/20190508160920.144739-5-sean@poorly.run Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Cc: Eric Anholt <eric@anholt.net> Tested-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> [for rcar lvds] Acked-by: Daniel Vetter <daniel@ffwll.ch> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20190611160844.257498-5-sean@poorly.run
429 lines
13 KiB
C
429 lines
13 KiB
C
/*
|
|
* Copyright © 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
/**
|
|
* DOC: atomic modeset support
|
|
*
|
|
* The functions here implement the state management and hardware programming
|
|
* dispatch required by the atomic modeset infrastructure.
|
|
* See intel_atomic_plane.c for the plane-specific atomic functionality.
|
|
*/
|
|
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_fourcc.h>
|
|
#include <drm/drm_plane_helper.h>
|
|
|
|
#include "intel_atomic.h"
|
|
#include "intel_drv.h"
|
|
#include "intel_hdcp.h"
|
|
#include "intel_sprite.h"
|
|
|
|
/**
|
|
* intel_digital_connector_atomic_get_property - hook for connector->atomic_get_property.
|
|
* @connector: Connector to get the property for.
|
|
* @state: Connector state to retrieve the property from.
|
|
* @property: Property to retrieve.
|
|
* @val: Return value for the property.
|
|
*
|
|
* Returns the atomic property value for a digital connector.
|
|
*/
|
|
int intel_digital_connector_atomic_get_property(struct drm_connector *connector,
|
|
const struct drm_connector_state *state,
|
|
struct drm_property *property,
|
|
u64 *val)
|
|
{
|
|
struct drm_device *dev = connector->dev;
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
|
struct intel_digital_connector_state *intel_conn_state =
|
|
to_intel_digital_connector_state(state);
|
|
|
|
if (property == dev_priv->force_audio_property)
|
|
*val = intel_conn_state->force_audio;
|
|
else if (property == dev_priv->broadcast_rgb_property)
|
|
*val = intel_conn_state->broadcast_rgb;
|
|
else {
|
|
DRM_DEBUG_ATOMIC("Unknown property [PROP:%d:%s]\n",
|
|
property->base.id, property->name);
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* intel_digital_connector_atomic_set_property - hook for connector->atomic_set_property.
|
|
* @connector: Connector to set the property for.
|
|
* @state: Connector state to set the property on.
|
|
* @property: Property to set.
|
|
* @val: New value for the property.
|
|
*
|
|
* Sets the atomic property value for a digital connector.
|
|
*/
|
|
int intel_digital_connector_atomic_set_property(struct drm_connector *connector,
|
|
struct drm_connector_state *state,
|
|
struct drm_property *property,
|
|
u64 val)
|
|
{
|
|
struct drm_device *dev = connector->dev;
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
|
struct intel_digital_connector_state *intel_conn_state =
|
|
to_intel_digital_connector_state(state);
|
|
|
|
if (property == dev_priv->force_audio_property) {
|
|
intel_conn_state->force_audio = val;
|
|
return 0;
|
|
}
|
|
|
|
if (property == dev_priv->broadcast_rgb_property) {
|
|
intel_conn_state->broadcast_rgb = val;
|
|
return 0;
|
|
}
|
|
|
|
DRM_DEBUG_ATOMIC("Unknown property [PROP:%d:%s]\n",
|
|
property->base.id, property->name);
|
|
return -EINVAL;
|
|
}
|
|
|
|
int intel_digital_connector_atomic_check(struct drm_connector *conn,
|
|
struct drm_atomic_state *state)
|
|
{
|
|
struct drm_connector_state *new_state =
|
|
drm_atomic_get_new_connector_state(state, conn);
|
|
struct intel_digital_connector_state *new_conn_state =
|
|
to_intel_digital_connector_state(new_state);
|
|
struct drm_connector_state *old_state =
|
|
drm_atomic_get_old_connector_state(state, conn);
|
|
struct intel_digital_connector_state *old_conn_state =
|
|
to_intel_digital_connector_state(old_state);
|
|
struct drm_crtc_state *crtc_state;
|
|
|
|
intel_hdcp_atomic_check(conn, old_state, new_state);
|
|
|
|
if (!new_state->crtc)
|
|
return 0;
|
|
|
|
crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
|
|
|
|
/*
|
|
* These properties are handled by fastset, and might not end
|
|
* up in a modeset.
|
|
*/
|
|
if (new_conn_state->force_audio != old_conn_state->force_audio ||
|
|
new_conn_state->broadcast_rgb != old_conn_state->broadcast_rgb ||
|
|
new_conn_state->base.colorspace != old_conn_state->base.colorspace ||
|
|
new_conn_state->base.picture_aspect_ratio != old_conn_state->base.picture_aspect_ratio ||
|
|
new_conn_state->base.content_type != old_conn_state->base.content_type ||
|
|
new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode)
|
|
crtc_state->mode_changed = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* intel_digital_connector_duplicate_state - duplicate connector state
|
|
* @connector: digital connector
|
|
*
|
|
* Allocates and returns a copy of the connector state (both common and
|
|
* digital connector specific) for the specified connector.
|
|
*
|
|
* Returns: The newly allocated connector state, or NULL on failure.
|
|
*/
|
|
struct drm_connector_state *
|
|
intel_digital_connector_duplicate_state(struct drm_connector *connector)
|
|
{
|
|
struct intel_digital_connector_state *state;
|
|
|
|
state = kmemdup(connector->state, sizeof(*state), GFP_KERNEL);
|
|
if (!state)
|
|
return NULL;
|
|
|
|
__drm_atomic_helper_connector_duplicate_state(connector, &state->base);
|
|
return &state->base;
|
|
}
|
|
|
|
/**
|
|
* intel_crtc_duplicate_state - duplicate crtc state
|
|
* @crtc: drm crtc
|
|
*
|
|
* Allocates and returns a copy of the crtc state (both common and
|
|
* Intel-specific) for the specified crtc.
|
|
*
|
|
* Returns: The newly allocated crtc state, or NULL on failure.
|
|
*/
|
|
struct drm_crtc_state *
|
|
intel_crtc_duplicate_state(struct drm_crtc *crtc)
|
|
{
|
|
struct intel_crtc_state *crtc_state;
|
|
|
|
crtc_state = kmemdup(crtc->state, sizeof(*crtc_state), GFP_KERNEL);
|
|
if (!crtc_state)
|
|
return NULL;
|
|
|
|
__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state->base);
|
|
|
|
crtc_state->update_pipe = false;
|
|
crtc_state->disable_lp_wm = false;
|
|
crtc_state->disable_cxsr = false;
|
|
crtc_state->update_wm_pre = false;
|
|
crtc_state->update_wm_post = false;
|
|
crtc_state->fb_changed = false;
|
|
crtc_state->fifo_changed = false;
|
|
crtc_state->wm.need_postvbl_update = false;
|
|
crtc_state->fb_bits = 0;
|
|
crtc_state->update_planes = 0;
|
|
|
|
return &crtc_state->base;
|
|
}
|
|
|
|
/**
|
|
* intel_crtc_destroy_state - destroy crtc state
|
|
* @crtc: drm crtc
|
|
* @state: the state to destroy
|
|
*
|
|
* Destroys the crtc state (both common and Intel-specific) for the
|
|
* specified crtc.
|
|
*/
|
|
void
|
|
intel_crtc_destroy_state(struct drm_crtc *crtc,
|
|
struct drm_crtc_state *state)
|
|
{
|
|
drm_atomic_helper_crtc_destroy_state(crtc, state);
|
|
}
|
|
|
|
static void intel_atomic_setup_scaler(struct intel_crtc_scaler_state *scaler_state,
|
|
int num_scalers_need, struct intel_crtc *intel_crtc,
|
|
const char *name, int idx,
|
|
struct intel_plane_state *plane_state,
|
|
int *scaler_id)
|
|
{
|
|
struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev);
|
|
int j;
|
|
u32 mode;
|
|
|
|
if (*scaler_id < 0) {
|
|
/* find a free scaler */
|
|
for (j = 0; j < intel_crtc->num_scalers; j++) {
|
|
if (scaler_state->scalers[j].in_use)
|
|
continue;
|
|
|
|
*scaler_id = j;
|
|
scaler_state->scalers[*scaler_id].in_use = 1;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (WARN(*scaler_id < 0, "Cannot find scaler for %s:%d\n", name, idx))
|
|
return;
|
|
|
|
/* set scaler mode */
|
|
if (plane_state && plane_state->base.fb &&
|
|
plane_state->base.fb->format->is_yuv &&
|
|
plane_state->base.fb->format->num_planes > 1) {
|
|
struct intel_plane *plane = to_intel_plane(plane_state->base.plane);
|
|
if (IS_GEN(dev_priv, 9) &&
|
|
!IS_GEMINILAKE(dev_priv)) {
|
|
mode = SKL_PS_SCALER_MODE_NV12;
|
|
} else if (icl_is_hdr_plane(dev_priv, plane->id)) {
|
|
/*
|
|
* On gen11+'s HDR planes we only use the scaler for
|
|
* scaling. They have a dedicated chroma upsampler, so
|
|
* we don't need the scaler to upsample the UV plane.
|
|
*/
|
|
mode = PS_SCALER_MODE_NORMAL;
|
|
} else {
|
|
mode = PS_SCALER_MODE_PLANAR;
|
|
|
|
if (plane_state->linked_plane)
|
|
mode |= PS_PLANE_Y_SEL(plane_state->linked_plane->id);
|
|
}
|
|
} else if (INTEL_GEN(dev_priv) > 9 || IS_GEMINILAKE(dev_priv)) {
|
|
mode = PS_SCALER_MODE_NORMAL;
|
|
} else if (num_scalers_need == 1 && intel_crtc->num_scalers > 1) {
|
|
/*
|
|
* when only 1 scaler is in use on a pipe with 2 scalers
|
|
* scaler 0 operates in high quality (HQ) mode.
|
|
* In this case use scaler 0 to take advantage of HQ mode
|
|
*/
|
|
scaler_state->scalers[*scaler_id].in_use = 0;
|
|
*scaler_id = 0;
|
|
scaler_state->scalers[0].in_use = 1;
|
|
mode = SKL_PS_SCALER_MODE_HQ;
|
|
} else {
|
|
mode = SKL_PS_SCALER_MODE_DYN;
|
|
}
|
|
|
|
DRM_DEBUG_KMS("Attached scaler id %u.%u to %s:%d\n",
|
|
intel_crtc->pipe, *scaler_id, name, idx);
|
|
scaler_state->scalers[*scaler_id].mode = mode;
|
|
}
|
|
|
|
/**
|
|
* intel_atomic_setup_scalers() - setup scalers for crtc per staged requests
|
|
* @dev_priv: i915 device
|
|
* @intel_crtc: intel crtc
|
|
* @crtc_state: incoming crtc_state to validate and setup scalers
|
|
*
|
|
* This function sets up scalers based on staged scaling requests for
|
|
* a @crtc and its planes. It is called from crtc level check path. If request
|
|
* is a supportable request, it attaches scalers to requested planes and crtc.
|
|
*
|
|
* This function takes into account the current scaler(s) in use by any planes
|
|
* not being part of this atomic state
|
|
*
|
|
* Returns:
|
|
* 0 - scalers were setup succesfully
|
|
* error code - otherwise
|
|
*/
|
|
int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,
|
|
struct intel_crtc *intel_crtc,
|
|
struct intel_crtc_state *crtc_state)
|
|
{
|
|
struct drm_plane *plane = NULL;
|
|
struct intel_plane *intel_plane;
|
|
struct intel_plane_state *plane_state = NULL;
|
|
struct intel_crtc_scaler_state *scaler_state =
|
|
&crtc_state->scaler_state;
|
|
struct drm_atomic_state *drm_state = crtc_state->base.state;
|
|
struct intel_atomic_state *intel_state = to_intel_atomic_state(drm_state);
|
|
int num_scalers_need;
|
|
int i;
|
|
|
|
num_scalers_need = hweight32(scaler_state->scaler_users);
|
|
|
|
/*
|
|
* High level flow:
|
|
* - staged scaler requests are already in scaler_state->scaler_users
|
|
* - check whether staged scaling requests can be supported
|
|
* - add planes using scalers that aren't in current transaction
|
|
* - assign scalers to requested users
|
|
* - as part of plane commit, scalers will be committed
|
|
* (i.e., either attached or detached) to respective planes in hw
|
|
* - as part of crtc_commit, scaler will be either attached or detached
|
|
* to crtc in hw
|
|
*/
|
|
|
|
/* fail if required scalers > available scalers */
|
|
if (num_scalers_need > intel_crtc->num_scalers){
|
|
DRM_DEBUG_KMS("Too many scaling requests %d > %d\n",
|
|
num_scalers_need, intel_crtc->num_scalers);
|
|
return -EINVAL;
|
|
}
|
|
|
|
/* walkthrough scaler_users bits and start assigning scalers */
|
|
for (i = 0; i < sizeof(scaler_state->scaler_users) * 8; i++) {
|
|
int *scaler_id;
|
|
const char *name;
|
|
int idx;
|
|
|
|
/* skip if scaler not required */
|
|
if (!(scaler_state->scaler_users & (1 << i)))
|
|
continue;
|
|
|
|
if (i == SKL_CRTC_INDEX) {
|
|
name = "CRTC";
|
|
idx = intel_crtc->base.base.id;
|
|
|
|
/* panel fitter case: assign as a crtc scaler */
|
|
scaler_id = &scaler_state->scaler_id;
|
|
} else {
|
|
name = "PLANE";
|
|
|
|
/* plane scaler case: assign as a plane scaler */
|
|
/* find the plane that set the bit as scaler_user */
|
|
plane = drm_state->planes[i].ptr;
|
|
|
|
/*
|
|
* to enable/disable hq mode, add planes that are using scaler
|
|
* into this transaction
|
|
*/
|
|
if (!plane) {
|
|
struct drm_plane_state *state;
|
|
plane = drm_plane_from_index(&dev_priv->drm, i);
|
|
state = drm_atomic_get_plane_state(drm_state, plane);
|
|
if (IS_ERR(state)) {
|
|
DRM_DEBUG_KMS("Failed to add [PLANE:%d] to drm_state\n",
|
|
plane->base.id);
|
|
return PTR_ERR(state);
|
|
}
|
|
|
|
/*
|
|
* the plane is added after plane checks are run,
|
|
* but since this plane is unchanged just do the
|
|
* minimum required validation.
|
|
*/
|
|
crtc_state->base.planes_changed = true;
|
|
}
|
|
|
|
intel_plane = to_intel_plane(plane);
|
|
idx = plane->base.id;
|
|
|
|
/* plane on different crtc cannot be a scaler user of this crtc */
|
|
if (WARN_ON(intel_plane->pipe != intel_crtc->pipe))
|
|
continue;
|
|
|
|
plane_state = intel_atomic_get_new_plane_state(intel_state,
|
|
intel_plane);
|
|
scaler_id = &plane_state->scaler_id;
|
|
}
|
|
|
|
intel_atomic_setup_scaler(scaler_state, num_scalers_need,
|
|
intel_crtc, name, idx,
|
|
plane_state, scaler_id);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct drm_atomic_state *
|
|
intel_atomic_state_alloc(struct drm_device *dev)
|
|
{
|
|
struct intel_atomic_state *state = kzalloc(sizeof(*state), GFP_KERNEL);
|
|
|
|
if (!state || drm_atomic_state_init(dev, &state->base) < 0) {
|
|
kfree(state);
|
|
return NULL;
|
|
}
|
|
|
|
return &state->base;
|
|
}
|
|
|
|
void intel_atomic_state_clear(struct drm_atomic_state *s)
|
|
{
|
|
struct intel_atomic_state *state = to_intel_atomic_state(s);
|
|
drm_atomic_state_default_clear(&state->base);
|
|
state->dpll_set = state->modeset = false;
|
|
}
|
|
|
|
struct intel_crtc_state *
|
|
intel_atomic_get_crtc_state(struct drm_atomic_state *state,
|
|
struct intel_crtc *crtc)
|
|
{
|
|
struct drm_crtc_state *crtc_state;
|
|
crtc_state = drm_atomic_get_crtc_state(state, &crtc->base);
|
|
if (IS_ERR(crtc_state))
|
|
return ERR_CAST(crtc_state);
|
|
|
|
return to_intel_crtc_state(crtc_state);
|
|
}
|