Fix following crash due to a leftover uninitialized mutex access
in mt76x2_set_rts_threshold routine.
[ 31.018059] Call Trace:
[ 31.018341] register_lock_class+0x51f/0x530
[ 31.018828] __lock_acquire+0x6c/0x1580
[ 31.019247] lock_acquire+0x88/0x120
[ 31.021089] __mutex_lock+0x4a/0x4f0
[ 31.023343] mt76x2_set_rts_threshold+0x28/0x50
[ 31.023831] ieee80211_set_wiphy_params+0x16d/0x4e0
[ 31.024344] nl80211_set_wiphy+0x72b/0xbc0
[ 31.024781] genl_family_rcv_msg+0x192/0x3a0
[ 31.025233] genl_rcv_msg+0x42/0x89
[ 31.026079] netlink_rcv_skb+0x38/0x100
[ 31.026475] genl_rcv+0x1f/0x30
[ 31.026804] netlink_unicast+0x19c/0x250
[ 31.027212] netlink_sendmsg+0x1ed/0x390
[ 31.027615] sock_sendmsg+0x31/0x40
[ 31.027973] ___sys_sendmsg+0x23c/0x280
[ 31.030414] __sys_sendmsg+0x42/0x80
[ 31.030783] do_syscall_64+0x4a/0x170
[ 31.031160] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[ 31.031677] RIP: 0033:0x7f3498b39ba7
[ 31.033953] RSP: 002b:00007fffe19675b8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
[ 31.034883] RAX: ffffffffffffffda RBX: 00000000012d5350 RCX: 00007f3498b39ba7
[ 31.035756] RDX: 0000000000000000 RSI: 00007fffe19675f0 RDI: 0000000000000003
[ 31.036587] RBP: 00000000012da740 R08: 0000000000000002 R09: 0000000000000000
[ 31.037422] R10: 0000000000000006 R11: 0000000000000246 R12: 00000000012da880
[ 31.038252] R13: 00007fffe19675f0 R14: 00007fffe19678c0 R15: 00000000012da880
Fixes: 108a4861ef
("mt76: create new mt76x02-lib module for common mt76x{0,2} code")
Reported-by: lorenzo.trisolini@fluidmesh.com
Reported-by: luca.bisti@fluidmesh.com
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
215 lines
5.9 KiB
C
215 lines
5.9 KiB
C
/*
|
|
* Copyright (C) 2016 Felix Fietkau <nbd@nbd.name>
|
|
* Copyright (C) 2018 Stanislaw Gruszka <stf_xl@wp.pl>
|
|
*
|
|
* Permission to use, copy, modify, and/or distribute this software for any
|
|
* purpose with or without fee is hereby granted, provided that the above
|
|
* copyright notice and this permission notice appear in all copies.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
|
|
#ifndef __MT76X02_UTIL_H
|
|
#define __MT76X02_UTIL_H
|
|
|
|
#include <linux/kfifo.h>
|
|
|
|
#include "mt76.h"
|
|
#include "mt76x02_regs.h"
|
|
#include "mt76x02_mac.h"
|
|
#include "mt76x02_dfs.h"
|
|
#include "mt76x02_dma.h"
|
|
|
|
struct mt76x02_mac_stats {
|
|
u64 rx_stat[6];
|
|
u64 tx_stat[6];
|
|
u64 aggr_stat[2];
|
|
u64 aggr_n[32];
|
|
u64 zero_len_del[2];
|
|
};
|
|
|
|
#define MT_MAX_CHAINS 2
|
|
struct mt76x02_rx_freq_cal {
|
|
s8 high_gain[MT_MAX_CHAINS];
|
|
s8 rssi_offset[MT_MAX_CHAINS];
|
|
s8 lna_gain;
|
|
u32 mcu_gain;
|
|
s16 temp_offset;
|
|
u8 freq_offset;
|
|
};
|
|
|
|
struct mt76x02_calibration {
|
|
struct mt76x02_rx_freq_cal rx;
|
|
|
|
u8 agc_gain_init[MT_MAX_CHAINS];
|
|
u8 agc_gain_cur[MT_MAX_CHAINS];
|
|
|
|
u16 false_cca;
|
|
s8 avg_rssi_all;
|
|
s8 agc_gain_adjust;
|
|
s8 low_gain;
|
|
|
|
s8 temp_vco;
|
|
s8 temp;
|
|
|
|
bool init_cal_done;
|
|
bool tssi_cal_done;
|
|
bool tssi_comp_pending;
|
|
bool dpd_cal_done;
|
|
bool channel_cal_done;
|
|
};
|
|
|
|
struct mt76x02_dev {
|
|
struct mt76_dev mt76; /* must be first */
|
|
|
|
struct mac_address macaddr_list[8];
|
|
|
|
struct mutex phy_mutex;
|
|
|
|
u8 txdone_seq;
|
|
DECLARE_KFIFO_PTR(txstatus_fifo, struct mt76x02_tx_status);
|
|
|
|
struct sk_buff *rx_head;
|
|
|
|
struct tasklet_struct tx_tasklet;
|
|
struct tasklet_struct pre_tbtt_tasklet;
|
|
struct delayed_work cal_work;
|
|
struct delayed_work mac_work;
|
|
|
|
struct mt76x02_mac_stats stats;
|
|
atomic_t avg_ampdu_len;
|
|
u32 aggr_stats[32];
|
|
|
|
struct sk_buff *beacons[8];
|
|
u8 beacon_mask;
|
|
u8 beacon_data_mask;
|
|
|
|
u8 tbtt_count;
|
|
u16 beacon_int;
|
|
|
|
struct mt76x02_calibration cal;
|
|
|
|
s8 target_power;
|
|
s8 target_power_delta[2];
|
|
bool enable_tpc;
|
|
|
|
bool no_2ghz;
|
|
|
|
u8 coverage_class;
|
|
u8 slottime;
|
|
|
|
struct mt76x02_dfs_pattern_detector dfs_pd;
|
|
};
|
|
|
|
extern struct ieee80211_rate mt76x02_rates[12];
|
|
|
|
void mt76x02_configure_filter(struct ieee80211_hw *hw,
|
|
unsigned int changed_flags,
|
|
unsigned int *total_flags, u64 multicast);
|
|
int mt76x02_sta_add(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
|
|
struct ieee80211_sta *sta);
|
|
int mt76x02_sta_remove(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
|
|
struct ieee80211_sta *sta);
|
|
|
|
void mt76x02_vif_init(struct mt76x02_dev *dev, struct ieee80211_vif *vif,
|
|
unsigned int idx);
|
|
int mt76x02_add_interface(struct ieee80211_hw *hw,
|
|
struct ieee80211_vif *vif);
|
|
void mt76x02_remove_interface(struct ieee80211_hw *hw,
|
|
struct ieee80211_vif *vif);
|
|
|
|
int mt76x02_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
|
|
struct ieee80211_ampdu_params *params);
|
|
int mt76x02_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
|
|
struct ieee80211_vif *vif, struct ieee80211_sta *sta,
|
|
struct ieee80211_key_conf *key);
|
|
int mt76x02_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
|
|
u16 queue, const struct ieee80211_tx_queue_params *params);
|
|
void mt76x02_sta_rate_tbl_update(struct ieee80211_hw *hw,
|
|
struct ieee80211_vif *vif,
|
|
struct ieee80211_sta *sta);
|
|
s8 mt76x02_tx_get_max_txpwr_adj(struct mt76x02_dev *dev,
|
|
const struct ieee80211_tx_rate *rate);
|
|
s8 mt76x02_tx_get_txpwr_adj(struct mt76x02_dev *dev, s8 txpwr,
|
|
s8 max_txpwr_adj);
|
|
void mt76x02_tx_set_txpwr_auto(struct mt76x02_dev *dev, s8 txpwr);
|
|
int mt76x02_insert_hdr_pad(struct sk_buff *skb);
|
|
void mt76x02_remove_hdr_pad(struct sk_buff *skb, int len);
|
|
void mt76x02_tx_complete(struct mt76_dev *dev, struct sk_buff *skb);
|
|
bool mt76x02_tx_status_data(struct mt76_dev *mdev, u8 *update);
|
|
void mt76x02_queue_rx_skb(struct mt76_dev *mdev, enum mt76_rxq_id q,
|
|
struct sk_buff *skb);
|
|
void mt76x02_rx_poll_complete(struct mt76_dev *mdev, enum mt76_rxq_id q);
|
|
irqreturn_t mt76x02_irq_handler(int irq, void *dev_instance);
|
|
void mt76x02_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control,
|
|
struct sk_buff *skb);
|
|
int mt76x02_tx_prepare_skb(struct mt76_dev *mdev, void *txwi,
|
|
struct sk_buff *skb, struct mt76_queue *q,
|
|
struct mt76_wcid *wcid, struct ieee80211_sta *sta,
|
|
u32 *tx_info);
|
|
|
|
extern const u16 mt76x02_beacon_offsets[16];
|
|
void mt76x02_set_beacon_offsets(struct mt76x02_dev *dev);
|
|
void mt76x02_set_irq_mask(struct mt76x02_dev *dev, u32 clear, u32 set);
|
|
void mt76x02_mac_start(struct mt76x02_dev *dev);
|
|
|
|
static inline bool is_mt76x2(struct mt76x02_dev *dev)
|
|
{
|
|
return mt76_chip(&dev->mt76) == 0x7612 ||
|
|
mt76_chip(&dev->mt76) == 0x7662 ||
|
|
mt76_chip(&dev->mt76) == 0x7602;
|
|
}
|
|
|
|
static inline void mt76x02_irq_enable(struct mt76x02_dev *dev, u32 mask)
|
|
{
|
|
mt76x02_set_irq_mask(dev, 0, mask);
|
|
}
|
|
|
|
static inline void mt76x02_irq_disable(struct mt76x02_dev *dev, u32 mask)
|
|
{
|
|
mt76x02_set_irq_mask(dev, mask, 0);
|
|
}
|
|
|
|
static inline bool
|
|
mt76x02_wait_for_txrx_idle(struct mt76_dev *dev)
|
|
{
|
|
return __mt76_poll_msec(dev, MT_MAC_STATUS,
|
|
MT_MAC_STATUS_TX | MT_MAC_STATUS_RX,
|
|
0, 100);
|
|
}
|
|
|
|
static inline struct mt76x02_sta *
|
|
mt76x02_rx_get_sta(struct mt76_dev *dev, u8 idx)
|
|
{
|
|
struct mt76_wcid *wcid;
|
|
|
|
if (idx >= ARRAY_SIZE(dev->wcid))
|
|
return NULL;
|
|
|
|
wcid = rcu_dereference(dev->wcid[idx]);
|
|
if (!wcid)
|
|
return NULL;
|
|
|
|
return container_of(wcid, struct mt76x02_sta, wcid);
|
|
}
|
|
|
|
static inline struct mt76_wcid *
|
|
mt76x02_rx_get_sta_wcid(struct mt76x02_sta *sta, bool unicast)
|
|
{
|
|
if (!sta)
|
|
return NULL;
|
|
|
|
if (unicast)
|
|
return &sta->wcid;
|
|
else
|
|
return &sta->vif->group_wcid;
|
|
}
|
|
|
|
#endif
|