linux/drivers/net/bonding
dingtianhong 00503b6f70 bonding: fail_over_mac should only affect AB mode at enslave and removal processing
According to bonding.txt, the fail_over_ma should only affect active-backup mode,
but I found that the fail_over_mac could be set to active or follow in all
modes, this will cause new slave could not be set to bond's MAC address at
enslave processing and restore its own MAC address at removal processing.

The correct way to fix the problem is that we should not add restrictions when
setting options, just need to modify the bond enslave and removal processing
to check the mode in addition to fail_over_mac when setting a slave's MAC during
enslavement. The change active slave processing already only calls the fail_over_mac
function when in active-backup mode.

Thanks for Jay's suggestion.

The patch also modify the pr_warning() to pr_warn().

Cc: Jay Vosburgh <fubar@us.ibm.com>
Cc: Veaceslav Falico <vfalico@redhat.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-02-04 19:47:27 -08:00
..
bond_3ad.c bonding: fix __get_active_agg() RCU logic 2014-01-13 22:22:27 -08:00
bond_3ad.h bonding: remove the return value for bond_3ad_bind_slave() 2014-01-01 22:58:55 -05:00
bond_alb.c bonding: slight optimization for bond_alb_xmit() 2014-01-01 22:58:15 -05:00
bond_alb.h drivers/net/*: Fix FSF address in file headers 2013-12-06 12:37:55 -05:00
bond_debugfs.c bonding: delete migrated IP addresses from the rlb hash table 2012-11-30 12:07:27 -05:00
bond_main.c bonding: fail_over_mac should only affect AB mode at enslave and removal processing 2014-02-04 19:47:27 -08:00
bond_netlink.c bonding: convert netlink to use slave data info api 2014-01-22 21:57:17 -08:00
bond_options.c bonding: fix u64 division 2014-01-23 16:10:24 -08:00
bond_options.h bonding: convert slaves to use the new option API 2014-01-22 15:38:44 -08:00
bond_procfs.c bonding: convert primary_reselect to use the new option API 2014-01-22 15:38:43 -08:00
bond_sysfs_slave.c bonding: change name of sysfs dir for bonding slaves 2014-01-22 21:57:05 -08:00
bond_sysfs.c bonding: convert slaves to use the new option API 2014-01-22 15:38:44 -08:00
bonding.h bonding: fix locking in bond_loadbalance_arp_mon() 2014-01-28 23:48:33 -08:00
Makefile bonding: add sysfs /slave dir for bond slave devices. 2014-01-17 18:51:58 -08:00