forked from Minki/linux
71c86cda75
By default, we create two hybrid cache events, one is for cpu_core, and
another is for cpu_atom. But Some hybrid hardware cache events are only
available on one CPU PMU. For example, the 'L1-dcache-load-misses' is only
available on cpu_core, while the 'L1-icache-loads' is only available on
cpu_atom. We need to remove "not supported" hybrid cache events. By
extending is_event_supported() to global API and using it to check if the
hybrid cache events are supported before being created, we can remove the
"not supported" hybrid cache events.
Before:
# ./perf stat -e L1-dcache-load-misses,L1-icache-loads -a sleep 1
Performance counter stats for 'system wide':
52,570 cpu_core/L1-dcache-load-misses/
<not supported> cpu_atom/L1-dcache-load-misses/
<not supported> cpu_core/L1-icache-loads/
1,471,817 cpu_atom/L1-icache-loads/
1.004915229 seconds time elapsed
After:
# ./perf stat -e L1-dcache-load-misses,L1-icache-loads -a sleep 1
Performance counter stats for 'system wide':
54,510 cpu_core/L1-dcache-load-misses/
1,441,286 cpu_atom/L1-icache-loads/
1.005114281 seconds time elapsed
Fixes: 30def61f64
("perf parse-events: Create two hybrid cache events")
Reported-by: Yi Ammy <ammy.yi@intel.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Acked-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20220923030013.3726410-2-zhengjun.xing@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
256 lines
8.0 KiB
C
256 lines
8.0 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __PERF_PARSE_EVENTS_H
|
|
#define __PERF_PARSE_EVENTS_H
|
|
/*
|
|
* Parse symbolic events/counts passed in as options:
|
|
*/
|
|
|
|
#include <linux/list.h>
|
|
#include <stdbool.h>
|
|
#include <linux/types.h>
|
|
#include <linux/perf_event.h>
|
|
#include <string.h>
|
|
|
|
struct evsel;
|
|
struct evlist;
|
|
struct parse_events_error;
|
|
|
|
struct option;
|
|
struct perf_pmu;
|
|
|
|
bool have_tracepoints(struct list_head *evlist);
|
|
bool is_event_supported(u8 type, u64 config);
|
|
|
|
const char *event_type(int type);
|
|
|
|
int parse_events_option(const struct option *opt, const char *str, int unset);
|
|
int parse_events_option_new_evlist(const struct option *opt, const char *str, int unset);
|
|
__attribute__((nonnull(1, 2, 3)))
|
|
int __parse_events(struct evlist *evlist, const char *str, struct parse_events_error *error,
|
|
struct perf_pmu *fake_pmu);
|
|
|
|
__attribute__((nonnull))
|
|
static inline int parse_events(struct evlist *evlist, const char *str,
|
|
struct parse_events_error *err)
|
|
{
|
|
return __parse_events(evlist, str, err, NULL);
|
|
}
|
|
|
|
int parse_event(struct evlist *evlist, const char *str);
|
|
|
|
int parse_events_terms(struct list_head *terms, const char *str);
|
|
int parse_filter(const struct option *opt, const char *str, int unset);
|
|
int exclude_perf(const struct option *opt, const char *arg, int unset);
|
|
|
|
enum perf_pmu_event_symbol_type {
|
|
PMU_EVENT_SYMBOL_ERR, /* not a PMU EVENT */
|
|
PMU_EVENT_SYMBOL, /* normal style PMU event */
|
|
PMU_EVENT_SYMBOL_PREFIX, /* prefix of pre-suf style event */
|
|
PMU_EVENT_SYMBOL_SUFFIX, /* suffix of pre-suf style event */
|
|
PMU_EVENT_SYMBOL_SUFFIX2, /* suffix of pre-suf2 style event */
|
|
};
|
|
|
|
enum {
|
|
PARSE_EVENTS__TERM_TYPE_NUM,
|
|
PARSE_EVENTS__TERM_TYPE_STR,
|
|
};
|
|
|
|
enum {
|
|
PARSE_EVENTS__TERM_TYPE_USER,
|
|
PARSE_EVENTS__TERM_TYPE_CONFIG,
|
|
PARSE_EVENTS__TERM_TYPE_CONFIG1,
|
|
PARSE_EVENTS__TERM_TYPE_CONFIG2,
|
|
PARSE_EVENTS__TERM_TYPE_NAME,
|
|
PARSE_EVENTS__TERM_TYPE_SAMPLE_PERIOD,
|
|
PARSE_EVENTS__TERM_TYPE_SAMPLE_FREQ,
|
|
PARSE_EVENTS__TERM_TYPE_BRANCH_SAMPLE_TYPE,
|
|
PARSE_EVENTS__TERM_TYPE_TIME,
|
|
PARSE_EVENTS__TERM_TYPE_CALLGRAPH,
|
|
PARSE_EVENTS__TERM_TYPE_STACKSIZE,
|
|
PARSE_EVENTS__TERM_TYPE_NOINHERIT,
|
|
PARSE_EVENTS__TERM_TYPE_INHERIT,
|
|
PARSE_EVENTS__TERM_TYPE_MAX_STACK,
|
|
PARSE_EVENTS__TERM_TYPE_MAX_EVENTS,
|
|
PARSE_EVENTS__TERM_TYPE_NOOVERWRITE,
|
|
PARSE_EVENTS__TERM_TYPE_OVERWRITE,
|
|
PARSE_EVENTS__TERM_TYPE_DRV_CFG,
|
|
PARSE_EVENTS__TERM_TYPE_PERCORE,
|
|
PARSE_EVENTS__TERM_TYPE_AUX_OUTPUT,
|
|
PARSE_EVENTS__TERM_TYPE_AUX_SAMPLE_SIZE,
|
|
PARSE_EVENTS__TERM_TYPE_METRIC_ID,
|
|
__PARSE_EVENTS__TERM_TYPE_NR,
|
|
};
|
|
|
|
struct parse_events_array {
|
|
size_t nr_ranges;
|
|
struct {
|
|
unsigned int start;
|
|
size_t length;
|
|
} *ranges;
|
|
};
|
|
|
|
struct parse_events_term {
|
|
char *config;
|
|
struct parse_events_array array;
|
|
union {
|
|
char *str;
|
|
u64 num;
|
|
} val;
|
|
int type_val;
|
|
int type_term;
|
|
struct list_head list;
|
|
bool used;
|
|
bool no_value;
|
|
|
|
/* error string indexes for within parsed string */
|
|
int err_term;
|
|
int err_val;
|
|
|
|
/* Coming from implicit alias */
|
|
bool weak;
|
|
};
|
|
|
|
struct parse_events_error {
|
|
int num_errors; /* number of errors encountered */
|
|
int idx; /* index in the parsed string */
|
|
char *str; /* string to display at the index */
|
|
char *help; /* optional help string */
|
|
int first_idx;/* as above, but for the first encountered error */
|
|
char *first_str;
|
|
char *first_help;
|
|
};
|
|
|
|
struct parse_events_state {
|
|
struct list_head list;
|
|
int idx;
|
|
int nr_groups;
|
|
struct parse_events_error *error;
|
|
struct evlist *evlist;
|
|
struct list_head *terms;
|
|
int stoken;
|
|
struct perf_pmu *fake_pmu;
|
|
char *hybrid_pmu_name;
|
|
};
|
|
|
|
void parse_events__shrink_config_terms(void);
|
|
int parse_events__is_hardcoded_term(struct parse_events_term *term);
|
|
int parse_events_term__num(struct parse_events_term **term,
|
|
int type_term, char *config, u64 num,
|
|
bool novalue,
|
|
void *loc_term, void *loc_val);
|
|
int parse_events_term__str(struct parse_events_term **term,
|
|
int type_term, char *config, char *str,
|
|
void *loc_term, void *loc_val);
|
|
int parse_events_term__sym_hw(struct parse_events_term **term,
|
|
char *config, unsigned idx);
|
|
int parse_events_term__clone(struct parse_events_term **new,
|
|
struct parse_events_term *term);
|
|
void parse_events_term__delete(struct parse_events_term *term);
|
|
void parse_events_terms__delete(struct list_head *terms);
|
|
void parse_events_terms__purge(struct list_head *terms);
|
|
void parse_events__clear_array(struct parse_events_array *a);
|
|
int parse_events__modifier_event(struct list_head *list, char *str, bool add);
|
|
int parse_events__modifier_group(struct list_head *list, char *event_mod);
|
|
int parse_events_name(struct list_head *list, const char *name);
|
|
int parse_events_add_tracepoint(struct list_head *list, int *idx,
|
|
const char *sys, const char *event,
|
|
struct parse_events_error *error,
|
|
struct list_head *head_config);
|
|
int parse_events_load_bpf(struct parse_events_state *parse_state,
|
|
struct list_head *list,
|
|
char *bpf_file_name,
|
|
bool source,
|
|
struct list_head *head_config);
|
|
/* Provide this function for perf test */
|
|
struct bpf_object;
|
|
int parse_events_load_bpf_obj(struct parse_events_state *parse_state,
|
|
struct list_head *list,
|
|
struct bpf_object *obj,
|
|
struct list_head *head_config);
|
|
int parse_events_add_numeric(struct parse_events_state *parse_state,
|
|
struct list_head *list,
|
|
u32 type, u64 config,
|
|
struct list_head *head_config);
|
|
int parse_events_add_tool(struct parse_events_state *parse_state,
|
|
struct list_head *list,
|
|
int tool_event);
|
|
int parse_events_add_cache(struct list_head *list, int *idx,
|
|
char *type, char *op_result1, char *op_result2,
|
|
struct parse_events_error *error,
|
|
struct list_head *head_config,
|
|
struct parse_events_state *parse_state);
|
|
int parse_events_add_breakpoint(struct list_head *list, int *idx,
|
|
u64 addr, char *type, u64 len);
|
|
int parse_events_add_pmu(struct parse_events_state *parse_state,
|
|
struct list_head *list, char *name,
|
|
struct list_head *head_config,
|
|
bool auto_merge_stats,
|
|
bool use_alias);
|
|
|
|
struct evsel *parse_events__add_event(int idx, struct perf_event_attr *attr,
|
|
const char *name, const char *metric_id,
|
|
struct perf_pmu *pmu);
|
|
|
|
int parse_events_multi_pmu_add(struct parse_events_state *parse_state,
|
|
char *str,
|
|
struct list_head *head_config,
|
|
struct list_head **listp);
|
|
|
|
int parse_events_copy_term_list(struct list_head *old,
|
|
struct list_head **new);
|
|
|
|
enum perf_pmu_event_symbol_type
|
|
perf_pmu__parse_check(const char *name);
|
|
void parse_events__set_leader(char *name, struct list_head *list,
|
|
struct parse_events_state *parse_state);
|
|
void parse_events_update_lists(struct list_head *list_event,
|
|
struct list_head *list_all);
|
|
void parse_events_evlist_error(struct parse_events_state *parse_state,
|
|
int idx, const char *str);
|
|
|
|
struct event_symbol {
|
|
const char *symbol;
|
|
const char *alias;
|
|
};
|
|
extern struct event_symbol event_symbols_hw[];
|
|
extern struct event_symbol event_symbols_sw[];
|
|
|
|
char *parse_events_formats_error_string(char *additional_terms);
|
|
|
|
void parse_events_error__init(struct parse_events_error *err);
|
|
void parse_events_error__exit(struct parse_events_error *err);
|
|
void parse_events_error__handle(struct parse_events_error *err, int idx,
|
|
char *str, char *help);
|
|
void parse_events_error__print(struct parse_events_error *err,
|
|
const char *event);
|
|
|
|
#ifdef HAVE_LIBELF_SUPPORT
|
|
/*
|
|
* If the probe point starts with '%',
|
|
* or starts with "sdt_" and has a ':' but no '=',
|
|
* then it should be a SDT/cached probe point.
|
|
*/
|
|
static inline bool is_sdt_event(char *str)
|
|
{
|
|
return (str[0] == '%' ||
|
|
(!strncmp(str, "sdt_", 4) &&
|
|
!!strchr(str, ':') && !strchr(str, '=')));
|
|
}
|
|
#else
|
|
static inline bool is_sdt_event(char *str __maybe_unused)
|
|
{
|
|
return false;
|
|
}
|
|
#endif /* HAVE_LIBELF_SUPPORT */
|
|
|
|
int perf_pmu__test_parse_init(void);
|
|
|
|
struct evsel *parse_events__add_event_hybrid(struct list_head *list, int *idx,
|
|
struct perf_event_attr *attr,
|
|
const char *name,
|
|
const char *metric_id,
|
|
struct perf_pmu *pmu,
|
|
struct list_head *config_terms);
|
|
|
|
#endif /* __PERF_PARSE_EVENTS_H */
|