GONG, Ruiqi abe3c63144 selinux: enable use of both GFP_KERNEL and GFP_ATOMIC in convert_context() ... The following warning was triggered on a hardware environment: SELinux: Converting 162 SID table entries... BUG: sleeping function called from invalid context at __might_sleep+0x60/0x74 0x0 in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 5943, name: tar CPU: 7 PID: 5943 Comm: tar Tainted: P O 5.10.0 #1 Call trace: dump_backtrace+0x0/0x1c8 show_stack+0x18/0x28 dump_stack+0xe8/0x15c ___might_sleep+0x168/0x17c __might_sleep+0x60/0x74 __kmalloc_track_caller+0xa0/0x7dc kstrdup+0x54/0xac convert_context+0x48/0x2e4 sidtab_context_to_sid+0x1c4/0x36c security_context_to_sid_core+0x168/0x238 security_context_to_sid_default+0x14/0x24 inode_doinit_use_xattr+0x164/0x1e4 inode_doinit_with_dentry+0x1c0/0x488 selinux_d_instantiate+0x20/0x34 security_d_instantiate+0x70/0xbc d_splice_alias+0x4c/0x3c0 ext4_lookup+0x1d8/0x200 [ext4] __lookup_slow+0x12c/0x1e4 walk_component+0x100/0x200 path_lookupat+0x88/0x118 filename_lookup+0x98/0x130 user_path_at_empty+0x48/0x60 vfs_statx+0x84/0x140 vfs_fstatat+0x20/0x30 __se_sys_newfstatat+0x30/0x74 __arm64_sys_newfstatat+0x1c/0x2c el0_svc_common.constprop.0+0x100/0x184 do_el0_svc+0x1c/0x2c el0_svc+0x20/0x34 el0_sync_handler+0x80/0x17c el0_sync+0x13c/0x140 SELinux: Context system_u:object_r:pssp_rsyslog_log_t:s0:c0 is not valid (left unmapped). It was found that within a critical section of spin_lock_irqsave in sidtab_context_to_sid(), convert_context() (hooked by sidtab_convert_params.func) might cause the process to sleep via allocating memory with GFP_KERNEL, which is problematic. As Ondrej pointed out [1], convert_context()/sidtab_convert_params.func has another caller sidtab_convert_tree(), which is okay with GFP_KERNEL. Therefore, fix this problem by adding a gfp_t argument for convert_context()/sidtab_convert_params.func and pass GFP_KERNEL/_ATOMIC properly in individual callers. Cc: stable@vger.kernel.org Link: https://lore.kernel.org/all/20221018120111.1474581-1-gongruiqi1@huawei.com/ [1] Reported-by: Tan Ninghao <tanninghao1@huawei.com> Fixes: ee1a84fdfe ("selinux: overhaul sidtab to fix bug and improve performance") Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com> Reviewed-by: Ondrej Mosnacek <omosnace@redhat.com> [PM: wrap long BUG() output lines, tweak subject line] Signed-off-by: Paul Moore <paul@paul-moore.com>		2022-10-19 09:55:53 -04:00
..
include	lsm/stable-6.1 PR 20221003	2022-10-03 17:51:52 -07:00
ss	selinux: enable use of both GFP_KERNEL and GFP_ATOMIC in convert_context()	2022-10-19 09:55:53 -04:00
.gitignore	.gitignore: add SPDX License Identifier	2020-03-25 11:50:48 +01:00
avc.c	selinux: declare data arrays const	2022-05-03 15:53:49 -04:00
hooks.c	whack-a-mole: constifying struct path *	2022-10-06 17:31:02 -07:00
ibpkey.c	selinux: various sparse fixes	2022-02-01 19:08:28 -05:00
ima.c	selinux/stable-5.18 PR 20220321	2022-03-21 20:47:54 -07:00
Kconfig	Documentation,selinux: deprecate setting checkreqprot to 1	2020-02-10 10:49:01 -05:00
Makefile	selinux: include a consumer of the new IMA critical data hook	2021-01-14 23:41:46 -05:00
netif.c	selinux: remove unused global variables	2021-01-12 09:49:01 -05:00
netlabel.c	security: pass asoc to sctp_assoc_request and sctp_sk_clone	2021-11-03 11:09:20 +00:00
netlink.c	selinux: mark some global variables __ro_after_init	2021-01-12 10:08:55 -05:00
netnode.c	selinux: various sparse fixes	2022-02-01 19:08:28 -05:00
netport.c	selinux: various sparse fixes	2022-02-01 19:08:28 -05:00
nlmsgtab.c	selinux: resolve checkpatch errors	2022-05-03 13:59:15 -04:00
selinuxfs.c	selinux: use int arrays for boolean values	2022-08-30 17:03:33 -04:00
status.c	selinux: move status variables out of selinux_ss	2020-02-10 10:49:01 -05:00
xfrm.c	selinux: use correct type for context length	2022-02-18 10:45:54 -05:00