forked from Minki/linux
1ea28bc554
drm_gem_plane_helper_prepare_fb() was using
drm_atomic_set_fence_for_plane() which ignores all implicit fences when an
explicit fence is already set. That's rather unfortunate when the fb still
has a kernel fence we need to wait for to avoid presenting garbage on the
screen.
So instead update the fence in the plane state directly. While at it also
take care of all potential GEM objects and not just the first one.
Also remove the now unused drm_atomic_set_fence_for_plane() function, new
drivers should probably use the atomic helpers directly.
v2: improve kerneldoc, use local variable and num_planes, WARN_ON_ONCE
on missing planes.
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> (v1)
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220429134230.24334-1-christian.koenig@amd.com
57 lines
2.1 KiB
C
57 lines
2.1 KiB
C
/*
|
|
* Copyright (C) 2014 Red Hat
|
|
* Copyright (C) 2014 Intel Corp.
|
|
* Copyright (C) 2018 Intel Corp.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* Authors:
|
|
* Rob Clark <robdclark@gmail.com>
|
|
* Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
*/
|
|
|
|
#ifndef DRM_ATOMIC_UAPI_H_
|
|
#define DRM_ATOMIC_UAPI_H_
|
|
|
|
struct drm_crtc_state;
|
|
struct drm_display_mode;
|
|
struct drm_property_blob;
|
|
struct drm_plane_state;
|
|
struct drm_crtc;
|
|
struct drm_connector_state;
|
|
struct dma_fence;
|
|
struct drm_framebuffer;
|
|
|
|
int __must_check
|
|
drm_atomic_set_mode_for_crtc(struct drm_crtc_state *state,
|
|
const struct drm_display_mode *mode);
|
|
int __must_check
|
|
drm_atomic_set_mode_prop_for_crtc(struct drm_crtc_state *state,
|
|
struct drm_property_blob *blob);
|
|
int __must_check
|
|
drm_atomic_set_crtc_for_plane(struct drm_plane_state *plane_state,
|
|
struct drm_crtc *crtc);
|
|
void drm_atomic_set_fb_for_plane(struct drm_plane_state *plane_state,
|
|
struct drm_framebuffer *fb);
|
|
int __must_check
|
|
drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state,
|
|
struct drm_crtc *crtc);
|
|
|
|
#endif
|