linux/drivers/gpu/drm/vc4
Yuan Can cf53db768a
drm/vc4: Fix missing platform_unregister_drivers() call in vc4_drm_register()
A problem about modprobe vc4 failed is triggered with the following log
given:

 [  420.327987] Error: Driver 'vc4_hvs' is already registered, aborting...
 [  420.333904] failed to register platform driver vc4_hvs_driver [vc4]: -16
 modprobe: ERROR: could not insert 'vc4': Device or resource busy

The reason is that vc4_drm_register() returns platform_driver_register()
directly without checking its return value, if platform_driver_register()
fails, it returns without unregistering all the vc4 drivers, resulting the
vc4 can never be installed later.
A simple call graph is shown as below:

 vc4_drm_register()
   platform_register_drivers() # all vc4 drivers are registered
   platform_driver_register()
     driver_register()
       bus_add_driver()
         priv = kzalloc(...) # OOM happened
   # return without unregister drivers

Fixing this problem by checking the return value of
platform_driver_register() and do platform_unregister_drivers() if
error happened.

Fixes: c8b75bca92 ("drm/vc4: Add KMS support for Raspberry Pi.")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20221103014705.109322-1-yuancan@huawei.com
2022-11-07 11:29:40 +01:00
..
Kconfig drm/vc4: hdmi: Depends on CONFIG_PM 2022-08-18 17:14:58 +02:00
Makefile
vc4_bo.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
vc4_crtc.c drm/vc4: crtc: protect device resources after removal 2022-08-25 09:44:26 +02:00
vc4_debugfs.c drm/vc4: debugfs: Simplify debugfs registration 2022-07-13 10:46:13 +02:00
vc4_dpi.c drm/vc4: debugfs: Simplify debugfs registration 2022-07-13 10:46:13 +02:00
vc4_drv.c drm/vc4: Fix missing platform_unregister_drivers() call in vc4_drm_register() 2022-11-07 11:29:40 +01:00
vc4_drv.h drm/gem: rename GEM CMA helpers to GEM DMA helpers 2022-08-03 18:31:49 +02:00
vc4_dsi.c drm/vc4: debugfs: Simplify debugfs registration 2022-07-13 10:46:13 +02:00
vc4_fence.c
vc4_gem.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
vc4_hdmi_phy.c drm/vc4: hdmi: Rename pixel_rate variable 2022-03-24 13:43:59 +01:00
vc4_hdmi_regs.h drm/vc4: hdmi: Add MISC_CONTROL register for vc4 2022-06-28 14:56:08 +02:00
vc4_hdmi.c drm/vc4: hdmi: Fix HSM clock too low on Pi4 2022-11-03 09:26:42 +01:00
vc4_hdmi.h drm/vc4: hdmi: Fix HSM clock too low on Pi4 2022-11-03 09:26:42 +01:00
vc4_hvs.c drm/vc4: hvs: protect drm_print_regset32() 2022-08-25 09:44:26 +02:00
vc4_irq.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
vc4_kms.c drm: Remove unnecessary include statements of drm_plane_helper.h 2022-07-26 18:42:04 +02:00
vc4_packet.h
vc4_perfmon.c drm/vc4: perfmon: Add missing mutex_destroy 2022-07-13 10:46:13 +02:00
vc4_plane.c drm/vc4: plane: protect device resources after removal 2022-08-25 09:44:25 +02:00
vc4_qpu_defines.h
vc4_regs.h drm/vc4: drop unexpected word "the" in the comments 2022-06-22 09:22:55 +02:00
vc4_render_cl.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
vc4_trace_points.c
vc4_trace.h
vc4_txp.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
vc4_v3d.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
vc4_validate_shaders.c drm/gem: rename GEM CMA helpers to GEM DMA helpers 2022-08-03 18:31:49 +02:00
vc4_validate.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
vc4_vec.c drm/vc4: vec: Fix timings for VEC modes 2022-09-07 10:28:48 +02:00