Commit Graph

828 Commits

Author SHA1 Message Date
Aybuke Ozdemir
f9974e75bc staging: rtl8723au: hal: Fix unnecessary whitespace before a quoted newline
Fix checkpatch.pl issues with unnecessary whitespace before a quoted
newline in hal_com.c

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 23:11:26 -04:00
Rahul Garg
1da2a44bf8 patch "staging: rtl8723au: os_dep: declared cfg80211_infrastructure_mode static
Declared cfg80211_infrastructure_mode method static to remove sparse warning

Signed-off-by: Rahul Garg <rahul.lnmiit@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:06:13 -04:00
Tapasweni Pathak
7d36429167 staging: rtl8723au: core: add consistent spacing around '-'
This patch fixes checkpatch.pl error in file rtw_ap.c
ERROR: need consistent spacing around '-' (ctx:WxV)

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-23 13:51:45 -07:00
Aybuke Ozdemir
1f0f6c9862 Staging: rtl8723au: hal: Space prohibited before semicolon
This patch fixes these warning messages found by checkpatch.pl:
WARNING: Space prohibited before semicolon.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:30:11 -07:00
Aybuke Ozdemir
8c09757d91 Staging: rtl8723au: core: Fix unnecassary braces warning.
This patch fixes these warning messages found by checkpatch.pl:
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:30:11 -07:00
Aybuke Ozdemir
867ce1bd68 Staging: rtl8723au: core: Fix "foo * bar" warning.
This patch fixes these error messages found by checkpatch.pl:
ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:30:11 -07:00
Greg Donald
c895a5df85 drivers: staging: rtl8723au: Fix "space required after that ','" errors
Fix checkpatch.pl "space required after that ','" errors

Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:28:04 -07:00
Kieron Browne
f78c0710cd staging: rtl8723au: fix sparse incorrect type assignment warnings
Use cpu_to_le16 to cast int for assignment to __le16 members

Signed-off-by: Kieron Browne <kieron.browne@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:28:04 -07:00
MihaelaGaman
adabff85c9 staging: rtl8723au: Fix checkpatch errors
Fix checkpatch.pl "spaces required around":
>, =, =, =, =, +=, >, >, <, <, :, <  errors.

Signed-off-by: MihaelaGaman <mp.gaman@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:28:04 -07:00
Greg Donald
a82b4b018a drivers: staging: rtl8723au: Fix 'code indent should use tabs where possible' errors
Fix checkpatch.pl 'code indent should use tabs where possible' errors

Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11 14:47:59 -07:00
Greg Donald
7e6646d50a drivers: staging: rtl8723au: Fix '"(foo*)" should be "(foo *)"' errors
Fix checkpatch.pl '"(foo*)" should be "(foo *)"' errors

Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-08 14:02:12 -07:00
Greg Donald
99dc94f322 drivers: staging: rtl8723au: Fix "space required before that '*'" errors
Fix checkpatch.pl "space required before that '*'" errors

Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-08 14:00:06 -07:00
Jes Sorensen
73cfb7b028 staging: rtl8723au: Remove write-only variables hal_data_8723a.EEPROM[VP]ID
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-08 13:44:22 -07:00
Greg Donald
1a834b96e2 drivers: staging: rtl8723au: Fix return is not a function, parentheses are not required error
Fix checkpatch.pl return is not a function, parentheses are not required error

Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-02 10:48:32 -07:00
Greg Donald
1beda8d52b drivers: staging: rtl8723au: Fix space prohibited before that close parenthesis ')' errors
Fix checkpatch.pl space prohibited before that close parenthesis ')' errors

Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30 13:54:53 -07:00
Greg Donald
4e66cf096c drivers: staging: rtl8723au: Fix "foo* bar" should be "foo *bar" errors
Fix checkpatch.pl "foo* bar" should be "foo *bar" errors

Signed-off-by: Greg Donald <gdonald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-30 13:54:53 -07:00
Andreas Schlick
2892d39797 staging: rtl8723au: Remove unnecessary bit masking.
Signed-off-by: Andreas Schlick <ninox@posteo.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-16 12:23:14 -07:00
Andreas Schlick
c5081c548e staging: rtl8723au: Move open braces to the previous line.
Correct coding style errors in rtw_efuse.c. checkpatch.pl reported:
ERROR: that open brace { should be on the previous line

Signed-off-by: Andreas Schlick <ninox@posteo.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-16 12:23:14 -07:00
Miguel Oliveira
1a4493c555 staging: rtl8723au: Fix static symbol sparse warning
Fix sparse warning:
drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol 'efuse_GetCurrentSize23a' was not declared. Should it be static?
by removing efuse_GetCurrentSize23a since its never used

Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:44:01 -07:00
Jes Sorensen
bd2dec915e staging: rtl8723au: usb_dvobj_init(): Remove unused variable 'pdev_desc'
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen
c8875b2f1f staging: rtl8723au: Do not duplicate kernel provided USB macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen
06736c2914 staging: rtl8723au: Remove never set struct pwrctrl_priv.bHWPowerdown
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen
a48dd468ef staging: rtl8723au: Remove two never set variables
struct registry_priv.usbss_enable and
struct pwrctrl_priv.bHWPwrPindetect are never set.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Jes Sorensen
1a8dcde8d3 staging: rtl8723au: RSSI_test is never set
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-08-01 14:43:37 -07:00
Masanari Iida
808bcb4e78 staging: rtl8723au: Fix typo in rtl8723au/core
This patch fix spelling typo in comments within
rtl8723au/core.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:09:08 -07:00
Masanari Iida
96b0a5baa9 staging: rtl8723au: Fix typo in rtw_ap.c
This patch fix spelling typo in comments within rtw_ap.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:09:08 -07:00
Masanari Iida
c582db4cb8 staging: rtl8723au: Fix typo in rtw_xmit.c
This patch fix spelling typo in comments within rtw_xmit.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:09:08 -07:00
Masanari Iida
7c17d2d9b4 staging: rtl8723au: Fix typo in rtw_mlme.c
This patch fix spelling typo in comments within rtw_mlme.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 16:08:13 -07:00
Masanari Iida
fae062ad57 staging: rtl8723au: Fix typo in rtw_mlme_ext.c
This patch fix spelling typo in comments within rtw_mlme_ext.c

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-22 15:47:19 -07:00
Jes Sorensen
d71c77b116 staging: rtl8723au: rtw_resume(): release semaphore before exit on error
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:28 -07:00
Jes Sorensen
30c588e04c staging: rtl8723au: Fold rtw_resume_process23a() into rtw_resume()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:28 -07:00
Jes Sorensen
dc20d1da78 staging: rtl8723au: Reduce wrapper layers around hal_{de, }init() calls
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:28 -07:00
Jes Sorensen
d0b39f8742 staging: rtl8723au: Fold rtl8723a_set_nav_upper() into rtl8723au_hal_init()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
62900ebf47 staging: rtl8723au: Remove a pile of fluff for calling into a bunch of no-op functions
The whole antenna diversity selection was completely pointless as all
the end functions called were no-ops.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
36cf7c75af staging: rtl8723au: odm_CommonInfoSelfInit23a(): Use proper register defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
62b0d72b3c staging: rtl8723au: Merge Init_ODM_ComInfo_8723a() into rtl8723a_init_dm_priv()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
bd9bda22d8 staging: rtl8723au: Remove obsolete ODM23a_CmnInfoHook()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
555f1ca7bc staging: rtl8723au: Eliminate obsolete odm_CmnInfoHook_Debug23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
638847c94b staging: rtl8723au: Eliminate ODM_CMNINFO_POWER_SAVING usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
1a573d2bbe staging: rtl8723au: Eliminate ODM_CMNINFO_SCAN related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
ac6c69d311 staging: rtl8723au: Eliminate ODM_CMNINFO_CHNL usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
301fc630ef staging: rtl8723au: Eliminate ODM_CMNINFO_BW usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
91a2916a82 staging: rtl8723au: Eliminate ugly ODM_CMNINFO_SEC_CHNL_OFFSET usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
ec8884fb20 staging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *
This will allow us to access variables in the hal_data struct
directly, and get rid of the horrendous ODM_CMNINFO spaghetti API.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
09b052a909 staging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:27 -07:00
Jes Sorensen
42f9f19ef5 staging: rtl8723au: Remove another pile of awful unused ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
c5f3dc2fef staging: rtl8723au: Remove another pile of useless ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
c17a426556 staging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
65064399c2 staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
353cb50dc7 staging: rtl8723au: Remove write-only variables struct dm_priv->{Init,}DMFlag
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00