Dan Carpenter
5c677869e0
vfio-mdev: buffer overflow in ioctl()
...
This is a sample driver for documentation so the impact is probably
pretty low. But we should check that bar_index is valid so we
don't write beyond the end of the mdev_state->region_info[] array.
Fixes: 9d1a546c53 ("docs: Sample driver to demonstrate how to use Mediated device framework.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com >
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
2017-01-11 12:12:29 -07:00
Dan Carpenter
6ed0993a0b
vfio-mdev: return -EFAULT if copy_to_user() fails
...
The copy_to_user() function returns the number of bytes which it wasn't
able to copy but we want to return a negative error code.
Fixes: 9d1a546c53 ("docs: Sample driver to demonstrate how to use Mediated device framework.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com >
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
2017-01-11 12:06:35 -07:00
Dan Carpenter
d293dbaa54
vfio-mdev: fix some error codes in the sample code
...
This is just sample code. We forget to set the error codes in a couple
places.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Reported-by: Alexey Khoroshilov <khoroshilov@ispras.ru >
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
2017-01-04 08:32:23 -07:00
Alex Williamson
99e3123e3d
vfio-mdev: Make mdev_device private and abstract interfaces
...
Abstract access to mdev_device so that we can define which interfaces
are public rather than relying on comments in the structure.
Cc: Zhenyu Wang <zhenyuw@linux.intel.com >
Cc: Zhi Wang <zhi.a.wang@intel.com >
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
Reviewed-by: Jike Song <jike.song@intel.com >
Reviewed by: Kirti Wankhede <kwankhede@nvidia.com >
2016-12-30 08:13:44 -07:00
Alex Williamson
9372e6feaa
vfio-mdev: Make mdev_parent private
...
Rather than hoping for good behavior by marking some elements
internal, enforce it by making the entire structure private and
creating an accessor function for the one useful external field.
Cc: Zhenyu Wang <zhenyuw@linux.intel.com >
Cc: Zhi Wang <zhi.a.wang@intel.com >
Cc: Jike Song <jike.song@intel.com >
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
Reviewed by: Kirti Wankhede <kwankhede@nvidia.com >
2016-12-30 08:13:41 -07:00
Alex Williamson
42930553a7
vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
...
Add an mdev_ prefix so we're not poluting the namespace so much.
Cc: Zhenyu Wang <zhenyuw@linux.intel.com >
Cc: Zhi Wang <zhi.a.wang@intel.com >
Cc: Jike Song <jike.song@intel.com >
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
Reviewed by: Kirti Wankhede <kwankhede@nvidia.com >
2016-12-30 08:13:38 -07:00
Alex Williamson
08c1a4ef7c
vfio-mdev: Fix mtty sample driver building
...
This sample driver was originally under Documentation/ and was moved
to samples, but build support was never adjusted for the new location.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
Reviewed-by: Eric Auger <eric.auger@redhat.com >
Tested-by: Eric Auger <eric.auger@redhat.com >
Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com >
2016-12-30 08:13:30 -07:00
Kirti Wankhede
9d1a546c53
docs: Sample driver to demonstrate how to use Mediated device framework.
...
The Sample driver creates mdev device that simulates serial port over PCI
card.
Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com >
Signed-off-by: Neo Jia <cjia@nvidia.com >
Signed-off-by: Alex Williamson <alex.williamson@redhat.com >
2016-11-17 09:18:44 -07:00