Commit Graph

23145 Commits

Author SHA1 Message Date
Gulsah Kose
6d56be08f7 staging: ft1000: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in ft1000.h

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 13:41:28 -07:00
Aybuke Ozdemir
8e3a3ce66e staging: as102: as10x_handle.h .Fix Unnecessary space after function pointer name
This patch removes the following checkpatch.pl warning in as10x_handle.h
Warning : Unnecessary space after function pointer name

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 13:41:27 -07:00
Tugce Sirin
d8720f8e57 Staging: wlan-ng: Fix smatch warning potential null reference
This patch fixes potential null dereference 'wlandev' in wlan-ng driver.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 13:41:27 -07:00
Aybuke Ozdemir
168934c9d4 staging: adc: mxs-lradc.c Fix line over 80 characters.
Fix checkpatch.pl issues with
line over 80 characters in mxs-lradc.c

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 13:41:27 -07:00
Tugce Sirin
88005c5fc0 Staging: lustre: Fix space required before the open parenthesis
This patch fixes space required before the open parenthesis in lustre
driver.

Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 13:41:27 -07:00
Ana Rey
9e93d7adb2 staging: rtl8192u: make in r819xU_cmdpkt.c some local functions static
Make some local functions static.

Fix sparse warnings in r819xU_cmdpkt.c

drivers/staging/rtl8192u/r819xU_cmdpkt.c:185:6: warning: symbol 'cmdpkt_beacontimerinterrupt_819xusb' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:36:25 -07:00
Ana Rey
6831574c68 staging: rtl8192u: make in ieee80211/ieee80211_wx.c a local variable static
Make some local variable eee80211_modes static.

Fix sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c:42:19: warning: symbol 'ieee80211_modes' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:36:25 -07:00
Ana Rey
e42c0e77fa staging: rtl8192u: Delete 'fwSendNullPacket' function in r819xU_firmware.c
Delete the fwSendNullPacket function that is not used in anywhere in
the driver.

Fix sparse warnings:
drivers/staging/rtl8192u/r819xU_firmware.c:109:1: warning: symbol 'fwSendNullPacket' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:36:25 -07:00
Ana Rey
2cc817c09e staging: rtl8192u: make in r819xU_firmware.c some local functions static
Make some local functions static (firmware_init_param, fw_download_code,
CPUcheck_maincodeok_turnonCPU and CPUcheck_firmware_ready) and fix
coding style in these function declarations when It is necessary.

Fixed the following sparse warnings in r819xU_firmware.c

  CHECK   drivers/staging/rtl8192u/r819xU_firmware.c
drivers/staging/rtl8192u/r819xU_firmware.c:20:6: warning: symbol 'firmware_init_param' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:32:6: warning: symbol 'fw_download_code' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:159:6: warning: symbol 'CPUcheck_maincodeok_turnonCPU' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:208:6: warning: symbol 'CPUcheck_firmware_ready' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:36:25 -07:00
Heena Sirwani
280c4c8f99 staging: bcm: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in Adapter.h

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:32:11 -07:00
Ana Rey
bf316434ae staging: rtl8192u: Delete duplicate function declarations and extern keyword
Delete the duplicate function declarations in r8192U_dm.c.

These function declarations are defined in r8192U_dm.h.

Also, delete the 'extern' keyword of these function definitions.

Fix the following sparse warnings:

  CHECK   drivers/staging/rtl8192u/r8192U_dm.c
drivers/staging/rtl8192u/r8192U_dm.c:159:1: warning: function 'init_hal_dm' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:179:13: warning: function 'deinit_hal_dm' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:245:17: warning: function 'hal_dm_watchdog' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:278:13: warning: function 'init_rate_adaptive' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:878:17: warning: function 'dm_txpower_trackingcallback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1609:13: warning: function 'dm_cck_txpower_adjust' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1776:13: warning: function 'dm_change_dynamic_initgain_thresh' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:2543:13: warning: function 'dm_init_edca_turbo' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:2782:17: warning: function 'dm_rf_pathcheck_workitemcallback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:3142:13: warning: function 'dm_fsync_timer_callback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:3481:13: warning: function 'dm_shadow_init' with external linkage has definition

Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:30:01 -07:00
Ana Rey
5cd3b24908 staging: rtl8192u: Delete 'DM_CTSToSelfSetting' function in r8192U_dm.c
Delete the DM_CTSToSelfSetting function that is not used in
anywhere in the driver.

Fix sparse warnings:
drivers/staging/rtl8192u/r8192U_dm.c:2623:6: warning: symbol 'DM_CTSToSelfSetting' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:30:01 -07:00
Ana Rey
e635b0793d staging: rtl8192u: Delete 'dm_change_fsync_setting' function in r8192U_dm.c
Delete the 'dm_change_fsync_setting' function that is not used in
anywhere in the driver.

Fix sparse warnings:

drivers/staging/rtl8192u/r8192U_dm.c:1812:6: warning: symbol 'dm_change_fsync_setting' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:30:01 -07:00
Ana Rey
5e41d62230 staging: rtl8192u: Fix whitespaces in function declarations in r8192U_dm.h
Fix whitespaces in function declarations in r8192U_dm.h

Signed-off-by: Ana Rey <anarey@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:29:55 -07:00
Aybuke Ozdemir
ba46b05257 staging/tidspbridge/rmgr/mgr.c Fix quoted string split across lines
This patch fixes "quoted string split across lines warning"
warning in mgr.c

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:27:39 -07:00
Gulsah Kose
5f830a520a staging: winbond: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in localpara.h

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:27:39 -07:00
Ebru Akagunduz
07c452d4b9 Staging: cxt1e1: Fix externs should be avoided in .c files in comet.c
Fix checkpatch.pl issues with externs should be
avoided in comet.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:17:23 -07:00
Ebru Akagunduz
7184aa9dbe Staging: cxt1e1: Fix use of volatile is usually wrong in comet.c
Fix checkpatch.pl issues with use of volatile is
usually wrong in comet.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:17:23 -07:00
Gulsah Kose
0d89475861 staging: rtl8821ae: Fix braces {} are not necessary.
Fix checkpatch.pl issues with braces {} are not necessary in base.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:14:58 -07:00
Gulsah Kose
66d8a3938e staging: rtl8821ae: Fix suspect code indent for conditional statements
Fix checkpatch.pl issues with suspect code indent for conditional
statements (16, 16) in base.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:14:58 -07:00
Ebru Akagunduz
3df1d9bddf Staging: comedi: Fix line over 80 characters in s626.c
Fix checkpatch.pl issues line over 80 characters
in s626.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:14:22 -07:00
Ebru Akagunduz
fbdc4001e3 Staging: comedi: Fix missing space after return type in s626.c
Fix checkpatch.pl issues with missing space after
return type in s626.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:14:22 -07:00
Elena Oat
9cdddda572 Staging: rtl8188eu: Fix warning of braces are not necessary.
This patch fixes the warning of "braces are not necessary for single
statement blocks" in file rtw_ieee80211.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:13:37 -07:00
Elena Oat
5366f6f685 Staging: rtl8188eu: Fix warning of space prohibited.
This patch fixes the warning of "space prohibited before semicolon" in
file rtw_efuse.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:13:37 -07:00
Elena Oat
bd18b0abc8 Staging: rtl8188eu: Fix warning of braces not necessary.
This small patch fixes the warning of "braces are
necessary for any arm of this statement" in file rtw_efuse.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:13:37 -07:00
Elena Oat
c6f5fbcd55 Staging: rtl8188eu: Fix warnings of no space before tabs.
This patch fixes the warning of "please, no space before tabs" in file
rtw_efuse.c. I have also modified the style of the comments for
readability.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:10:26 -07:00
Elena Oat
2275d2b763 Staging: rtl8188eu: Fix warning of space prohibited.
This small patch fixes the warning of "space prohibited before
semicolon" in file rtw_debug.c.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:10:26 -07:00
Chi Pham
792f32ac64 staging: rtl8188eu: Reduced nesting and improved coding style.
Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:10:26 -07:00
Aybuke Ozdemir
3b77f472c3 staging:lustre:lnet: lib-types.h Fix open brace '{' err.
Fix checkpatch.pl issues with open brace '{' following
struct go on the same line in lib-types.h

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:04:30 -07:00
Aybuke Ozdemir
b11866b31b staging:lustre:lnet: lib-types.h Fix unnecessary space func. pointer name.
Fix checkpatch.pl issues with
unnecessary space after function pointer name in lib-types.h

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:04:30 -07:00
Georgiana Rodica Chelu
a95cdab3ce staging: lustre: add an extra line
Add an extra line break between the variable
declaration and the rest of the code

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:04:30 -07:00
Elena Oat
9137c9df5e Staging: rtl8188eu: Fix warnings of no space before tabs.
This patch fixes the warnings of "please, no space before tabs" in the
file rtw_mlme.c. I have also modified the comment style and removed some
unnecessary tabs.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:01:49 -07:00
Elena Oat
b4ed18b1df Staging: rtl8188eu: Fix warnings of space prohibited.
This patch fixes the warnings of "space prohibited between function name
and open parenthesis" in file rtw_mlme.c.

While at it, I have also removed unneccessary tabs. Also one comment
that didn't make sense was removed.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:01:49 -07:00
Elena Oat
a318c9e0f4 Staging: rtl8188eu: Fix warning of braces {} are not necessary.
This patch fixes the warning of "braces {} are not necessary for single
statement blocks" in file rtw_mlme.c. I have removed the else statement
in one case, as it didn't have any value.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:01:49 -07:00
Malcolm Priestley
2033801522 staging: vt6656: s_uGetRTSCTSRsvTime fix return.
Always returns to __le16 type

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
2075f6547e staging: vt6656: vnt_rxtx_rsvtime_le16 fix return.
Always returns to __le16 type.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
5abe3d63ad staging: vt6656: s_uGetDataDuration use __le16.
s_uGetDataDuration always returns to __le16 type

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
7f591a1107 staging: vt6656: Correct return type s_uGetRTSCTSDuration.
s_uGetRTSCTSDuration always returns in __le16 type

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
c4cf6dfb8e staging: vt6656: rxtx endian correct return duration
All duration base types are __le16 correct back to cpu

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
dab085b139 staging: vt6656: vnt_time_stamp_off fix return to __le16
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
533f9d3adc staging: vt6656: struct vnt_tx_short_buf_head correct base types
Both variables duration and time_stamp_off are __le16 types

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
10bb39a043 staging: vt6656: rxtx Replace wTimeStampOff* variables
Fix base type to __le16 and remove camel case.

Camel case changes
wTimeStampOff* -> time_stamp_off*

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:19 -07:00
Malcolm Priestley
372108e7b8 staging: vt6656: rxtx Replace wCTSTxRrvTime_ba
Replace with cts_rrv_time_ba with __le16 base.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:18 -07:00
Malcolm Priestley
7fd5747f31 staging: vt6656: rxtx: Replace wCTSDuration*
Fix base type to __le16 and remove camel case.

Camel case changes
wCTSDuration* -> cts_duration*

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:18 -07:00
Malcolm Priestley
5ff627aedb staging: vt6656: rxtx: Replace wTxRrvTime*
Fix base type to __le16 and remove camel case.

Camel case changes
wTxRrvTime* -> rrv_time*

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:18 -07:00
Malcolm Priestley
85417bf0d7 staging: vt6656: rxtx: Replace wRTSTxRrvTime*
Fix base type to __le16 and remove camel case.

Camel case changes
wRTSTxRrvTime* -> rts_rrv_time*

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:18 -07:00
Malcolm Priestley
fadc3bdfd9 staging: vt6656: rxtx: Replace wRTSDuration* variables
Fix base type to __le16 and remove camel case.

Camel case changes
wRTSDuration* -> rts_duration*

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:18 -07:00
Malcolm Priestley
4e01117c2d staging: vt6656: rxtx Replace wDuration* variables.
Fix base type to __le16 and remove camel case.

Camel case changes
wDuration* -> duration*

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 09:00:18 -07:00
Mark Hounschell
bbfbe832ff staging: dgap: re-factor some more code for 80+ lines
This patch fixes more 80+ char lines as reported by checkpatch

Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 08:49:06 -07:00
Mark Hounschell
c43846a91f staging: dgap: get rid of DGAP_LOCK and DGAP_UNLOCK macros
This patch replaces the DGAP_LOCK and DGAP_UNLOCK macros with
spin_lock_irqsave spin_unlock_irqrestore.

Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19 08:49:06 -07:00